Juan Hernandez has posted comments on this change. Change subject: core: Close tags in OVF template writer (#832106) ......................................................................
Patch Set 3: > why didn't you remove it from the OvfWriter.Dispose() the dispose is closing > the document tag as well. As far as I understand the problem was that there was one call to "WriteEndElement" missing. If I add one call as I did and then remove one call from "Dispose", then the net result will be that there is one call missing anyway, and the generated XML document will be incorrect. -- To view, visit http://gerrit.ovirt.org/5506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d0e4ee41236fae98ccc1cccb346121260bcd75d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
