Tal Nisan has posted comments on this change.
Change subject: webamin: save network's parametrets in SetupNetwork
......................................................................
Patch Set 1: (4 inline comments)
....................................................
Commit Message
Line 7: webamin: save network's parametrets in SetupNetwork
Change to "webadmin"
Please add bugzilla number as in the commit template
Line 9: SetupNetworks- When editig a network through the
change to editing
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 101: public Map<String, NetworkParameters>
getNetwork2LastDetachParams() {
Please move the getter to the bottom of the class
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
Line 4:
Since this class is only used in the HostSetupNetworksModel context, I'd make
it an inner class inside HostSetupNetworksModel, but it's a matter of coding
style
--
To view, visit http://gerrit.ovirt.org/5545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21757b61dbe9bb70e9210330eeb1bca50f685302
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
