Tomas Jelinek has posted comments on this change.
Change subject: userportal: always enable edit console
......................................................................
Patch Set 1: (1 inline comment)
please see comment
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java
Line 56: if (!isConsoleEnabled(model) && disabledCss != null) {
The logic of deciding when the button is enabled is in the isConsoleEnabled
method. Until now, this two buttons where enabled or disabled together, so it
made sense to have it implemented here. Now as this changed, I would rename the
isConsoleEnabled to isEnabled, make it abstract and implement the specific
logic to the specific classes in SideTabExtendedVirtualMachineView: For the
edit button as "return true" and for open console the current content of the
isConsoleEnabled.
--
To view, visit http://gerrit.ovirt.org/5537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36c8d75f10605a8b85987bd080d5ae920103ca64
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
