Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: replacing Active-Directory to LDAP server in error message
..
core: replacing Active-Directory to LDAP server in error message
This patch replace
Yair Zaslavsky has posted comments on this change.
Change subject: core: replacing Active-Directory to LDAP server in error message
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Oved Ourfali has uploaded a new change for review.
Change subject: core: replacing Active-Directory to LDAP server in error message
..
core: replacing Active-Directory to LDAP server in error message
This patch replaces the "Act
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock UpdateVdsGroupCommandTest
..
Patch Set 8: Verified
rebasse
--
To view, visit http://gerrit.ovirt.org/4938
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock validator tests
..
Patch Set 8: Verified
rebasse
--
To view, visit http://gerrit.ovirt.org/4937
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock BackendTest
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending SUBMI
Allon Mureinik has posted comments on this change.
Change subject: core: Remove ConfigMocker
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending SUBMIT.
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock Hot[Un]PlugDiskToVmCommandTest
..
Patch Set 7: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4934
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock GetUserVmsByUserIdAndGroupsQueryTest
..
Patch Set 7: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4933
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock RemoveAdGroupCommandTest
..
Patch Set 7: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4932
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove BaseMockitoTest
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending SUBMIT
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock GetoVirtISOsTest
..
Patch Set 7: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4930
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 19: Looks good to me, but someone else must approve
(4 inline comments)
Looks good, some inline comments, nothing ma
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine: canDoAction for No up server found validation added in
Remove vds
..
engine: canDoAction for No up server found validation added in Remove vds
Added
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetAllVmTemplates query.
(#783087)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor sug
Kanagaraj M has abandoned this change.
Change subject: engine,webadmin: RunMultipleAction - execution and error
handling
..
Patch Set 1: Abandoned
As per the comments, I am abandoning this patch. A separate frontend
patch(htt
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 3: Verified
Tested it. Working fine.
--
To view, visit http://gerrit.ovirt.org/
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1051/
Build Number: 1051
Build Status: Fixed
Triggered By: Started by user Itamar Heim
-
Changes Since Last Success:
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: Adding remoteDb support to dwh
..
packaging: Adding remoteDb support to dwh
* Adding remote DB support to dwh.
Change-Id: Iec31497fceae9c335d6e
Yaniv Dary has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4707
To unsubscribe, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1100/
Build Number: 1100
Build Status: Fixed
Triggered By: Started by user Itamar Heim
-
Changes Since Last Success:
--
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1089/
Build Number: 1089
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,476,
Started by upstream project "ovirt_engine"
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1088/
Build Number: 1088
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,475
-
Chan
Rami Vaknin has posted comments on this change.
Change subject: engine: Alphanumeric sorting order for db query results (no bz)
..
Patch Set 1:
Eli, explicit index scan is not useful in small tables like rhevm uses, it even
sl
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1050/
Build Number: 1050
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,482,
Started by upstream project "ovirt_engine" build
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/893/
Build Number: 893
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,482,
Started by upstream project "ovirt_engine" build number
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Sharad Mishra has posted comments on this change.
Change subject: engine: expose compatibility version/qemu machine type via
engine-config tool
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/3893
To unsubsc
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1048/
Build Number: 1048
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,480
-
Changes Since
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: missing localized Attach-Detach Disk enum
..
webadmin: missing localized Attach-Detach Disk enum
Added missing localization for 'AttachDiskToVm'
Daniel Erez has posted comments on this change.
Change subject: webadmin: missing localized Attach-Detach Disk enum
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5082
To
Moti Asayag has posted comments on this change.
Change subject: core: nic validations on running VM
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
minor comments inside - beside looks fine
Daniel Erez has submitted this change and it was merged.
Change subject: core: ConfigurationValues Shareable and DirectLUN
..
core: ConfigurationValues Shareable and DirectLUN
Added 'ShareableDiskEnabled' and 'DirectLUNDiskEnab
Daniel Erez has posted comments on this change.
Change subject: core: ConfigurationValues Shareable and DirectLUN
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5009
To u
Moti Asayag has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 14: (6 inline comments)
File
backen
Daniel Erez has posted comments on this change.
Change subject: core: ConfigurationValues Shareable and DirectLUN
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5009
To u
Daniel Erez has posted comments on this change.
Change subject: webadmin: Set Spice & VNC console models to use different query
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Sharad Mishra has posted comments on this change.
Change subject: engine: expose compatibility version/qemu machine type via
engine-config tool
..
Patch Set 3: Verified
rebased.
this patch has been verified
--
To view, visit
Juan Hernandez has posted comments on this change.
Change subject: core: Fix notifier classpath (#828801)
..
Patch Set 1: Verified
Verified that after this change the service can be started. Configured a event
for engine shutd
Juan Hernandez has uploaded a new change for review.
Change subject: core: Fix notifier classpath (#828801)
..
core: Fix notifier classpath (#828801)
https://bugzilla.redhat.com/828801
The classpath of the nofification service
Yair Zaslavsky has posted comments on this change.
Change subject: core: More Autorecovery logging
..
Patch Set 1:
Laszlo,
I would like you to extend a bit more in the commit msg what was the request,
either than that, looks o
Tal Nisan has posted comments on this change.
Change subject: core: Permission filtering for GetAllVmTemplates query.
(#783087)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1047/
Build Number: 1047
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,477,
Started by upstream project "ovirt_engine" build
Juan Hernandez has uploaded a new change for review.
Change subject: core: Revert use of build-classpath in CA scripts (#827013)
..
core: Revert use of build-classpath in CA scripts (#827013)
https://bugzilla.redhat.com/827013
Sharad Mishra has posted comments on this change.
Change subject: core: adding logging to Migration logic
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/vd
Sharad Mishra has posted comments on this change.
Change subject: core: More Autorecovery logging
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5099
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: core: Remove AsyncQuery leftovers
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/m
Sharad Mishra has posted comments on this change.
Change subject: core: Permission filtering for GetAllVmTemplates query.
(#783087)
..
Patch Set 1: (1 inline comment)
File b
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 2:
I fixed both issues mentioned above, will submit new patch set. Guys, pleas
Allon Mureinik has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 4: (2 inline comments)
a small comment about int<->Integer, see inline.
.
Maor Lipchuk has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 16: (8 inline comments)
File backend/manager/dbscripts/storages_sa
Maor Lipchuk has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 17:
Please see patch 16 comments
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ov
Omer Frenkel has posted comments on this change.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4862
To unsu
Alex Lourie has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4707
Oved Ourfali has posted comments on this change.
Change subject: packaging: Fix ownership of lock directory
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5106
To unsubscribe, vis
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 6: Looks good to me, but someone else must approve
Yaniv, It's OK to push it.
Please make sure you push
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: property sheet: drop-down (#827710)
..
webadmin: property sheet: drop-down (#827710)
https://bugzilla.redhat.com/show_bug.cgi?id=827710
Curre
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: property sheet: drop-down (#827710)
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5097
To uns
Eli Mesika has submitted this change and it was merged.
Change subject: restapi: Add Vm Ballooning Support
..
restapi: Add Vm Ballooning Support
REST API implementation for balloon device support.
hange-Id: I50ae28e645c7236dbf0
Eli Mesika has posted comments on this change.
Change subject: restapi: Add Vm Ballooning Support
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5013
To unsubscribe, visit http://
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: MaxVmsInPool property is ignored (#823276)
..
webadmin: MaxVmsInPool property is ignored (#823276)
https://bugzilla.redhat.com/823276
>From vdc_optio
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Add version, retrans and timeo to inst_sp.sql
..
core: Add version, retrans and timeo to inst_sp.sql
Add the version, retrans and timeo parameter
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add version, retrans and timeo to inst_sp.sql
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5108
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add version, retrans and timeo to inst_sp.sql
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5108
To unsubscribe, vi
Juan Hernandez has posted comments on this change.
Change subject: core: Add version, retrans and timeo to inst_sp.sql
..
Patch Set 1: Verified
I verified that after this change the installation completes and the ISO
storage d
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add version, retrans and timeo to inst_sp.sql
..
core: Add version, retrans and timeo to inst_sp.sql
Add the version, retrans and timeo parameters to the
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: Fix ownership of lock directory
..
packaging: Fix ownership of lock directory
The directory /var/lock/ovirt-engine should be owned by the ovir
Oved Ourfali has posted comments on this change.
Change subject: packaging: Fix ownership of lock directory
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5106
To unsubscribe, vis
Ori Liel has posted comments on this change.
Change subject: restapi: Add Vm Ballooning Support
..
Patch Set 6: Looks good to me, approved
Approved, just please remove the unnecessary VmMapper changes before you submit
--
To v
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
engine: Rename ITDSDSGroupAttributes.java to ITDSGroupAttributes.java
There was
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Fix ownership of lock directory
..
packaging: Fix ownership of lock directory
The directory /var/lock/ovirt-engine should be owned by the ovirt
user
Oved Ourfali has posted comments on this change.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5080
T
Keith Robertson has posted comments on this change.
Change subject: Avoid silent success of ISO uploading
..
Patch Set 2: Do not submit
You aren't considering the fact that multiple files can be uploaded at one
time. As it st
Sharad Mishra has posted comments on this change.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
Patch Set 2: Verified
verified and rebased
--
To view, visit http://gerrit.ovirt.org/5
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Fix for GUI should check for volume name uniqueness
..
Patch Set 4: Verified
Rebased with master
--
To view, visit http://gerrit.ovirt.org/4963
To un
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1044/
Build Number: 1044
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,474
-
Changes Since
Eli Mesika has posted comments on this change.
Change subject: core: Remove temporary files used during database creation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5041
To unsubscribe, visit http://gerr
Eli Mesika has posted comments on this change.
Change subject: core: Remove temporary files used during database creation
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5041
To unsubscribe,
Ori Liel has uploaded a new change for review.
Change subject: restapi: display disk provisioned and actual size
..
restapi: display disk provisioned and actual size
Change-Id: I64c1c231e3d5e60ad35bacf8031775a7220fbb32
Signed-of
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 2:
Well there are actually two problems :(
1. filter both singular and plural
Omer Frenkel has posted comments on this change.
Change subject: core: adding logging to Migration logic
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsb
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1043/
Build Number: 1043
Build Status: Still unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,473
-
Chang
Roy Golan has posted comments on this change.
Change subject: core: adding logging to Migration logic
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsbrok
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 2:
Yeah, I got it now :-) this was quite tricky.
The problem is, main model d
Yaniv Kaul has posted comments on this change.
Change subject: Avoid slient success of ISO uploading
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Please fix the typos.
...
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Avoid slient success of ISO uploading
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Minor typo.
..
Michael Kublin has posted comments on this change.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
..
Patch Set 1: (1 inline comment)
File
b
Omer Frenkel has posted comments on this change.
Change subject: core: adding logging to Migration logic
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsb
Daniel Erez has posted comments on this change.
Change subject: webadmin: property sheet: drop-down (#827710)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5097
To unsubscribe, visit http:
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 2:
start the application in Gluster Only mode.
No need to change or navigate th
Yair Zaslavsky has abandoned this change.
Change subject: core: Fixing timeo to proper time units
..
Patch Set 2: Abandoned
UI will present the proper time units.
--
To view, visit http://gerrit.ovirt.org/5076
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing timeo to proper time units
..
Patch Set 2:
Doron - actually, this will be abandoned.
Einav will fix the UI to present "deciseconds".
--
To view,
Ori Liel has submitted this change and it was merged.
Change subject: rest: fix NicMappterTest build error
..
rest: fix NicMappterTest build error
Change-Id: I618c1242d75ebdfa07f378f62f1d77ee84c32fca
Signed-off-by: Shahar Haviv
Ori Liel has posted comments on this change.
Change subject: rest: fix NicMappterTest build error
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5103
To unsubscribe, visit http://
Shahar Havivi has posted comments on this change.
Change subject: rest: fix NicMappterTest build error
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5103
To unsubscribe, visit http://gerrit.ovirt.org/settin
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Filter search objects according to main model
availability
..
Patch Set 2:
Still cannot reproduce (?)
Tried these steps:
- application starts up in G
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Permission filtering for GetAllVmTemplates query.
(#783087)
..
core: Permission filtering for GetAllVmTemplates query. (#783087)
https://bugzilla.redhat
Shahar Havivi has uploaded a new change for review.
Change subject: rest: fix NicMappterTest build error
..
rest: fix NicMappterTest build error
Change-Id: I618c1242d75ebdfa07f378f62f1d77ee84c32fca
Signed-off-by: Shahar Havivi
-
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: removed tabs and trailing white spaces
..
reports: removed tabs and trailing white spaces
Change-Id: I20df74f3af6fbbe4a478ecef5402f9890d9c49e7
Sig
Yaniv Dary has posted comments on this change.
Change subject: reports: removed tabs and trailing white spaces
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5102
To unsubscribe,
1 - 100 of 235 matches
Mail list logo
