Rami Vaknin has posted comments on this change.

Change subject: engine: Alphanumeric sorting order for db query results (no bz)
......................................................................


Patch Set 1:

Eli, explicit index scan is not useful in small tables like rhevm uses, it even 
slows down the DML operations so I'm not sure it worth using it at all. 
Implicit index scan is not relevant here since in most cases you don't sort by 
the primary key.

I think that padding is bad idea, try to pad the following vm names: win2k, 
win2k3, win95, win2003, win2008.

In practice, I've tested the patch on env with more than 1000 data centers 
(which is the order of scaled objects' grid) and I couldn't *feel* any 
difference in comparison to that env without the patch.

Itamar, what do you mean by "local sorting in the UI", is it the "sortby" which 
can be used in webadmin's search box?

--
To view, visit http://gerrit.ovirt.org/5079
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice3ae8b9f897690e777dc53b659359e5cefcd292
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Rami Vaknin <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to