Maor Lipchuk has posted comments on this change. Change subject: core: Grayed-Out LUNs Support ......................................................................
Patch Set 16: (8 inline comments) .................................................... File backend/manager/dbscripts/storages_san_sp.sql Line 68: RETURN QUERY SELECT LUNs.* Please change the select to use * instead of Luns.* .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java Line 26: ArrayList<LUNs> returnValue = new ArrayList<LUNs>(); Suggestion: Use list interface instead of ArrayList .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java Line 88: */ I think you missed test annotation here .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java Line 125: if (diskAlias != other.diskAlias) diskAlias, storageId and StorageName are Objects, so you can't use simple equal like this != since it use comparison between memory instead object data. See productId equals for example, you can also use eclipse source to auto generate the equals method. Line 288: // A flag indicating whether the LUN device contains partitions Please use java doc comment, its better documantation .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java Line 10: setStorageType(storageType); Please check compatibility version out side the VDS command, and use isFiltered in the parameters instead. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java Line 240: public static final String includePartitioned = "includePartitioned"; Suggestion: Please add comment // Luns .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java Line 130: public Map<String, Object> getDeviceList(int storageType, Map options); Please add generics -- To view, visit http://gerrit.ovirt.org/4858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
