Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 19: Looks good to me, but someone else must approve
(4 inline comments)
Looks good, some inline comments, nothing major.
....................................................
File backend/manager/dbscripts/create_views.sql
Line 289: LEFT OUTER JOIN disk_lun_map ON luns.lun_id = disk_lun_map.lun_id
I think this last one can be an inner join, no?
....................................................
File backend/manager/dbscripts/storages_san_sp.sql
Line 67: BEGIN
I really dislike the indentation here, but considering it was here before this
patch, I'm not sure if you'd like to fix it here or not - up to you.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
Line 61: else {
I think the local existsInDb is a bit redundant, but it's a matter of taste
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java
Line 27:
Please explicitly set the default, for readability,
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
