Allon Mureinik has posted comments on this change.
Change subject: core: additional GetTimeZonesQuery
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I like the idea of mocking ConfigUtils, but th
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTimeZonesQuery
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Shireesh Anjal has posted comments on this change.
Change subject: engine: New query to fetch Gluster Volume by ID
..
Patch Set 3:
Gluster functionality will be available only in webadmin and REST api. It is
not concerned with
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] BaseImagesCommand
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main
Raksha Rao has uploaded a new change for review.
Change subject: webadmin: Support for Start Volume
..
webadmin: Support for Start Volume
Change-Id: Iabf7ca35f8a9868b6aa3d205c8e1e398e2d4b9e4
Note: Start Volume Option will be dis
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] Ovf
..
Patch Set 1: (1 inline comment)
Commit Message
Line 8:
Please reword the description -
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] Ovf
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3914
To unsubscribe, visit http://gerr
Oved Ourfali has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 1: (1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] CreateComputerAccountCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3911
To unsub
Allon Mureinik has posted comments on this change.
Change subject: engine-core: BaseConditionFieldAutoCompleter cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
...
Oved Ourfali has posted comments on this change.
Change subject: restapi: Remove spaces in realm specification
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3925
To unsubscribe, visit http
Allon Mureinik has posted comments on this change.
Change subject: engine-core: valueValidationFunction cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks good - see two minor inl
Oved Ourfali has submitted this change and it was merged.
Change subject: core: set required network by default
..
core: set required network by default
Change-Id: Ia19f717f55db59df2b353e9a1335a9d99ce241a7
---
M
backend/manage
Oved Ourfali has posted comments on this change.
Change subject: core: set required network by default
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3948
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: adding backup and restore scripts to dbscripts
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3
Allon Mureinik has posted comments on this change.
Change subject: engine: New query to fetch Gluster Volume by ID
..
Patch Set 3:
Basically looks good, but note that as is, this query can't be run from the
Power User Portal.
Roy Golan has posted comments on this change.
Change subject: core: set required network by default
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3948
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has uploaded a new change for review.
Change subject: core: set required network by default
..
core: set required network by default
Change-Id: Ia19f717f55db59df2b353e9a1335a9d99ce241a7
---
M
backend/manager/modules/c
Moti Asayag has uploaded a new change for review.
Change subject: core: VM Interfaces are omitted from templates (#808870)
..
core: VM Interfaces are omitted from templates (#808870)
The patch fixes a bugs in which VM Interfaces
Roy Golan has posted comments on this change.
Change subject: core: handle only required networks which are down
..
Patch Set 2:
rebase
--
To view, visit http://gerrit.ovirt.org/3706
To unsubscribe, visit http://gerrit.ovirt.o
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 5: No score
Entries in AppErrors.java and VdsmErrors.java (frontend project) missing.
Looks like my comment on patch
Alex Jia has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1: Looks good to me, but someone else must approve
The patch will enhance debugging capability between the SD
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 1: (1 inline comment)
Sharad - I agree with your approach.
Also see
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: Gluster REST api - Create Gluster Volume
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Yair Zaslavsky has posted comments on this change.
Change subject: engine: New query to fetch Gluster Volume by ID
..
Patch Set 3: (1 inline comment)
Please add a test for this query (I know not all our queries have tests, but
Michael Pasternak has posted comments on this change.
Change subject: restapi: Remove Generic Interfaces that interfere with RSDL
..
Patch Set 1: I would prefer that you didn't submit this
Ori,
before you read the rest of this
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Volume Start/Stop enable/disable
..
webadmin: Gluster Volume Start/Stop enable/disable
Volume Start button will be enabled only if the volume st
Juan Hernandez has posted comments on this change.
Change subject: sdk: Fix a minor typo: connection instead of connetcion
..
Patch Set 2: Verified
Doesn't break anything, as far as I can tell/test.
--
To view, visit http://ge
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1: Verified
(2 inline comments)
File src/ovirtsdk
29 matches
Mail list logo
