Allon Mureinik has posted comments on this change. Change subject: engine-core: BaseConditionFieldAutoCompleter cleanup ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleterTest.java Line 2: I'd statically import the members you use from Assert, but it's a matter of taste. -- To view, visit http://gerrit.ovirt.org/2817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61dd8fa9bac3b5391e4f233dbaf0aa7fcb6dbaa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches