Yair Zaslavsky has posted comments on this change. Change subject: engine: New query to fetch Gluster Volume by ID ......................................................................
Patch Set 3: (1 inline comment) Please add a test for this query (I know not all our queries have tests, but we're trying to fix this issue :) In addition, Adding Allon as reviewer. He might want to discuss with you about usability of this query via user portal. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeByIdQuery.java Line 18: getQueryReturnValue().setReturnValue(DbFacade.getInstance() please extract method : protected GlusterVolumeInfoDao getGlusterVolumeInfoDao() The reason for doing this, is so you will be able to write a test using mockito (and not pockermock / static mocking) for this query. -- To view, visit http://gerrit.ovirt.org/3922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I273d0035c523d95804f00df722c692656d4707e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
