Yair Zaslavsky has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
......................................................................
Patch Set 1: (1 inline comment)
Sharad - I agree with your approach.
Also see my inline comment.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 126: System.out.println("Cannot get guid for LDAP - " +
currentLdapServer
I wonder if this error is specific enough. What about adding more detailed
information which will explain that although communication with the LDAP server
did succeed, the returned results did not contain an attribute holding the guid.
--
To view, visit http://gerrit.ovirt.org/3935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b07cfaa2753bdbcf760245997efee8611e596b4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
