Michael Kublin has posted comments on this change.
Change subject: core: First refactor - remove vm_images_view
..
Patch Set 1: I would prefer that you didn't submit this
Bad performance
--
To view, visit http://gerrit.ovirt.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetVdsCertificateSubjectByVdsIdQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3610
To unsubscribe, visi
Mike Kolesnik has posted comments on this change.
Change subject: core: Test GetTemplateInterfacesByTemplateIdQuery
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3582
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core, rest: Refactor 2 - Disk Image
..
Patch Set 2: I would prefer that you didn't submit this
(9 inline comments)
Because of luck of response for previous com
Mike Kolesnik has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 3: (1 inline comment)
Basically +2, just 1 minor comment
.
Mike Kolesnik has posted comments on this change.
Change subject: core: permission filtering for GetVdsInterfacesByVdsId
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2964
To unsubscribe,
Roy Golan has submitted this change and it was merged.
Change subject: core: support hot plug when adding a VM nic
..
core: support hot plug when adding a VM nic
when a VM is up the newly added nic will be hot plugged to it.
C
Roy Golan has posted comments on this change.
Change subject: core: support hot plug when adding a VM nic
..
Patch Set 8: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3457
To unsubscrib
Roy Golan has submitted this change and it was merged.
Change subject: core: DAL add active to vm_interface_view
..
core: DAL add active to vm_interface_view
Change-Id: I1436a4ec75b627de7700bd95207bfb5df672b173
---
M backend/ma
Roy Golan has posted comments on this change.
Change subject: core: DAL add active to vm_interface_view
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3456
To unsubscribe, visit h
Roy Golan has submitted this change and it was merged.
Change subject: core: unifiy hostplug cando checks under Vmcommand
..
core: unifiy hostplug cando checks under Vmcommand
Change-Id: Ia033aaa550588016399c33929294d2da550174a
Roy Golan has posted comments on this change.
Change subject: core: unifiy hostplug cando checks under Vmcommand
..
Patch Set 8: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3455
To uns
Roy Golan has submitted this change and it was merged.
Change subject: core: extract mappers for VmNetworkDao
..
core: extract mappers for VmNetworkDao
Change-Id: I060ac8bcd295f81d34470a48d881f1e3fb028d16
---
M
backend/manager
Roy Golan has posted comments on this change.
Change subject: core: extract mappers for VmNetworkDao
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3454
To unsubscribe, visit http
Roy Golan has submitted this change and it was merged.
Change subject: core: add hotplug support when adding VM nic
..
core: add hotplug support when adding VM nic
Change-Id: I64adbc2ab0f30a3ba532ddd8cc5986528b4b079b
---
M
bac
Roy Golan has posted comments on this change.
Change subject: core: add hotplug support when adding VM nic
..
Patch Set 8: Verified; Looks good to me, approved
(1 inline comment)
already acked - minor fixes approved
.
Roy Golan has submitted this change and it was merged.
Change subject: engine-core: RunVm - filter out unplugged nics
..
engine-core: RunVm - filter out unplugged nics
Change-Id: Ie1e88b50646951e2a5ddbe0044cc29678659cfd0
---
M
Roy Golan has posted comments on this change.
Change subject: engine-core: RunVm - filter out unplugged nics
..
Patch Set 9: Verified; Looks good to me, approved
already acked - minor fixes approved
--
To view, visit http://ge
Daniel Erez has posted comments on this change.
Change subject: webadmin: create gluster volume implementation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3504
To un
Daniel Erez has posted comments on this change.
Change subject: core: Introducing new App errors for Posix-fs validation
..
Patch Set 9:
AppErrors.java also needs to be modified (i.e. adding error messages
definitions)
--
To
Roy Golan has submitted this change and it was merged.
Change subject: core: share common plug/unplug messages and checks
..
core: share common plug/unplug messages and checks
Change-Id: I2430b965b8456e1a59fbb46b04fd6f59ef27a89
Roy Golan has posted comments on this change.
Change subject: core: share common plug/unplug messages and checks
..
Patch Set 7: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3452
To uns
Roy Golan has submitted this change and it was merged.
Change subject: core: clean linq and convertion leftovers
..
core: clean linq and convertion leftovers
Change-Id: Ib08d030212f3d9bd64cd70bc81290cc5625f09fb
---
M
backend/m
Roy Golan has posted comments on this change.
Change subject: core: clean linq and convertion leftovers
..
Patch Set 7: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3451
To unsubscribe,
Roy Golan has submitted this change and it was merged.
Change subject: core: clean XML annotations
..
core: clean XML annotations
Change-Id: I59c8482f6107c962f0bfb5b1d12c1ec77bab0d4c
---
M
backend/manager/modules/common/src/ma
Roy Golan has posted comments on this change.
Change subject: core: clean XML annotations
..
Patch Set 7: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3450
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: First refactor - remove vm_images_view
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscr
Oved Ourfali has posted comments on this change.
Change subject: wip - don't submit: rest session-management
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: PosixFS fields added to translation to XML RPC
..
core: PosixFS fields added to translation to XML RPC
Adding mountOptions and VfsType to the tra
Yair Zaslavsky has posted comments on this change.
Change subject: core: PosixFS fields added to translation to XML RPC
..
Patch Set 9: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://gerri
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding PosixFS storage helper
..
core: Adding PosixFS storage helper
Change-Id: Ibff515ccf588315e28b1424438dda0b526978ecc
---
A
backend/manager/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding PosixFS storage helper
..
Patch Set 13: Verified; Looks good to me, approved
Acked-BY: Omer Frenkel
--
To view, visit http://gerrit.ovirt.org/3432
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding posix support to connections to DB and DAL
..
core: Adding posix support to connections to DB and DAL
Change-Id: Ie8626cd7579004ac1fb65f87
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding posix support to connections to DB and DAL
..
Patch Set 9: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://ge
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding PosixStorageEnabled config value
..
core: Adding PosixStorageEnabled config value
Adding PosixStorageEnabled config value in order
to dete
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding PosixStorageEnabled config value
..
Patch Set 7: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing new App errors for Posix-fs validation
..
Patch Set 9:
Omer and Derez - please review, added more messages
--
To view, visit http://gerrit.ov
Daniel Erez has posted comments on this change.
Change subject: webadmin: TextAreaLabel for multiline content
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3605
To unsubscribe, visit http:
Daniel Erez has posted comments on this change.
Change subject: core: fixing spelling error in luns table column name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/356
Daniel Erez has posted comments on this change.
Change subject: core: Add queries for fetching Permitted Storage Domains
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Daniel Erez has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http:/
Maor Lipchuk has posted comments on this change.
Change subject: core, rest: Refactor 2 - Disk Image
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/create
Maor Lipchuk has posted comments on this change.
Change subject: core: First refactor - remove vm_images_view
..
Patch Set 1: (3 inline comments)
File backend/manager/dbscrip
Kanagaraj M has posted comments on this change.
Change subject: webadmin: create gluster volume implementation
..
Patch Set 2: Verified
Updated the patch with Vojtech's changes to open a dialog within a dialog.
--
To view, vis
Michael Kublin has posted comments on this change.
Change subject: core, rest: Refactor 2 - Disk Image
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/crea
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin,userportal: Allow dialogs to open dialogs
..
webadmin,userportal: Allow dialogs to open dialogs
This patch refactors existing UiCommon dialog s
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Allow dialogs to open dialogs
..
Patch Set 2: Verified; Looks good to me, approved
checked with MK, nice work Vojtech & thanks!
--
To view,
Kanagaraj M has posted comments on this change.
Change subject: webadmin,userportal: Allow dialogs to open dialogs
..
Patch Set 1: Verified
Checked and it works with my code.
--
To view, visit http://gerrit.ovirt.org/3619
To u
Michael Kublin has posted comments on this change.
Change subject: core: First refactor - remove vm_images_view
..
Patch Set 1: (3 inline comments)
File backend/manager/dbscr
Maor Lipchuk has uploaded a new change for review.
Change subject: core, rest: Refactor 2 - Disk Image
..
core, rest: Refactor 2 - Disk Image
1. Remove the imageContainerId from the diskImage
2. Remove vm_images_view completely:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Adding shared field to disk
..
core: Adding shared field to disk
Adding is shared field to disk.
The isShared should indicate whether the disk can be share
Maor Lipchuk has uploaded a new change for review.
Change subject: core: First refactor - remove vm_images_view
..
core: First refactor - remove vm_images_view
Use storage_domain_image_view instead of vm_images_view, since the t
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix log for disk alias
..
Patch Set 2: Looks good to me, approved
Ack by ofrenkel
--
To view, visit http://gerrit.ovirt.org/3620
To unsubscribe, visit http
Michael Kublin has submitted this change and it was merged.
Change subject: core : Clean up for MoveVm because of introducing multiple
storage domains
..
core : Clean up for MoveVm because of introducing multiple storage domain
Michael Kublin has posted comments on this change.
Change subject: core : Clean up for MoveVm because of introducing multiple
storage domains
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http
Michael Kublin has posted comments on this change.
Change subject: core: Retrieve job with steps by correlation ID
..
Patch Set 2: (1 inline comment)
Bad performance, read comment
..
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: task mng - configure local storage
..
webadmin: task mng - configure local storage
When running configure local storage, give all the action the same
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Tasks Tree new Impl
..
webadmin: Tasks Tree new Impl
Extends the new abstract tree, that was introduced later.
Change-Id: I6c69c1f81999a4abdf9e5c5556
Juan Hernandez has posted comments on this change.
Change subject: wip - don't submit: rest session-management
..
Patch Set 9: (3 inline comments)
See my comments inline. I am mostly concerned about the use of the value of the
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Create Gluster Volume [fixed]
..
engine: Create Gluster Volume [fixed]
Fixed bugs in Create Gluster Volume functionality.
- Added more validati
Gilad Chaplik has posted comments on this change.
Change subject: engine: Create Gluster Volume [fixed]
..
Patch Set 4: Verified; Looks good to me, approved
merging for Omer & Shireesh
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introduction and usage of StoragePoolValidator
..
Patch Set 8:
Omer - I added some validation to UpdateStoragePool.
Please review.
--
To view, visit http
Shireesh Anjal has posted comments on this change.
Change subject: engine: Create Gluster Volume [fixed]
..
Patch Set 4: Verified
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/3494
To unsubscribe, visit http:
Maor Lipchuk has posted comments on this change.
Change subject: engine: SearchBackend DiskImageCrossRefAutoCompleter
..
Patch Set 5: (1 inline comment)
File backend/manager/
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Introducing AddPOSIXStorageDomainCommand
..
core: Introducing AddPOSIXStorageDomainCommand
Adding AddPoxisStorageDomainCommand.
The command is limited to
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Introducing gluster_volume_transport_types table
..
engine: Introducing gluster_volume_transport_types table
Since a Gluster Volume can have mul
Gilad Chaplik has posted comments on this change.
Change subject: engine: Introducing gluster_volume_transport_types table
..
Patch Set 4: Verified; Looks good to me, approved
ack for the small webadmin change.
Merged.
--
To
Shireesh Anjal has posted comments on this change.
Change subject: engine: Introducing gluster_volume_transport_types table
..
Patch Set 4: Verified
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/3493
To unsub
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Removal of diskInfoList from AddVmFromSnapshot
..
core: Removal of diskInfoList from AddVmFromSnapshot
Change-Id: I6ed51bc8225e3397f625526b124a97
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removal of diskInfoList from AddVmFromSnapshot
..
Patch Set 2: Verified; Looks good to me, approved
Acked-By: Michael Kublin
--
To view, visit http://ger
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Allow dialogs to open dialogs
..
Patch Set 1:
Kanagaraj M, please apply and see if this patch works out for you.
I will do the setup-networ
Gilad Chaplik has posted comments on this change.
Change subject: engine: Gluster Volume Option Info
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
derez, as the gluster webadmin maintainer please rev
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: gluster volume option add/edit implementation
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: create gluster volume implementation
..
Patch Set 1: No score
don't forget you need to add the changes to open the add brick popup using the
infrastru
Maor Lipchuk has abandoned this change.
Change subject: core: add shared disk
..
Patch Set 1: Abandoned
Patch was messed up, will send another patch instead.
--
To view, visit http://gerrit.ovirt.org/3623
To unsubscribe, visit
Maor Lipchuk has abandoned this change.
Change subject: core, rest: Refactor 2 - Disk Image
..
Patch Set 1: Abandoned
Patch was messed up, will send another patch instead.
--
To view, visit http://gerrit.ovirt.org/3622
To unsu
Maor Lipchuk has abandoned this change.
Change subject: core: First refactor - remove vm_images_view
..
Patch Set 1: Abandoned
Patch was messed up, will send another patch instead.
--
To view, visit http://gerrit.ovirt.org/362
Daniel Erez has posted comments on this change.
Change subject: webadmin: Add Disks actions to new role dialog
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3397
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: System Tree - Disks handling
..
webadmin: System Tree - Disks handling
Display 'Disks' main-tab on the following tree-items:
System, Datacenter
Daniel Erez has submitted this change and it was merged.
Change subject: engine: SearchBackend DiskImageCrossRefAutoCompleter
..
engine: SearchBackend DiskImageCrossRefAutoCompleter
Added DiskImageCrossRefAutoCompleter to Searc
Daniel Erez has posted comments on this change.
Change subject: engine: SearchBackend DiskImageCrossRefAutoCompleter
..
Patch Set 5: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3550
T
Daniel Erez has posted comments on this change.
Change subject: webadmin: System Tree - Disks handling
..
Patch Set 5: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3551
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: core: Fix log for disk alias
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3620
To unsubscribe, visit http://gerrit.ovirt.o
Omer Frenkel has posted comments on this change.
Change subject: core: Check permissions on disk when editing disk
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3403
T
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Volume Option Info
..
Patch Set 1: Looks good to me, but someone else must approve
looks ok, need at least +1 from frontend as well
--
To view, v
Maor Lipchuk has uploaded a new change for review.
Change subject: core: add shared disk
..
core: add shared disk
Change-Id: I04d1a33205624c4a5f61d2a5e5867daaac2d1f67
---
R backend/manager/dbscripts/upgrade/03_01_0860_add_shared
Maor Lipchuk has uploaded a new change for review.
Change subject: core, rest: Refactor 2 - Disk Image
..
core, rest: Refactor 2 - Disk Image
1. Remove the imageContainerId from the diskImage
2. Remove vm_images_view completely:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: First refactor - remove vm_images_view
..
core: First refactor - remove vm_images_view
Use storage_domain_image_view instead of vm_images_view, since the t
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix log for disk alias
..
core: Fix log for disk alias
Use correct formatting for string parameters.
Change-Id: I0598bcd8179813de021b43772461375c9abe1dde
Omer Frenkel has posted comments on this change.
Change subject: engine: Create Gluster Volume [fixed]
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3494
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core: Check permissions on disk when editing disk
..
Patch Set 3:
Removed re-assignment of disk ID and fix unit test
--
To view, visit http://gerrit.ovirt.org/340
Moti Asayag has posted comments on this change.
Change subject: core: Check permissions on disk when attaching disk to VM
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/3402
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core: Check permissions on disk when removing a disk
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/3401
To unsubscribe, visit http://gerrit.ovi
Moti Asayag has posted comments on this change.
Change subject: core: Add DISK_OPERATOR role to user when creating disk
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/3400
To unsubscribe, visit http://gerrit.
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 2: (6 inline comments)
File
backend/manager/modul
Moti Asayag has posted comments on this change.
Change subject: core: Check permission on Storage Domain when adding disk
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/3399
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core: Allow adding the same permission again
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/3398
To unsubscribe, visit http://gerrit.ovirt.org/s
Moti Asayag has posted comments on this change.
Change subject: core,restapi: Add disk actions and predefined roles
..
Patch Set 3:
updated script names to prevent collisions and added the action group to
restapi so tests coul
Michael Kublin has posted comments on this change.
Change subject: core: Remove VMDAO.getById
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Michael Kublin has posted comments on this change.
Change subject: core: Remove VMDAO.getById
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/bll/src/main/j
1 - 100 of 263 matches
Mail list logo
