Michael Kublin has posted comments on this change. Change subject: core, rest: Refactor 2 - Disk Image ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 26: -- TODO: Change code to treat disks values directly instead of through this view. why capital letter? You don't need distinct , remove it .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java Line 58: ImagesHandler.setDiskAlias(newDiskImage.getDisk(), getVm()); Such code is bug -- To view, visit http://gerrit.ovirt.org/3634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia600ea9fea52717065da3c9a309ad364a27eb88f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
