Maor Lipchuk has posted comments on this change.

Change subject: engine: SearchBackend DiskImageCrossRefAutoCompleter
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File backend/manager/dbscripts/create_views.sql
Line 118: SELECT vm_images_view.*,  images_storage_domain_view.storage_id as 
storage_domain_id
I think image_storage_domain_map will be enough here instead 
images_storage_domain_view, since you only need the storage_domain_id here?

--
To view, visit http://gerrit.ovirt.org/3550
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd35db01d7737e71fbd5348c3d119fced549124
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to