Michael Kublin has posted comments on this change. Change subject: core: First refactor - remove vm_images_view ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/dbscripts/images_sp.sql Line 113: RETURN QUERY SELECT images_storage_domain_view.* why u need a JOIN on disk_image_dynamic, it is done at view also? Line 168: WHERE v_storage_domain_id in (SELECT id FROM fnsplitteruuid(images_storage_domain_view.storage_id)); Just simple question : u think it will be efficient such code? Line 193: RETURN QUERY SELECT images_storage_domain_view.* same here? -- To view, visit http://gerrit.ovirt.org/3633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b08e6e55de9bc49ad13194b08f2c01b74c1578 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
