[Engine-patches] Change in ovirt-engine[master]: webadmin: Add cancel migration

2012-03-03 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: webadmin: Add cancel migration .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2491 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core : Support for multiple storage domains at AddVmFromTemp...

2012-03-03 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Support for multiple storage domains at AddVmFromTemplateCommand .. Patch Set 1: (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: Added can do action message for illegal restore

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Added can do action message for illegal restore .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2336 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup RestoreAllSnapshotsCommand async task

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Cleanup RestoreAllSnapshotsCommand async task .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2313 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Fixes in SnapshotsManager

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Fixes in SnapshotsManager .. Patch Set 5: (1 inline comment) basically +2 just make sure the comment and the image status are the same

[Engine-patches] Change in ovirt-engine[master]: core: User Configuration Values

2012-03-03 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: User Configuration Values .. Patch Set 3: (5 inline comments) Agree with all ecohen's comments - will upload a fixup. ...

[Engine-patches] Change in ovirt-engine[master]: core: Add method to get images with no disks

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add method to get images with no disks .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2311 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Adding test for VdcQueryType

2012-03-03 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Adding test for VdcQueryType .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2438 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: Change images_storage_domain_view to left join disks

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Change images_storage_domain_view to left join disks .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2183 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: Introduce virt_service and gluster_service at cluster level

2012-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: Introduce virt_service and gluster_service at cluster level .. Patch Set 1: looks good, please add also dao tests for the new fields. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT - wip - core: adding service policy for gluste...

2012-03-03 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: DO NOT SUBMIT - wip - core: adding service policy for gluster integration .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIIT - wip - core: gluster bootstrap

2012-03-03 Thread barumuga
Bala.FA has posted comments on this change. Change subject: DO NOT SUBMIIT - wip - core: gluster bootstrap .. Patch Set 1: (1 inline comment) File backend/manager/conf/vds_in

[Engine-patches] Change in ovirt-engine[master]: Introduce virt_service and gluster_service at cluster level

2012-03-03 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: Introduce virt_service and gluster_service at cluster level .. Patch Set 1: Looks good to me, but someone else must approve Looks good to me. Doesn't change cur

[Engine-patches] Change in ovirt-engine[master]: Introduce virt_service and gluster_service at cluster level

2012-03-03 Thread sesubram
sesub...@redhat.com has uploaded a new change for review. Change subject: Introduce virt_service and gluster_service at cluster level .. Introduce virt_service and gluster_service at cluster level This commit introduces the abil

[Engine-patches] Change in ovirt-engine[master]: engine: Use quota id when adding a new template

2012-03-03 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Use quota id when adding a new template .. engine: Use quota id when adding a new template When adding new template the quota id that the template suppos

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-03 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Fix automatic default quota name. .. engine: Fix automatic default quota name. Changed the quota name resolving which calculate the new default quota nam

[Engine-patches] Change in ovirt-engine[master]: engine: Use default quota when update storage pool

2012-03-03 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Use default quota when update storage pool .. engine: Use default quota when update storage pool The following patch contains the following changes: 1. A

[Engine-patches] Change in ovirt-engine[master]: Add missign storage_format_type arg to Updatestorage_domain_...

2012-03-03 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Add missign storage_format_type arg to Updatestorage_domain_static .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: Run upgradeStoragePool on cluster compatibility change

2012-03-03 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Run upgradeStoragePool on cluster compatibility change .. Patch Set 5: I would prefer that you didn't submit this (2 inline comments) I may be wrong but it seems t

[Engine-patches] Change in ovirt-engine[master]: engine: Add query of get all quotas by user id

2012-03-03 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Add query of get all quotas by user id .. Patch Set 4: rebase -- To view, visit http://gerrit.ovirt.org/2435 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: engine: Add queries to VDC query type

2012-03-03 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Add queries to VDC query type .. Patch Set 5: Rebase + adding GetPermissionsToConsumeQuotaByQuotaId to VdcQueryType as gchaplik commented. answered comme

[Engine-patches] Change in ovirt-engine[master]: Use Shorthand methods in UpdateVdsGroupCommand

2012-03-03 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Use Shorthand methods in UpdateVdsGroupCommand .. Patch Set 1: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: squash

2012-03-03 Thread mlipchuk
Maor Lipchuk has abandoned this change. Change subject: squash .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/2528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-

[Engine-patches] Change in ovirt-engine[master]: squash

2012-03-03 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: squash .. squash Change-Id: I0fb9c1550f076f2168562525b641aa9580d75318 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/Vd

[Engine-patches] Change in ovirt-engine[master]: Try and fix condition in UpdateVdsGroupCommand

2012-03-03 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Try and fix condition in UpdateVdsGroupCommand .. Patch Set 1: Looks good to me, but someone else must approve Actually operator && precedence is higher than || so

[Engine-patches] Change in ovirt-engine[master]: engine: Add queries to VDC query type

2012-03-03 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Add queries to VDC query type .. Patch Set 3: What is the reason that you want to get distinct result here? If you want to present only users then maybe a

[Engine-patches] Change in ovirt-engine[master]: packaging: Remote DB support - DO NOT MERGE!!!!.

2012-03-03 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: packaging: Remote DB support - DO NOT MERGE. .. Patch Set 9: I would prefer that you didn't submit this (13 inline comments)