Michael Kublin has posted comments on this change. Change subject: core : Support for multiple storage domains at AddVmFromTemplateCommand ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java Line 93: ArrayList<String> messages = new ArrayList<String>(); The variable is not used anywhere, it is value is not important to me. I am going through a lot of domains in order to find a correct ones. So, when I will use an array outside a loop it can grew up, that's why I will not declare a variable outside a loop -- To view, visit http://gerrit.ovirt.org/2486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ecc6d97420d8c8b84c54e6b9d6a7a2b0bad3d09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
