Barak Azulay has posted comments on this change. Change subject: packaging: Remote DB support - DO NOT MERGE!!!!. ......................................................................
Patch Set 9: I would prefer that you didn't submit this (13 inline comments) .................................................... File backend/manager/dbscripts/engine-db-install.sh Line 66: The above is not real command line parameter handling .................................................... File packaging/fedora/setup/common_utils.py Line 511: def getAdminUser(): bad function name Line 521: def getHostName(): bad function name Line 532: def getPort(): bad function name Line 559: whitespaces Line 560: return False The above function is questionable, It is not clear to me how the above will function when more than 1 db is configured. Line 701: return False I'm not sure the assumption of localhost or 127.0.0.1 is good enough to conclude local db, one can use the real host name or the real external IP. This will draw too many usability issues. .................................................... File packaging/fedora/setup/engine-cleanup.py Line 244: whitespaces Line 386: In case the above params are for the DB server than the names should be changed accordingly .................................................... File packaging/fedora/setup/engine-setup.py Line 1131: def getAdminUser(): bad function name Line 1141: def getHostName(): bad function name Line 1151: def getPort(): bad function name .................................................... File packaging/fedora/setup/engine_validators.py Line 126: ?? -- To view, visit http://gerrit.ovirt.org/2245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab66d6f8ffe33f9674e79753df7541c212012190 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
