sesub...@redhat.com has uploaded a new change for review. Change subject: Introduce virt_service and gluster_service at cluster level ......................................................................
Introduce virt_service and gluster_service at cluster level This commit introduces the ability to identify whether a cluster exposes virt / gluster services, by adding two boolean columns to vds_groups table. It also includes some refactoring of VdsGroupDAODbFacadeImpl class to remove duplicate code as follows: - Moved duplicate code from save and update into a common function getVdsGroupParamSource - Removed 8 occurances of exact same code for creating the VDSGroup row mapper and introduced a final static row mapper that is initialized only once. Change-Id: I75e63378c68458ec4230c3cb904e0ed2ac28a483 --- A backend/manager/dbscripts/upgrade/03_01_0560_add_service_columns_to_vds_groups.sql M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java 4 files changed, 117 insertions(+), 233 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/2506/1 -- To view, visit http://gerrit.ovirt.org/2506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75e63378c68458ec4230c3cb904e0ed2ac28a483 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: sesub...@redhat.com _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches