[Engine-patches] Change in ovirt-engine[master]: engine-core: add validations on VdsNetworkInterface

2012-01-19 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine-core: add validations on VdsNetworkInterface .. Patch Set 2: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: engine: bad performance in storage_domains.getQueryableId() ...

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: bad performance in storage_domains.getQueryableId() (#769615) .. Patch Set 5: (1 inline comment) F

[Engine-patches] Change in ovirt-engine[master]: engine : Added option to call some methods of lock util over...

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Added option to call some methods of lock util over JMX .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Handlig boot order in CreateVdsCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handlig boot order in CreateVdsCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1171 To u

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddDiskToVmCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in AddDiskToVmCommand .. -- To view, visit http://gerrit.ovirt.org/1170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Mes

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddDiskToVmCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in AddDiskToVmCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1170 To uns

[Engine-patches] Change in ovirt-engine[master]: core: handle changes in RemoveVmInterfaceCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: handle changes in RemoveVmInterfaceCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1169

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in RemoveDiskFromVmCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in RemoveDiskFromVmCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1168 T

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddVmInterfaceCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in AddVmInterfaceCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1167 To

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddVmCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in AddVmCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1166 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core : modify UpdateVmCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : modify UpdateVmCommand .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1165 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core : Adding utility class for VmDevice - VmDeviceUtils

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Adding utility class for VmDevice - VmDeviceUtils .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core : adding common utilities for VmDevice - VmDeviceCommon...

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils .. Patch Set 1: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: core: porting old boot order values to new vm_device

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: porting old boot order values to new vm_device .. Patch Set 1: (2 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOTest

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAOTest .. Patch Set 1: (2 inline comments) File backend/manager/modules/dal/src/main

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDEviceDAO to engine-daos.properties

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDEviceDAO to engine-daos.properties .. Patch Set 1: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOHibernateImpl

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAOHibernateImpl .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal/

[Engine-patches] Change in ovirt-engine[master]: core: Add VmDeviceDAODbFacadeImpl

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add VmDeviceDAODbFacadeImpl .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal/src/

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAO interface

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAO interface .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1157 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: Adding VM Device BE

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VM Device BE .. Patch Set 1: (2 inline comments) File backend/manager/modules/common/src/main

[Engine-patches] Change in ovirt-engine[master]: core: Adding CRUD stored procedures for vm_device

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding CRUD stored procedures for vm_device .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1155

[Engine-patches] Change in ovirt-engine[master]: core: Adding vm_device table

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding vm_device table .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1154 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Adding hash column to Views/SPs and DAL

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding hash column to Views/SPs and DAL .. Patch Set 1: (4 inline comments) File backend/manager/dbsc

[Engine-patches] Change in ovirt-engine[master]: core: adding hash column to vm_dynamic

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: adding hash column to vm_dynamic .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/u

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand .. Patch Set 1: (4 inline comments) File backend/manager/modules/vd

[Engine-patches] Change in ovirt-engine[master]: webadmin: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1131 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: userportal: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1132 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: userportal: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1132 T

[Engine-patches] Change in ovirt-engine[master]: webadmin: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1131 To

[Engine-patches] Change in ovirt-engine[master]: engine : Added option to call some methods of lock util over...

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine : Added option to call some methods of lock util over JMX .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: backend: Remove activeImage from Disk for now

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Remove activeImage from Disk for now .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/875 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: backend: Change update of Disk to code

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Change update of Disk to code .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/874 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: backend: Added saving the disk to flows

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Added saving the disk to flows .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/686 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: backend: Change removal of Disk to code

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Change removal of Disk to code .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/687 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: test for params serialization

2012-01-19 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: test for params serialization .. core: test for params serialization This is required for testing JSON params serialization (they are being serialized i

[Engine-patches] Change in ovirt-engine[master]: core: Remove vm_template & vm_template_image_map

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove vm_template & vm_template_image_map .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1172 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Remove vm_template & vm_template_image_map

2012-01-19 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Remove vm_template & vm_template_image_map .. core: Remove vm_template & vm_template_image_map These tables are not used anymore, since they have been mer

[Engine-patches] Change in ovirt-engine[master]: history: updated disks config dwh view.

2012-01-19 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: history: updated disks config dwh view. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1148 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: history: updated disks config dwh view.

2012-01-19 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: history: updated disks config dwh view. .. history: updated disks config dwh view. getting some of the image information from the new disks table. Chan

[Engine-patches] Change in ovirt-engine[master]: backend: Change DiskImage to contain Disk

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Change DiskImage to contain Disk .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/873 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine-core: Adding parent command ID to some command creati...

2012-01-19 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: engine-core: Adding parent command ID to some command creations .. Patch Set 1: Abandoned Not needed. It was prepration I thought we would need for Task Manager in 3.1

[Engine-patches] Change in ovirt-engine[master]: core: Adding vm_device table

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding vm_device table .. core: Adding vm_device table Adding the vm_device table to the database. The vm_device table stores both managed and unmanaged devi

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in RemoveDiskFromVmCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Handle changes in RemoveDiskFromVmCommand .. core: Handle changes in RemoveDiskFromVmCommand Handle deletion of VM disk and reflect it to the vm_device table

[Engine-patches] Change in ovirt-engine[master]: core: porting old boot order values to new vm_device

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: porting old boot order values to new vm_device .. core: porting old boot order values to new vm_device upgrading existing data in order to fill vm_device tab

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddVmInterfaceCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Handle changes in AddVmInterfaceCommand .. core: Handle changes in AddVmInterfaceCommand handle changes when a new vm interface is added to a VM and reflect

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Refactoring the CreateVDSCommand .. core: Refactoring the CreateVDSCommand Refactoring the CreateVDSCommand as a preparation for the Stable Devide Addresses

[Engine-patches] Change in ovirt-engine[master]: engine-core: unused private methods

2012-01-19 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine-core: unused private methods .. Patch Set 2: (2 inline comments) File backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: core : Adding utility class for VmDevice - VmDeviceUtils

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core : Adding utility class for VmDevice - VmDeviceUtils .. core : Adding utility class for VmDevice - VmDeviceUtils this utlity class managed all data update as r

[Engine-patches] Change in ovirt-engine[master]: core : adding common utilities for VmDevice - VmDeviceCommon...

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils .. core : adding common utilities for VmDevice - VmDeviceCommonUtils Adding common util class fo

[Engine-patches] Change in ovirt-engine[master]: core: handle changes in RemoveVmInterfaceCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: handle changes in RemoveVmInterfaceCommand .. core: handle changes in RemoveVmInterfaceCommand handle removing of vm interface and reflect changes to vm_devi

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddDiskToVmCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Handle changes in AddDiskToVmCommand .. core: Handle changes in AddDiskToVmCommand Handle addition of a disk to VM and reflect changes to vm_device table. C

[Engine-patches] Change in ovirt-engine[master]: core: Handlig boot order in CreateVdsCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Handlig boot order in CreateVdsCommand .. core: Handlig boot order in CreateVdsCommand In case of a simple run boot sequence string is computed from info in

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddVmCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Handle changes in AddVmCommand .. core: Handle changes in AddVmCommand Handle changes when a new VM is added to the system and reflect those changes to vm_d

[Engine-patches] Change in ovirt-engine[master]: core : modify UpdateVmCommand

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core : modify UpdateVmCommand .. core : modify UpdateVmCommand Handle changes of CDROM (iso_path) and number of monitors and reflect them to vm_device table Chan

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAO interface

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding VmDeviceDAO interface .. core: Adding VmDeviceDAO interface Adding VmDeviceDAO interface Change-Id: I427f02e56c259377ee1dce59d43cf907d2aa056e --- A

[Engine-patches] Change in ovirt-engine[master]: core: Adding VM Device BE

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding VM Device BE .. core: Adding VM Device BE Adding the VmDevice BE Change-Id: Iac51cde71d23d3b6e4c3405b34ae2a91dfa8fdaa --- A backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: Add VmDeviceDAODbFacadeImpl

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Add VmDeviceDAODbFacadeImpl .. core: Add VmDeviceDAODbFacadeImpl Adding jdbc DAO implementation for VmDeviceDAO Change-Id: Ia12ac2bc06be1a906247eda5c2eef9a4

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOHibernateImpl

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding VmDeviceDAOHibernateImpl .. core: Adding VmDeviceDAOHibernateImpl Adding stub for VmDeviceDAO Hibernate implementation Change-Id: I7163e5e9a5cbee2950

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDEviceDAO to engine-daos.properties

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding VmDEviceDAO to engine-daos.properties .. core: Adding VmDEviceDAO to engine-daos.properties Adding VmDeviceDAO derived classes declarations to engine-

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOTest

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding VmDeviceDAOTest .. core: Adding VmDeviceDAOTest Adding test data and tests for VmDevice BE Change-Id: I617e613abbb285f113c45f9122d6eb260ef29fc7 --- M

[Engine-patches] Change in ovirt-engine[master]: core: Adding hash column to Views/SPs and DAL

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding hash column to Views/SPs and DAL .. core: Adding hash column to Views/SPs and DAL Adding the new added hash property to relevant SP/Views Updating rel

[Engine-patches] Change in ovirt-engine[master]: core: Adding CRUD stored procedures for vm_device

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding CRUD stored procedures for vm_device .. core: Adding CRUD stored procedures for vm_device Adding CRUD SP for vm_device handling Change-Id: Idc23360fd

[Engine-patches] Change in ovirt-engine[master]: core: adding hash column to vm_dynamic

2012-01-19 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: adding hash column to vm_dynamic .. core: adding hash column to vm_dynamic Adding hash column to vm_dynamic This column is used to indicate that there was a

[Engine-patches] Change in ovirt-engine-cli[master]: cli: clear option doesnt work #782705

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: clear option doesnt work #782705 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1149 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine-cli[master]: cli: clear option doesnt work #782705

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: cli: clear option doesnt work #782705 .. cli: clear option doesnt work #782705 Change-Id: I15d2741e9200610cfa1f6f76ffb426449e602ae1 --- M src/cli/pl

[Engine-patches] Change in ovirt-engine-cli[master]: cli: clear option doesnt work #782705

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: clear option doesnt work #782705 .. cli: clear option doesnt work #782705 Change-Id: I15d2741e9200610cfa1f6f76ffb426449e602ae1 --- M src/cli/platform/p

[Engine-patches] Change in ovirt-engine[master]: engine-core: minor copypaste cleanup

2012-01-19 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine-core: minor copypaste cleanup .. Patch Set 2: (4 inline comments) File backend/manager/modules/commo

[Engine-patches] Change in ovirt-engine[master]: engine : Code clean up

2012-01-19 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine : Code clean up .. Patch Set 1: (3 inline comments) File backend/manager/modules/bll/src/main/java/

[Engine-patches] Change in ovirt-engine[master]: history: updated disks config dwh view.

2012-01-19 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: history: updated disks config dwh view. .. history: updated disks config dwh view. getting some of the image information from the new disks table. Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: engine : Code clean up

2012-01-19 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine : Code clean up .. Patch Set 1: No score; No score fired +2 too early... -- To view, visit http://gerrit.ovirt.org/1138 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine : Code clean up

2012-01-19 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine : Code clean up .. Patch Set 1: Verified; Looks good to me, approved (3 inline comments) File backend

[Engine-patches] Change in ovirt-engine-cli[master]: cli: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: v1.2 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1147 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine-cli[master]: cli: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: cli: v1.2 .. cli: v1.2 Change-Id: I58dbd7e90bdb75b8a8b9258376b58fa335a3237b --- M Makefile M ovirt-engine-cli.spec.in 2 files changed, 8 insertions(

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: v1.2 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1145 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: v1.2 .. sdk: v1.2 Change-Id: I96e310c3c3b95c0982029066b731215646c9fd00 --- M Makefile M ovirt-engine-sdk.spec.in 2 files changed, 6 insertions(

[Engine-patches] Change in ovirt-engine-cli[master]: cli: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: v1.2 .. cli: v1.2 Change-Id: I58dbd7e90bdb75b8a8b9258376b58fa335a3237b --- M Makefile M ovirt-engine-cli.spec.in 2 files changed, 8 insertions(+), 2 de

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: v1.2

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: v1.2 .. sdk: v1.2 Change-Id: I96e310c3c3b95c0982029066b731215646c9fd00 --- M Makefile M ovirt-engine-sdk.spec.in 2 files changed, 6 insertions(+), 1 de

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add new cluster #782707

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: unable to add new cluster #782707 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1143 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add new cluster #782707

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: cli: unable to add new cluster #782707 .. cli: unable to add new cluster #782707 https://bugzilla.redhat.com/show_bug.cgi?id=782707 Change-Id: Ie1f

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add new cluster #782707

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: unable to add new cluster #782707 .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/1143 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: extention for #782707

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: extention for #782707 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1144 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: extention for #782707

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: extention for #782707 .. sdk: extention for #782707 Change-Id: I2c6d66183edf5573a1565a6e416a9ac3589738e4 --- M src/ovirtsdk/utils/parsehelper.p

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: extention for #782707

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: extention for #782707 .. sdk: extention for #782707 Change-Id: I2c6d66183edf5573a1565a6e416a9ac3589738e4 --- M src/ovirtsdk/utils/parsehelper.py 1 file

[Engine-patches] Change in ovirt-engine[master]: backend: Remove activeImage from Disk for now

2012-01-19 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Remove activeImage from Disk for now .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/875 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-guest-agent[master]: Don't remove ovirt-guest-agent/ovirt-guest-agent on 'make cl...

2012-01-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Don't remove ovirt-guest-agent/ovirt-guest-agent on 'make clean' .. Don't remove ovirt-guest-agent/ovirt-guest-agent on 'make clean' Change-Id: I38aa4da6aebf76f2fe769

[Engine-patches] Change in ovirt-guest-agent[master]: Add the prefix 'with' to the configure option '--gdm-src-dir...

2012-01-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Add the prefix 'with' to the configure option '--gdm-src-dir' in the output of `configure --help` .. Add the prefix 'with' to the configure option '--gdm-src-dir' in

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add new cluster #782707

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: unable to add new cluster #782707 .. cli: unable to add new cluster #782707 https://bugzilla.redhat.com/show_bug.cgi?id=782707 Change-Id: Ie1fdee2edd0

[Engine-patches] Change in ovirt-engine[engine_3.0]: allow ovirt-node to be registered

2012-01-19 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: allow ovirt-node to be registered .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1118 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[engine_3.0]: allow ovirt-node to be registered

2012-01-19 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: allow ovirt-node to be registered .. allow ovirt-node to be registered Change-Id: I18fd386a8ab12723d126528a891e5df073a782cf (cherry picked from commit 8

[Engine-patches] Change in ovirt-engine[master]: rest-api: exposing setupnetworks action under /api/hosts/{i...

2012-01-19 Thread oliel
ol...@redhat.com has posted comments on this change. Change subject: rest-api: exposing setupnetworks action under /api/hosts/{id}/nics .. Patch Set 2: (1 inline comment) I have a comment about yaml, see inline. The rest lo

[Engine-patches] Change in ovirt-engine[master]: webadmin: Everyone should be hidden in system (#782741)

2012-01-19 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Everyone should be hidden in system (#782741) .. webadmin: Everyone should be hidden in system (#782741) https://bugzilla.redhat.com/782741 I

[Engine-patches] Change in ovirt-engine[master]: webadmin: Role Tree should be collapsed (#782729)

2012-01-19 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Role Tree should be collapsed (#782729) .. webadmin: Role Tree should be collapsed (#782729) https://bugzilla.redhat.com/782729 MLA - When ed

[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url

2012-01-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: virt-engine: Support RHEVManager url .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1120

[Engine-patches] Change in ovirt-engine[master]: webadmin: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1131 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: userportal: Rename MergeSnapshot to RemoveSnapshot

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Rename MergeSnapshot to RemoveSnapshot .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1132 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Role Tree should be collapsed (#782729)

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Role Tree should be collapsed (#782729) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1136 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Everyone should be hidden in system (#782741)

2012-01-19 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Everyone should be hidden in system (#782741) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1137 To unsu

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add host #782734

2012-01-19 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: unable to add host #782734 .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1140 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add host #782734

2012-01-19 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: cli: unable to add host #782734 .. cli: unable to add host #782734 https://bugzilla.redhat.com/show_bug.cgi?id=782734 Change-Id: I4f4d912efdd64f4a8

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unable to add host #782734

2012-01-19 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: unable to add host #782734 .. cli: unable to add host #782734 https://bugzilla.redhat.com/show_bug.cgi?id=782734 Change-Id: I4f4d912efdd64f4a806f1c7be

  1   2   >