ol...@redhat.com has posted comments on this change.

Change subject: rest-api: exposing  setupnetworks action under 
/api/hosts/{id}/nics
......................................................................


Patch Set 2: (1 inline comment)

I have a comment about yaml, see inline. 

The rest looks great :)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1188:  name: /api/hosts/{host:id}/nics/{nic:id}/attach|rel=attach
please replace with: 

- name: /api/hosts/{host:id}/nics/setupnetworks|rel=setupnetworks
  request:
    body:
      parameterType: Action
      signatures:
      - mandatoryArguments: {}
        optionalArguments:          
          action.host_nics.host_nic.bonding.slaves.host_nic--LIST: {name|id: 
'xs:string'}
          action.host_nics.host_nic.network.id|name: 'xs:string'
          action.host_nics.hostnic.name: 'xs:string'
          action.host_nics.host_nic.bonding.options.option--LIST: {name: 
'xs:string', value: 'xs:string', type: 'xs:string'}
          action.host_nics.host_nic.ip.gateway: xs:string
          action.host_nics.host_nic.boot_protocol: xs:string
          action.host_nics.host_nic.mac: xs:string
          action.host_nics.host_nic.ip.address: xs:string
          action.host_nics.host_nic.ip.netmask: xs:string
          action.checkConnectivity: xs:boolean
          action.connectivityTimeout: xs:int
          action.force: xs:boolean
    urlparams: {}
    headers: {Content-Type: application/xml}

--
To view, visit http://gerrit.ovirt.org/1112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9464f344605b99a21806170cf340e8fd8063dff6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: ol...@redhat.com
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to