Yair Zaslavsky has posted comments on this change. Change subject: core: Add VmDeviceDAODbFacadeImpl ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java Line 72: Guid.createGuidFromString(rs An idea - Are you in favor of having ResultSetUtils.getGuid(rs,"field_name") ? I know the conversion here is trivial, but I'm starting to think we might need that for more custom types in the future. -- To view, visit http://gerrit.ovirt.org/1158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12ac2bc06be1a906247eda5c2eef9a490b6aea6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
