Mike Kolesnik has posted comments on this change.
Change subject: engine-core: minor copypaste cleanup
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ad_groups.java
Line 70: * @deprecated please use {@link ad_groups#getId()} instead!
Please also add patches to remove use of these methods in clients and then you
can delete them.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAODbFacadeImpl.java
Line 73: return getCustomMapSqlParameterSource()
You can re-use here getCustomMapSqlParameterSource(group.getId()) instead of
specifying the id field again.
Line 81: private static final class ADGroupRowMapper implements
ParameterizedRowMapper<ad_groups> {
I would go even further and inline this as an anonymous class of the
createEntityRowMapper method, since there really is no use for it elsewhere
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAO.java
Line 13: public interface AdGroupDAO extends GenericDao<ad_groups, Guid> {
You should probably also delete the method declarations that already are in
GenericDao.
--
To view, visit http://gerrit.ovirt.org/551
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9a8f7bbc71a591f7229f2f5ef41dde5021d5827
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Jonathan Choate <jcho...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Salem Muli <msale...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
