[Bug debuginfod/27701] use long lived debuginfod-client objects & curl handles

2021-05-12 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27701 Frank Ch. Eigler changed: What|Removed |Added See Also||https://sourceware.org/bugz

[Bug debuginfod/27859] reused debuginfod_client objects don't clean out curl handles enough

2021-05-12 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27859 Frank Ch. Eigler changed: What|Removed |Added See Also||https://sourceware.org/bugz

[Bug debuginfod/27859] New: reused debuginfod_client objects don't clean out curl handles enough

2021-05-12 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27859 Bug ID: 27859 Summary: reused debuginfod_client objects don't clean out curl handles enough Product: elfutils Version: unspecified Status: NEW Severity: norm

[Bug tools/27856] eu-elfcompress exit code changed to a error if 'Nothing to do'

2021-05-12 Thread ldv at sourceware dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27856 Dmitry V. Levin changed: What|Removed |Added Status|NEW |RESOLVED Assignee|unassig

[PATCH v2] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
Exit status of 255 in case of an error is probably not what elfcompress users expect, change it to 1. Reported-by: Vitaly Chikunov Fixes: 92acb57eb046 ("elfcompress: New utility.") --- src/ChangeLog | 3 +++ src/elfcompress.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --gi

Re: [PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Mark Wielaard
Hi Dmitry, On Wed, May 12, 2021 at 11:35:27PM +0300, Dmitry V. Levin wrote: > On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote: > > On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote: > > > Exit status of 255 in case of an error is probably not what elfcompress > > > user

[Bug tools/27856] eu-elfcompress exit code changed to a error if 'Nothing to do'

2021-05-12 Thread vt at altlinux dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27856 --- Comment #3 from Vitaly Chikunov --- Excuse me for referencing the wrong commit. It was another copy-paste error. 0df0e8e Timm Bäder 2021-02-17 09:45 +0100 522│ if (foutput == NULL && get_sections (sections, shnum) == 0) ed6299

Re: [PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
Hi Mark, On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote: > > Exit status of 255 in case of an error is probably not what elfcompress > > users expect, change it to 1. > > > > Reported-by: Vitaly Chik

Re: [PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Mark Wielaard
Hi Dmitry, On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote: > Exit status of 255 in case of an error is probably not what elfcompress > users expect, change it to 1. > > Reported-by: Vitaly Chikunov > Fixes: 92acb57eb046 ("elfcompress: New utility.") > [...] > diff --git a/src/

Re: [PATCH 2/2] elfcompress: remove redundant assignment

2021-05-12 Thread Mark Wielaard
Hi Dmitry, On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote: > At the point of "Nothing to do" fnew variable has not been assigned > after initialization, so it does not have to be reset to NULL. > > Note that any reset of fnew to NULL has to preceded with free(fnew). > > Fixes: e

Re: [PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

2021-05-12 Thread Mark Wielaard
Hi Dmitry, On Wed, May 12, 2021 at 10:18:36PM +0300, Dmitry V. Levin wrote: > On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote: > > When elfcompress decides that no section data needs to be updated and > > therefore the file does not have to be rewritten, it still has to exit > > wi

Re: [PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

2021-05-12 Thread Dmitry V. Levin
On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote: > When elfcompress decides that no section data needs to be updated and > therefore the file does not have to be rewritten, it still has to exit > with a zero status indicating success. > > Resolves: https://sourceware.org/bugzilla/s

[PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
Exit status of 255 in case of an error is probably not what elfcompress users expect, change it to 1. Reported-by: Vitaly Chikunov Fixes: 92acb57eb046 ("elfcompress: New utility.") --- src/ChangeLog | 2 ++ src/elfcompress.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] elfcompress: remove redundant assignment

2021-05-12 Thread Dmitry V. Levin
At the point of "Nothing to do" fnew variable has not been assigned after initialization, so it does not have to be reset to NULL. Note that any reset of fnew to NULL has to preceded with free(fnew). Fixes: ed62996defc6 ("elfcompress: Don't rewrite file if no section data needs to be updated.")

[PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

2021-05-12 Thread Dmitry V. Levin
When elfcompress decides that no section data needs to be updated and therefore the file does not have to be rewritten, it still has to exit with a zero status indicating success. Resolves: https://sourceware.org/bugzilla/show_bug.cgi?id=27856 Fixes: ed62996defc6 ("elfcompress: Don't rewrite file

[Bug tools/27856] eu-elfcompress exit code changed to a error if 'Nothing to do'

2021-05-12 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27856 Mark Wielaard changed: What|Removed |Added Ever confirmed|0 |1 CC|

[Bug tools/27856] eu-elfcompress exit code changed to a error if 'Nothing to do'

2021-05-12 Thread vt at altlinux dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27856 --- Comment #1 from Vitaly Chikunov --- Correction of copy-paste: + eu-elfcompress --verbose ./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/unicode/zunicode.ko.debug processing: ./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/unicode

[Bug tools/27856] New: eu-elfcompress exit code changed to a error if 'Nothing to do'

2021-05-12 Thread vt at altlinux dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27856 Bug ID: 27856 Summary: eu-elfcompress exit code changed to a error if 'Nothing to do' Product: elfutils Version: unspecified Status: UNCONFIRMED Severity: no

Re: [PATCH] RFC: come up with startswith function.

2021-05-12 Thread Martin Liška
On 5/12/21 12:01 PM, Mark Wielaard wrote: Sorry it missed the 0.184 release. Thanks. Don't worry, it's a NOP, nothing urgent. Martin

Re: [PATCH] RFC: come up with startswith function.

2021-05-12 Thread Mark Wielaard
Hi Martin, On Mon, 2021-05-10 at 15:26 +0200, Martin Liška wrote: > On 5/1/21 12:13 AM, Mark Wielaard wrote: > > Yes, it is. It looks good and makes the code simpler to read. > > Thanks. > > > Is it OK to add your Signed-off-by before I push it? > > Yes, please do it and push it. Pushed as: c