https://sourceware.org/bugzilla/show_bug.cgi?id=27701
Frank Ch. Eigler changed:
What|Removed |Added
See Also||https://sourceware.org/bugz
https://sourceware.org/bugzilla/show_bug.cgi?id=27859
Frank Ch. Eigler changed:
What|Removed |Added
See Also||https://sourceware.org/bugz
https://sourceware.org/bugzilla/show_bug.cgi?id=27859
Bug ID: 27859
Summary: reused debuginfod_client objects don't clean out curl
handles enough
Product: elfutils
Version: unspecified
Status: NEW
Severity: norm
https://sourceware.org/bugzilla/show_bug.cgi?id=27856
Dmitry V. Levin changed:
What|Removed |Added
Status|NEW |RESOLVED
Assignee|unassig
Exit status of 255 in case of an error is probably not what elfcompress
users expect, change it to 1.
Reported-by: Vitaly Chikunov
Fixes: 92acb57eb046 ("elfcompress: New utility.")
---
src/ChangeLog | 3 +++
src/elfcompress.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --gi
Hi Dmitry,
On Wed, May 12, 2021 at 11:35:27PM +0300, Dmitry V. Levin wrote:
> On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote:
> > On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote:
> > > Exit status of 255 in case of an error is probably not what elfcompress
> > > user
https://sourceware.org/bugzilla/show_bug.cgi?id=27856
--- Comment #3 from Vitaly Chikunov ---
Excuse me for referencing the wrong commit. It was another copy-paste error.
0df0e8e Timm Bäder 2021-02-17 09:45 +0100 522│ if (foutput == NULL &&
get_sections (sections, shnum) == 0)
ed6299
Hi Mark,
On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote:
> Hi Dmitry,
>
> On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote:
> > Exit status of 255 in case of an error is probably not what elfcompress
> > users expect, change it to 1.
> >
> > Reported-by: Vitaly Chik
Hi Dmitry,
On Wed, May 12, 2021 at 04:00:00PM +, Dmitry V. Levin wrote:
> Exit status of 255 in case of an error is probably not what elfcompress
> users expect, change it to 1.
>
> Reported-by: Vitaly Chikunov
> Fixes: 92acb57eb046 ("elfcompress: New utility.")
> [...]
> diff --git a/src/
Hi Dmitry,
On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote:
> At the point of "Nothing to do" fnew variable has not been assigned
> after initialization, so it does not have to be reset to NULL.
>
> Note that any reset of fnew to NULL has to preceded with free(fnew).
>
> Fixes: e
Hi Dmitry,
On Wed, May 12, 2021 at 10:18:36PM +0300, Dmitry V. Levin wrote:
> On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote:
> > When elfcompress decides that no section data needs to be updated and
> > therefore the file does not have to be rewritten, it still has to exit
> > wi
On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote:
> When elfcompress decides that no section data needs to be updated and
> therefore the file does not have to be rewritten, it still has to exit
> with a zero status indicating success.
>
> Resolves: https://sourceware.org/bugzilla/s
Exit status of 255 in case of an error is probably not what elfcompress
users expect, change it to 1.
Reported-by: Vitaly Chikunov
Fixes: 92acb57eb046 ("elfcompress: New utility.")
---
src/ChangeLog | 2 ++
src/elfcompress.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git
At the point of "Nothing to do" fnew variable has not been assigned
after initialization, so it does not have to be reset to NULL.
Note that any reset of fnew to NULL has to preceded with free(fnew).
Fixes: ed62996defc6 ("elfcompress: Don't rewrite file if no section data needs
to be updated.")
When elfcompress decides that no section data needs to be updated and
therefore the file does not have to be rewritten, it still has to exit
with a zero status indicating success.
Resolves: https://sourceware.org/bugzilla/show_bug.cgi?id=27856
Fixes: ed62996defc6 ("elfcompress: Don't rewrite file
https://sourceware.org/bugzilla/show_bug.cgi?id=27856
Mark Wielaard changed:
What|Removed |Added
Ever confirmed|0 |1
CC|
https://sourceware.org/bugzilla/show_bug.cgi?id=27856
--- Comment #1 from Vitaly Chikunov ---
Correction of copy-paste:
+ eu-elfcompress --verbose
./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/unicode/zunicode.ko.debug
processing:
./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/unicode
https://sourceware.org/bugzilla/show_bug.cgi?id=27856
Bug ID: 27856
Summary: eu-elfcompress exit code changed to a error if
'Nothing to do'
Product: elfutils
Version: unspecified
Status: UNCONFIRMED
Severity: no
On 5/12/21 12:01 PM, Mark Wielaard wrote:
Sorry it missed the 0.184 release.
Thanks. Don't worry, it's a NOP, nothing urgent.
Martin
Hi Martin,
On Mon, 2021-05-10 at 15:26 +0200, Martin Liška wrote:
> On 5/1/21 12:13 AM, Mark Wielaard wrote:
> > Yes, it is. It looks good and makes the code simpler to read.
>
> Thanks.
>
> > Is it OK to add your Signed-off-by before I push it?
>
> Yes, please do it and push it.
Pushed as:
c
20 matches
Mail list logo