Hi Mark,
On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote:
> Hi Dmitry,
>
> On Wed, May 12, 2021 at 04:00:00PM +0000, Dmitry V. Levin wrote:
> > Exit status of 255 in case of an error is probably not what elfcompress
> > users expect, change it to 1.
> >
> > Reported-by: Vitaly Chikunov <v...@altlinux.org>
> > Fixes: 92acb57eb046 ("elfcompress: New utility.")
> > [...]
> > diff --git a/src/elfcompress.c b/src/elfcompress.c
> > index 05f3bc2c..dacaff32 100644
> > --- a/src/elfcompress.c
> > +++ b/src/elfcompress.c
> > @@ -1358,5 +1358,5 @@ main (int argc, char **argv)
> > while (++remaining < argc);
> >
> > free_patterns ();
> > - return result;
> > + return !!result;
> > }
>
> The change to return 1 (or zero) is good.
>
> But could we instead initialize res to 1
That is, change process_file() to return 1 (or EXIT_FAILURE)
instead of -1 in case of an error?
--
ldv
