Exit status of 255 in case of an error is probably not what elfcompress users expect, change it to 1.
Reported-by: Vitaly Chikunov <v...@altlinux.org> Fixes: 92acb57eb046 ("elfcompress: New utility.") --- src/ChangeLog | 3 +++ src/elfcompress.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index de130f79..2c7be185 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,8 @@ 2021-05-12 Dmitry V. Levin <l...@altlinux.org> + * elfcompress.c (process_file): Return 1 instead of -1 in case of an + error. + * elfcompress.c (process_file): Remove redundant assignment in case of "Nothing to do". diff --git a/src/elfcompress.c b/src/elfcompress.c index 05f3bc2c..2c6d91ba 100644 --- a/src/elfcompress.c +++ b/src/elfcompress.c @@ -298,7 +298,7 @@ process_file (const char *fname) /* How many sections are we talking about? */ size_t shnum = 0; - int res = -1; + int res = 1; fd = open (fname, O_RDONLY); if (fd < 0) -- ldv