Hi Dmitry, On Wed, May 12, 2021 at 03:00:00PM +0000, Dmitry V. Levin wrote: > At the point of "Nothing to do" fnew variable has not been assigned > after initialization, so it does not have to be reset to NULL. > > Note that any reset of fnew to NULL has to preceded with free(fnew). > > Fixes: ed62996defc6 ("elfcompress: Don't rewrite file if no section data > needs to be updated.")
You are right. The NULL assignment is redundant at that spot. Thansk, Mark