Re: Improve coverage analysis toolset

2018-04-03 Thread Cillian O'Donnell
, Chris Johns wrote: > >> On 03/04/2018 02:10, Cillian O'Donnell wrote: >> > Sure if you want to crack at it. >> > >> > If you pull the ini-update branch again, I've included the other files >> you'll need. >> > >> > Now if you

Re: error while running rtems-test with coverage

2018-04-04 Thread Cillian O'Donnell
On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, wrote: > I got the rtems-test running > > I found that get_item_names(section, err) in configuration.py was > returning an empty list to the > item_names in load(bsp,opts) for config.py this was giving out the error > mandatory item not found . > >

Re: error while running rtems-test with coverage

2018-04-12 Thread Cillian O'Donnell
gt;> return opts.defaults['bsp'] >>>> File >>>> "/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py", line >>>> 190, in __getitem__ >>>> raise IndexError('key: %s' % (key)) >>>> In

Re: error while running rtems-test with coverage

2018-04-12 Thread Cillian O'Donnell
b.com/AdaCore/qemu > > I guess this is regular qemu , please send a link for couverture qemu for > manual build. > > -- vijay > > On 12 April 2018 at 22:23, Cillian O'Donnell > wrote: > >> Ah that's good progress, those .cov files are supposed to be generate

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
> > On 13 April 2018 at 11:43, Cillian O'Donnell > wrote: > >> No that's the right one. I think it might be something to do with >> qemu.cfg in rtems-tools then. What's in your qemu.cfg? It's in >> rtems-tools/tester/rtems/testing >> >> On F

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
> %define bsp_qemu_opts %{nil} > %endif > %define qemu_cmd qemu-system-%{bsp_arch} > %define qemu_opts %{bsp_qemu_opts} > > # > # Executable > # > %execute %{qemu_cmd} %{qemu_opts} -kernel %{test_executable} > > -- vijay > > On 13 April 2018 at 22:19, Cilli

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
%if %{coverage_supported} > error: qemu.cfg:77: macro '%{coverage_supported}' not found > warning: switched to dry run due to errors > error: qemu.cfg:77: invalid if bool value: %if %{coverage_supported} > > > > -- vijay > > On 13 April 2018 at 22:54, Cillian O'Donnell

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
gt;>> tst.reraise() >>> File >>> "/home/lunatic/development/rtems/test/rtems-tools/tester/rt/test.py", line >>> 160, in reraise >>> _test_reraise(*self.result) >>> NameError: global name '_test_reraise' is not defined >&g

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
Is there anywhere in that output that it shows the qemu command that is running? On Fri, 13 Apr 2018, 19:02 Vijay Kumar Banerjee, wrote: > > -- vijay > > On 13 April 2018 at 23:29, Cillian O'Donnell > wrote: > >> I can't say for certain but I don't th

Re: error while running rtems-test with coverage

2018-04-13 Thread Cillian O'Donnell
e/lunatic/d > evelopment/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/hello/hello.exe > 26 WARNING: Unable to read coverage file > /home/lunatic/development/rtems/kernel/leon3/sparc-rt > ems5/c/leon3/testsuites/samples/hello/hello.exe.cov > >1,1 Top > &

Re: error while running rtems-test with coverage

2018-04-14 Thread Cillian O'Donnell
; is not defined >> >> > The reraise logic was moved to the rtemstoolkit last year: > > https://git.rtems.org/rtems-tools/commit/?id=fa81491764861e6 > 3785a3faa241c488469087209 > > It had some issues that have been fixed and it is being reused else where > in the tester. > > >&g

Re: error while running rtems-test with coverage

2018-04-14 Thread Cillian O'Donnell
Vijay Kumar Banerjee > wrote: > >> >> >> >> On 14 April 2018 at 16:42, Cillian O'Donnell >> wrote: >> >>> >>> >>> On 14 April 2018 at 07:11, Chris Johns wrote: >>> >>>> On 14/4/18 8:02 am, Vijay Kumar Banerj

Re: error while running rtems-test with coverage

2018-04-15 Thread Cillian O'Donnell
On 15 April 2018 at 06:46, Vijay Kumar Banerjee wrote: > > > On 15 April 2018 at 01:45, Cillian O'Donnell > wrote: > >> Switch one of these lines out in qemu.cfg. >> >> #%define qemu_opts_base -no-reboot -monitor none -serial stdio -nographic >> #%d

Re: error while running rtems-test with coverage

2018-04-15 Thread Cillian O'Donnell
Not sure what's happening there. Send me a link to your github branch. On 15 April 2018 at 09:35, Vijay Kumar Banerjee wrote: > > > On 15 April 2018 at 14:02, Cillian O'Donnell > wrote: > >> >> >> On 15 April 2018 at 06:46, Vijay Kumar Banerjee >

Re: error while running rtems-test with coverage

2018-04-15 Thread Cillian O'Donnell
On 15 April 2018 at 10:09, Cillian O'Donnell wrote: > Not sure what's happening there. Send me a link to your github branch. > > On 15 April 2018 at 09:35, Vijay Kumar Banerjee > wrote: > >> >> >> On 15 April 2018 at 14:02, Cillian O'Donnell &g

Re: error while running rtems-test with coverage

2018-04-15 Thread Cillian O'Donnell
is time I'm not sure because we haven't changed anything like that. If I think of any clues, I'll let you know. On Mon, 16 Apr 2018, 05:36 Vijay Kumar Banerjee, wrote: > > > On 15 April 2018 at 15:33, Cillian O'Donnell > wrote: > >> >> >> On

Re: error while running rtems-test with coverage

2018-04-16 Thread Cillian O'Donnell
output that will give me an idea of what it should > look like ? > > On Mon, 16 Apr 2018, 11:13 Cillian O'Donnell, > wrote: > >> Probably what'll happen is, when the reports are generating properly, >> Chris will review the changes and come up with a list

Re: error while running rtems-test with coverage

2018-04-16 Thread Cillian O'Donnell
to look into covoar. >> Do you have any sample output that will give me an idea of what it should >> look like ? >> >> On Mon, 16 Apr 2018, 11:13 Cillian O'Donnell, >> wrote: >> >>> Probably what'll happen is, when the reports are generating prop

Re: the generated coverage report doesn't contain any data

2018-04-16 Thread Cillian O'Donnell
On 16 April 2018 at 17:46, Joel Sherrill wrote: > > > On Mon, Apr 16, 2018 at 2:33 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> current status : >> the coverage is running now with rtems-test and generating the report, >> however, the report doesn't show any data. >> > > I'v

Re: the generated coverage report doesn't contain any data

2018-04-16 Thread Cillian O'Donnell
Banerjee, wrote: > > > On Tue, 17 Apr 2018, 03:19 Joel Sherrill, wrote: > >> >> >> On Mon, Apr 16, 2018 at 4:47 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> >>> On 17 April 2018 at 01:43, Cilli

Re: the generated coverage report doesn't contain any data

2018-04-16 Thread Cillian O'Donnell
Also if there's any file in covoar directory of coverage-merge branch that's called symbol-set.c symbol_set_reader.h or any variation of that, that you don't already have pull all of them into your current branch. On Tue, 17 Apr 2018, 07:19 Cillian O'Donnell, wrote: > Som

Re: the generated coverage report doesn't contain any data

2018-04-17 Thread Cillian O'Donnell
/sparc-rtems5/c/ >> leon3/testsuites/samples/base_sp/base_sp.exe/60) >> >> INFO: DesiredSymbols::mergeCoverageMap - Unable to merge coverage map >> for _Workspace_Allocate_or_fatal_error because the sizes are different >> >> Am I still possibly missing somethi

Re: the generated coverage report doesn't contain any data

2018-04-19 Thread Cillian O'Donnell
the > generated code more closely match the source. > > I suppose the next step is to work to get Cillian's updated work merged. > > Then for me to try to duplicate the results. > > FWIW I am teaching an RTEMS class next week and won't be around as much. > > -

[PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-25 Thread Cillian O'Donnell
patches up a bit more, I'm just trying to give everyone a look at what I have locally here. I'm not sure how much of this is superfluous with Chris's propesed changes but its a starting point for us to see what we want to do with all this.*** Cillian O'Donnell (2): covoar: A

[PATCH 2/2] rtems-tools/../testing: Add configuration files for coverage analysis.

2018-04-25 Thread Cillian O'Donnell
Co-author: Krzysztof Miesowicz Co-author: Vijay Kumar Banerjee --- tester/rtems/testing/bsps/leon3_qemu.ini | 52 ++ tester/rtems/testing/coverage.ini | 49 + tester/rtems/testing/coverage/Categories.txt | 19 ++ tester/rtems/testing/coverage/Explanati

[PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-25 Thread Cillian O'Donnell
Add ability to organize symbol sets of libraries in symbol_set.cfg and then read them with covoar (Krzysztof Miesowicz)) Also the symbols are now loaded in from ELF data rather than relying on nm.(Cillian O'Donnell) Co-author:"Krzysztof Miesowicz " --- tester/covoar/SymbolSet.

Re: [PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-25 Thread Cillian O'Donnell
On Thu, 26 Apr 2018, 03:27 Chris Johns, wrote: > On 26/04/2018 06:33, Cillian O'Donnell wrote: > > *** ALright so here is everything that exists locally for covoar that > > was never merged. It amounts to the symbol set reader and the ability > > to load the symbols

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 04:48 Chris Johns, wrote: > On 27/04/2018 08:51, Joel Sherrill wrote: > > > >// Create the set of desired symbols. > >SymbolsToAnalyze = new Coverage::DesiredSymbols(); > > - SymbolsToAnalyze->load( symbolsFile ); > > > > > > I am having trouble seeing wh

Re: [PATCH 2/2] rtems-tools/../testing: Add configuration files for coverage analysis.

2018-04-27 Thread Cillian O'Donnell
The .css file is a support file for the output. > > Not sure where the else fall but these seems like a handful of small > patches > rather than one larger patch. > > --joel > > On Wed, Apr 25, 2018 at 3:33 PM, Cillian O'Donnell > wrote: > >>

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 08:32 Chris Johns, wrote: > On 27/04/2018 17:21, Cillian O'Donnell wrote: > > On Fri, 27 Apr 2018, 04:48 Chris Johns, > <mailto:chr...@rtems.org>> wrote: > > > > On 27/04/2018 08:51, Joel Sherrill wrote: > > > > &

Re: [PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-27 Thread Cillian O'Donnell
On 26 April 2018 at 08:50, Chris Johns wrote: > On 26/04/2018 16:11, Cillian O'Donnell wrote: > > On Thu, 26 Apr 2018, 03:27 Chris Johns, > <mailto:chr...@rtems.org>> wrote: > > > >> Also, are there any RSB changes outstanding to build a suitable QEMU

Re: [PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-28 Thread Cillian O'Donnell
On 28 April 2018 at 01:25, Chris Johns wrote: > > > On 28/4/18 7:41 am, Cillian O'Donnell wrote: > > > > > > On 26 April 2018 at 08:50, Chris Johns > <mailto:chr...@rtems.org>> wrote: > > > > On 26/04/2018 16:11, Cillian O'Do

[PATCH 1/3] source-builder/config: Add couverture-qemu general config & build instructions.

2018-04-28 Thread Cillian O'Donnell
--- source-builder/config/couverture-qemu-2-1.cfg | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 source-builder/config/couverture-qemu-2-1.cfg diff --git a/source-builder/config/couverture-qemu-2-1.cfg b/source-builder/config/couverture-qemu-2-1.cfg new f

[PATCH 3/3] bare/config/devel: Add couverture-qemu build dependencies.

2018-04-28 Thread Cillian O'Donnell
--- bare/config/devel/couverture-qemu.bset | 25 + 1 file changed, 25 insertions(+) create mode 100644 bare/config/devel/couverture-qemu.bset diff --git a/bare/config/devel/couverture-qemu.bset b/bare/config/devel/couverture-qemu.bset new file mode 100644 index 000..

[PATCH 2/3] bare/config/devel: Add couverture-qemu source location and patches needed.

2018-04-28 Thread Cillian O'Donnell
--- bare/config/devel/couverture-qemu-git-1.cfg | 32 + 1 file changed, 32 insertions(+) create mode 100644 bare/config/devel/couverture-qemu-git-1.cfg diff --git a/bare/config/devel/couverture-qemu-git-1.cfg b/bare/config/devel/couverture-qemu-git-1.cfg new file mod

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
On 28 April 2018 at 08:08, Chris Johns wrote: > From: Cillian O'Donnell > > Add ability to organize symbol sets of libraries in INI file > and then read them with covoar and load the symbols directly from the > libraries. > > rtems-tools/../testing: Add configuration f

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
; File "/home/lunatic/development/rtems/test/rtems-tools/tester/wscript", > line 35, in recurse > ctx.recurse(sd) > File "/home/lunatic/development/rtems/test/rtems-tools/.waf-1.9.9- > 75529a659e4f06cb4254801e52405e0a/waflib/Context.py", line 129, in recurse >

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, wrote: > > This is the log file that I'm getting after running the test > > I'm getting a lot of 'invalid' results , am I missing something ? > What we had in coverage.py and test.py will need to be updated with Chris' change to covoar. It's prob

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Cillian O'Donnell
On 28 April 2018 at 08:08, Chris Johns wrote: > From: Cillian O'Donnell > > Add ability to organize symbol sets of libraries in INI file > and then read them with covoar and load the symbols directly from the > libraries. > > rtems-tools/../testing: Add configuration f

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Cillian O'Donnell
On Sun, 29 Apr 2018, 23:30 Chris Johns, wrote: > On 29/04/2018 20:50, Cillian O'Donnell wrote: > > On 28 April 2018 at 08:08, Chris Johns > <mailto:chr...@rtems.org>> wrote: > > + for (const std::string set : sets) { > > +if

Re: [PATCH 1/3] source-builder/config: Add couverture-qemu general config & build instructions.

2018-04-30 Thread Cillian O'Donnell
On Tue, 1 May 2018, 00:52 Chris Johns, wrote: > On 28/04/2018 20:18, Cillian O'Donnell wrote: > > --- > > source-builder/config/couverture-qemu-2-1.cfg | 104 > ++ > > Why a new file? Could the existing qemu config be used? > We were thin

Re: rtems-tools: coverage covoar GSoC merge

2018-05-03 Thread Cillian O'Donnell
On Thu, 3 May 2018, 16:23 Vijay Kumar Banerjee, wrote: > Hello, > > I want to ask some things about the project to get a clear understanding > of the objectives/milestones and current status of the project. I also seek > advice on my Tasks/obectives. > > 1. The covoar has been updated to read sym

Re: rtems-tools: coverage covoar GSoC merge

2018-05-03 Thread Cillian O'Donnell
On Fri, 4 May 2018, 01:15 Chris Johns, wrote: > On 04/05/2018 09:04, Joel Sherrill wrote: > > On Thu, May 3, 2018 at 1:45 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com > > <mailto:vijaykumar9...@gmail.com>> wrote: > > On 3 May 2018 at 22:58, Cilli

Re: rtems-tools: coverage covoar GSoC merge

2018-05-03 Thread Cillian O'Donnell
On Fri, 4 May 2018, 00:04 Joel Sherrill, wrote: > > > On Thu, May 3, 2018 at 1:45 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> >> On 3 May 2018 at 22:58, Cillian O'Donnell wrote: >> >>> >>> >>> On Thu,

Re: rtems-tools: coverage covoar GSoC merge

2018-05-03 Thread Cillian O'Donnell
On Fri, 4 May 2018, 07:51 Vijay Kumar Banerjee, wrote: > > > On Fri, 4 May 2018, 12:17 Cillian O'Donnell, > wrote: > >> >> >> On Fri, 4 May 2018, 00:04 Joel Sherrill, wrote: >> >>> >>> >>> On Thu, May 3, 2018

Re: [PATCH] Add DWARF support to rtemstoolkit and use it in covoar

2018-05-05 Thread Cillian O'Donnell
Hi Chris, Getting some build errors here. It complains about dwarf.h and libdwarf.h so theres 2 packages that I can get them from but both end up producing some problems. 'Elf' has a previous declaration in one and missing typedef for the other. Is there a particular version of these libraries tha

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Cillian O'Donnell
On 5 May 2018 at 21:12, Chris Johns wrote: > > > > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: > > > > Looks similar to Cillian's failure. Chris will have to show me where > libdwarf comes from. It needs to be supplied with RTEMS tools for > consistency. > > You need to apply the patches aga

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Yeah I'm seeing the same as Joel, at least were further then we were :). I've been mostly working on the rtems-tester support, so just to give an update. I spent all day Saturday and today on it. It's taking longer than expected, re-orienting myself and deciding what is needed and not needed now w

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
oel Sherrill wrote: > >> >> >> On Mon, May 7, 2018 at 12:36 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> On Mon, 7 May 2018, 22:57 Cillian O'Donnell, >>> wrote: >>> >>>> Yeah I&#

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Here's the branch with work in progress for the tester. Have a look when you can Vijay. https://github.com/cillianodonnell/rtems-tools/tree/tester-support On 7 May 2018 at 19:59, Cillian O'Donnell wrote: > > > On 7 May 2018 at 18:56, Joel Sherrill wrote: > >>

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
fo (this=0x6bc3c0, theExecutableName=, theLibraryName=0x0) at ../tester/covoar/ExecutableInfo.cc:33 #15 0x004054b6 in main (argc=, argv=) at ../tester/covoar/covoar.cc:330 On 7 May 2018 at 20:03, Joel Sherrill wrote: > > > On Mon, May 7, 2018 at 1:59 PM, Cillian O'Donnell &

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
ossibly lost: 0 bytes in 0 blocks ==20928==still reachable: 6,603,039 bytes in 39,760 blocks ==20928== suppressed: 0 bytes in 0 blocks ==20928== Rerun with --leak-check=full to see details of leaked memory ==20928== ==20928== For counts of detected and suppressed errors, rerun with: -v ==2092

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-09 Thread Cillian O'Donnell
Just running covoar there, we seem to be running into some problems at the source line lookup stage cpod@cpod ~/development/rtems/leon3 $ covoar -S /home/cpod/development/rtems/test/rtems-tools/tester/rtems/testing/coverage/score-symbols.ini -O /home/cpod/coverage_test/test/score -E/home/cpod/deve

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-09 Thread Cillian O'Donnell
On Thu, 10 May 2018, 03:43 Chris Johns, wrote: > On 10/5/18 8:47 am, Cillian O'Donnell wrote: > > Just running covoar there, we seem to be running into some problems at > the > > source line lookup stage > > Thank you for testing this. I assume it builds OK and we

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-10 Thread Cillian O'Donnell
On Thu, 10 May 2018, 16:01 Vijay Kumar Banerjee, wrote: > > > On 8 May 2018 at 00:33, Cillian O'Donnell wrote: > >> Here's the branch with work in progress for the tester. Have a look when >> you can Vijay. >> >> https://github.com/cillianodonnell

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-10 Thread Cillian O'Donnell
On Thu, 10 May 2018, 11:48 Chris Johns, wrote: > On 10/5/18 2:43 pm, Chris Johns wrote: > > On 10/5/18 8:47 am, Cillian O'Donnell wrote: > >> > >> > >> GDB > >> > >> > >> (gdb) bt >

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-10 Thread Cillian O'Donnell
On 10 May 2018 at 19:39, Chris Johns wrote: > On 11/5/18 5:37 am, Cillian O'Donnell wrote: > > On Thu, 10 May 2018, 11:48 Chris Johns, > > > It is not a exception in an exception or in a stack unwind path, it > is an > > exception being thrown with no cat

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-10 Thread Cillian O'Donnell
is is doing now, we can keep an eye on what's happening and help with testing but we won't need to wait for it to move forward. So getting the tester to run covoar is separate and we can crack on with that. > > > On 10 May 2018 at 23:40, Joel Sherrill wrote: > >> On Thu,

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-10 Thread Cillian O'Donnell
On Thu, 10 May 2018, 22:23 Vijay Kumar Banerjee, wrote: > > > On Fri, 11 May 2018, 02:19 Cillian O'Donnell, > wrote: > >> >> >> On 10 May 2018 at 20:15, Vijay Kumar Banerjee >> wrote: >> >>> Frankly, I'm totally confused at th

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-10 Thread Cillian O'Donnell
On Fri, 11 May 2018, 06:17 Chris Johns, wrote: > On 11/5/18 4:44 pm, Chris Johns wrote: > > > > I am looking into the reason for the error which is proving difficult to > find. > > > > Cillian, could you please compress and email me offlist the ELF file for > the cov > file is for? > Will do. It

Re: V2 Add DWARF support to the rtemstoolkit and put it to use.

2018-05-11 Thread Cillian O'Donnell
Ah NZ almost exact opposite sides of the world, that worked out nicely. On Fri, 11 May 2018, 07:54 Chris Johns, wrote: > > On 11 May 2018, at 6:21 pm, Cillian O'Donnell > wrote: > > > > On Fri, 11 May 2018, 06:17 Chris Johns, wrote: > >> On 11/5/18 4:44 pm

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
It does seem to be having some knock on effect. Covoar made it past these checks before. - Total: 13 Average test time: 0:00:03.178923 Testing time : 0:00:41.326000 Running covoar for score covoar results directory: /home/cpod/development/rtems/leon3/coverage/score ERRO

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
t; >> vijaykumar9...@gmail.com> wrote: >> >>> >>> >>> On Sun, 13 May 2018, 16:09 Cillian O'Donnell, >>> wrote: >>> >>>> It does seem to be having some knock on effect. Covoar made it past >>>> these checks befo

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
but that's just collaborative development, you'll have to get used to it :)... On 13 May 2018 at 12:39, Vijay Kumar Banerjee wrote: > > > On Sun, 13 May 2018, 17:02 Cillian O'Donnell, > wrote: > >> But you see the thing is that if you remove the changes you m

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 13:35, Vijay Kumar Banerjee wrote: > > On Sun, 13 May 2018, 17:32 Cillian O'Donnell, > wrote: > >> I understand but that's a separate issue. I can do a full coverage run >> from the top of the build tree by changing hello.exe.cov to hello.co

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 13:47, Vijay Kumar Banerjee wrote: > > On Sun, 13 May 2018, 18:14 Cillian O'Donnell, > wrote: > >> >> >> On 13 May 2018 at 13:35, Vijay Kumar Banerjee >> wrote: >> >>> >>> On Sun, 13 May 2018, 17:32 Cillian O

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
=leon3-qemu-cov --coverage $HOME/development/rtems/leon3/sparc-rtems5/c/leon3/testsuites/samples On 13 May 2018 at 13:58, Vijay Kumar Banerjee wrote: > > > On Sun, 13 May 2018, 18:24 Cillian O'Donnell, > wrote: > >> >> >> On 13 May 2018 at 13:47, Vijay Kumar

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 16:32, Vijay Kumar Banerjee wrote: > On 13 May 2018 at 19:00, Cillian O'Donnell wrote: > >> Is there supposed to be a message there? >> >> Anyway just to clear this up, try this for me. >> >> 1. Grab a new branch of >> >>

[PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-13 Thread Cillian O'Donnell
--- tester/covoar/covoar.cc | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 5c87402..c6b0589 100644 --- a/tester/covoar/covoar.cc +++ b/tester/covoar/covoar.cc @@ -75,7 +75,7 @@ static void createBuildPath(Execu

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-13 Thread Cillian O'Donnell
On Sun, 13 May 2018, 22:15 Vijay Kumar Banerjee, wrote: > On 14 May 2018 at 02:15, Cillian O'Donnell wrote: > >> --- >> tester/covoar/covoar.cc | 10 +++--- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/tester/covoar/cov

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-14 Thread Cillian O'Donnell
On Mon, 14 May 2018, 16:46 Joel Sherrill, wrote: > I'll commit this once there is a log message. :) > You want the word 'Fix' is it?... :) > > On Sun, May 13, 2018 at 3:45 PM, Cillian O'Donnell > wrote: > >> --- >> tester/covoar/covoar.c

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-14 Thread Cillian O'Donnell
On Mon, 14 May 2018, 09:50 Vijay Kumar Banerjee, wrote: > On 14 May 2018 at 12:10, Cillian O'Donnell wrote: > >> >> >> On Sun, 13 May 2018, 22:15 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 14 May 2018 at 02:15,

[PATCH] covoar: Fix build path checks for multiple executables.

2018-05-14 Thread Cillian O'Donnell
--- tester/covoar/covoar.cc | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 5c87402..c6b0589 100644 --- a/tester/covoar/covoar.cc +++ b/tester/covoar/covoar.cc @@ -75,7 +75,7 @@ static void createBuildPath(Execu

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-17 Thread Cillian O'Donnell
On Thu, 17 May 2018, 21:32 Vijay Kumar Banerjee, wrote: > hello, > > I have attached the html report ! > Report looks good! Well done. Was that just for samples. Did the other sections appear in the report if you click through the links? Well it looks good but I hardcoded the paths, at least th

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-18 Thread Cillian O'Donnell
On Fri, 18 May 2018, 07:46 Vijay Kumar Banerjee, wrote: > On Fri, 18 May 2018, 11:52 Cillian O'Donnell, > wrote: > >> >> >> On Thu, 17 May 2018, 21:32 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> hello, >>&g

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-18 Thread Cillian O'Donnell
On Fri, 18 May 2018, 12:36 Vijay Kumar Banerjee, wrote: > > On 18 May 2018 at 12:30, Cillian O'Donnell wrote: > > >> Cool, you should run it for the full testsuite and take a look at that >> report (takes a while.. around 575 tests) >> >>> >>>

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-18 Thread Cillian O'Donnell
On Fri, 18 May 2018, 14:55 Vijay Kumar Banerjee, wrote: > > > On 18 May 2018 at 19:09, Cillian O'Donnell wrote: > >> >> >> On Fri, 18 May 2018, 12:36 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> O

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-19 Thread Cillian O'Donnell
, 19 May 2018, 03:06 Joel Sherrill, wrote: >>> >>>> >>>> >>>> On Fri, May 18, 2018 at 4:01 PM, Vijay Kumar Banerjee < >>>> vijaykumar9...@gmail.com> wrote: >>>> >>>>> On 19 May 2018 at 02:29, Vijay Kumar Ban

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-19 Thread Cillian O'Donnell
On Sat, 19 May 2018, 12:28 Vijay Kumar Banerjee, wrote: > On 19 May 2018 at 16:47, Cillian O'Donnell wrote: > >> >> God these messages again... at least I'm an expert in fixing these :) >> Vijay I'm only seeing the headings in the report on my end using

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-19 Thread Cillian O'Donnell
On Sat, 19 May 2018, 13:28 Vijay Kumar Banerjee, wrote: > On 19 May 2018 at 17:56, Vijay Kumar Banerjee > wrote: > >> On 19 May 2018 at 17:50, Vijay Kumar Banerjee >> wrote: >> >>> On 19 May 2018 at 17:44, Cillian O'Donnell >>> wrote: >>

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-19 Thread Cillian O'Donnell
It works.. Sorry I was using the right covoar but the wrong rtems-test. Ahh its nice to see the data back in the reports again. Did you manage to track down 2 exes with the mismatch in symbol size? On 19 May 2018 at 13:59, Vijay Kumar Banerjee wrote: > On 19 May 2018 at 18:28, Cillian O'

Re: [GSoC coverage] Possibility of being less active due to exams.

2018-05-19 Thread Cillian O'Donnell
On Sat, 19 May 2018, 20:59 Vijay Kumar Banerjee, wrote: > Hello, > > My end sem exams are starting next week from 22nd May and will go till > 31st May. During this period I will be less efficient. > I understand that the project is in a crucial state and 10 days of > inactivity is unacceptable so

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-20 Thread Cillian O'Donnell
On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, wrote: > On 20 May 2018 at 00:53, Vijay Kumar Banerjee > wrote: > >> >> >> On Sun, 20 May 2018, 00:45 Cillian O'Donnell, >> wrote: >> >>> It works.. Sorry I was using the right covoar but t

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-20 Thread Cillian O'Donnell
On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 02:29, Cillian O'Donnell wrote: > >> >> >> On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 20 May 2018 at 00:53

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-21 Thread Cillian O'Donnell
On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 11:56, Cillian O'Donnell wrote: > >> >> >> On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 02:29,

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-21 Thread Cillian O'Donnell
On Mon, 21 May 2018, 12:08 Cillian O'Donnell, wrote: > > > On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, > wrote: > >> On 21 May 2018 at 11:56, Cillian O'Donnell wrote: >> >>> >>> >>> On Sun, 20 May 2018, 22:33 Vijay Kumar Ban

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-21 Thread Cillian O'Donnell
On Mon, 21 May 2018, 12:18 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 16:39, Cillian O'Donnell wrote: > >> >> >> On Mon, 21 May 2018, 12:08 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On Mon, 21 May 2018, 11:49 Vi

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-21 Thread Cillian O'Donnell
samples/fileio/fileio.exe/84 != > /home/lunatic/development/rtems/kernel/leon3/sparc- > rtems5/c/leon3/testsuites/samples/base_sp/base_sp.exe/60) > = > > >> I have never seen a case where the code matched by hand and covoar messed >&g

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

2018-05-27 Thread Cillian O'Donnell
On Sun, 27 May 2018, 19:59 Vijay Kumar Banerjee, wrote: > Hello, > > The support for letting users input specific symbols > for coverage analysis is now working in my > cov-tester-support branch > > https://github.com/thelunatic/rtems-tools/tree/cov-tester-support > Brilliant Vijay, I'll take a

Re: Coverage support for tester

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: > On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee > wrote: > > On 30 May 2018 at 20:18, Gedare Bloom wrote: > >> > >> Hello Vijay, > >> > >> Do you expect/need an answer to something in here? > >> > >> gedare > >> > > Hello, > > > > I wante

Re: Coverage support for tester

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:15 Vijay Kumar Banerjee, wrote: > > > On Wed, 30 May 2018, 22:42 Cillian O'Donnell, > wrote: > >> >> >> On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: >> >>> On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee &g

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:21 Gedare Bloom, wrote: > Please provide your name in your commits (git config --user.name "My > Name") that you submit. > > The first line of this commit, and therefore the email subject, is > overly vague. Provide a slightly more specific description. > > On Wed, May 30,

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:54 Vijay Kumar Banerjee, wrote: > On 30 May 2018 at 22:51, Gedare Bloom wrote: > >> Please provide your name in your commits (git config --user.name "My >> Name") that you submit. >> >> OK Noted :) > >> The first line of this commit, and therefore the email subject, is >>

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
On 31 May 2018 at 19:07, Vijay Kumar Banerjee wrote: > Add support in tester to run covoar and generate an html report to display > the summary of the coverage reports generated from covoar. > > Co-authored-by : Cillian O'Donnell > --- > tester/rt/coverage.py

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
;> wrote: >> > On 1 June 2018 at 01:07, Cillian O'Donnell >> wrote: >> >> >> >> >> >> >> >> On 31 May 2018 at 19:07, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> >> >> wrote: >> >&g

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
Thu, 31 May 2018, 21:29 Vijay Kumar Banerjee, wrote: > On 1 June 2018 at 01:57, Cillian O'Donnell wrote: > >> So is it checking whether it's --coverage or --coverage=set1,set2? Are >> those the 2 possibilities your checking? >> >> Yes, right. :) > >>

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
On Thu, 31 May 2018, 22:03 Vijay Kumar Banerjee, wrote: > On 1 June 2018 at 02:14, Cillian O'Donnell wrote: > >> There is now a seperate bsp config for coverage, leon3-qemu-cov. That is >> enough to trigger coverage now and --coverage could be reserved for picking >&

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
On 4 June 2018 at 19:03, Vijay Kumar Banerjee wrote: > On 2 June 2018 at 01:00, Vijay Kumar Banerjee > wrote: > >> On 2 June 2018 at 00:48, Joel Sherrill wrote: >> >>> >>> >>> On Fri, Jun 1, 2018, 11:21 AM Vijay Kumar Banerjee < >>> vijaykumar9...@gmail.com> wrote: >>> On 1 June 2018 at 20

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
ve, and then create a master index.html for listing all the >>> report htmls. >>> >> >> A single run of the tester will test a single BSP. If you open two shell >> windows >> and run the tester in both, will those collide? >> >> In it's cur

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
On Mon, 4 Jun 2018, 21:20 Vijay Kumar Banerjee, wrote: > On 5 June 2018 at 01:28, Cillian O'Donnell wrote: > >> >> >> On 4 June 2018 at 20:29, Vijay Kumar Banerjee >> wrote: >> >>> On 5 June 2018 at 00:51, Joel Sherrill wrote: >>>

  1   2   3   >