Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Pavel Pisa
Hello Sebastian, On Thursday 14 of August 2014 07:39:19 Sebastian Huber wrote: > Hello, > > its nice that you use the new Termios device API. I would be happy to > receive comments if you found something odd about it. > > Contains the current GCC 4.8 or 4.9 branch HEAD all what is necessary for >

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Sebastian Huber
On 14/08/14 09:48, Pavel Pisa wrote: Hello Sebastian, On Thursday 14 of August 2014 07:39:19 Sebastian Huber wrote: Hello, its nice that you use the new Termios device API. I would be happy to receive comments if you found something odd about it. Contains the current GCC 4.8 or 4.9 branch HE

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Pavel Pisa
Hello Sebastian, On Thursday 14 of August 2014 10:07:06 Sebastian Huber wrote: > On 14/08/14 09:48, Pavel Pisa wrote: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch > >/mips/include/uapi/asm/inst.h?id=refs/tags/v3.15#n486 > > My experience with bitfields at this leve

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Pavel Pisa
Hello Joel, On Thursday 14 of August 2014 00:40:49 Joel Sherrill wrote: > On 8/13/2014 2:48 PM, Premysl Houdek wrote: > > --- /dev/null > > +++ b/c/src/lib/libbsp/arm/tms570/README > > @@ -0,0 +1,64 @@ > > +Development Board: TMS570LS31x Hercules Development Kit from TI ... > > +Execution > > + >

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Beside copying more than one char at once, rtems_termios_refill_transmitter() and rtems_termios_puts() now use a common helper that (after checking ORCVXOF) calls write() with as much chars as are available consecutively in rawOutBuf. Integer types used in new rtems_termios_start_xmit might not be

Re: Using rtl-host in covor - some questions

2014-08-14 Thread Gedare Bloom
On Wed, Aug 13, 2014 at 11:17 PM, Chris Johns wrote: > On 14/08/2014 6:58 am, Gedare Bloom wrote: >> >> We need to decide if we want 1 repo per "tool" or a consolidated tools >> repo. My opinion is to add the rtl-host and rtems-coverage as >> git-submodules within another repo the project manages

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Sebastian Huber
Hello Kolja, looks good, but I have some minor stuff. On 14/08/14 13:10, Kolja Waschk wrote: Beside copying more than one char at once, rtems_termios_refill_transmitter() and rtems_termios_puts() now use a common helper that (after checking ORCVXOF) calls write() with as much chars as are avail

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Gedare Bloom
On Thu, Aug 14, 2014 at 4:53 AM, Pavel Pisa wrote: > Hello Sebastian, > > On Thursday 14 of August 2014 10:07:06 Sebastian Huber wrote: >> On 14/08/14 09:48, Pavel Pisa wrote: >> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch >> >/mips/include/uapi/asm/inst.h?id=refs/t

Re: Using rtl-host in covor - some questions

2014-08-14 Thread Joel Sherrill
On 8/13/2014 10:13 PM, Chris Johns wrote: > On 14/08/2014 7:34 am, Joel Sherrill wrote: >> On 8/13/2014 3:49 PM, Krzysztof Mięsowicz wrote: >>> Hi, >>> >>> Thanks for your replies :-) I didn't see librld.a because I had old >>> version of repo and after updating it appears :-) >>> >>> I think for

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Joel Sherrill
On 8/14/2014 3:53 AM, Pavel Pisa wrote: > Hello Sebastian, > > On Thursday 14 of August 2014 10:07:06 Sebastian Huber wrote: >> On 14/08/14 09:48, Pavel Pisa wrote: >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch >>> /mips/include/uapi/asm/inst.h?id=refs/tags/v3.15#n4

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Joel Sherrill
Thanks. I am just worried about reproducibility or the BSP and test results combined with licensing and redistribution of the TI support code. As long as everyone is comfortable with that, I am as well. On 8/14/2014 4:04 AM, Pavel Pisa wrote: > Hello Joel, > > On Thursday 14 of August 2014 00:40:

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Pavel Pisa
Hello Gedare, On Thursday 14 of August 2014 15:12:44 Gedare Bloom wrote: > On Thu, Aug 14, 2014 at 4:53 AM, Pavel Pisa wrote: > I am OK with single bit masks - BSP_BIT32(7), but I prefer only single > > define per multi bit field. So my own approach is to use macros to find > > field start bit f

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Gedare Bloom
Since Joel commented on style issues, I'll try to stick to technical questions. On Wed, Aug 13, 2014 at 3:48 PM, Premysl Houdek wrote: > Included variants: > tms570ls3137_hdk_intram - place code and data into internal SRAM > tms570ls3137_hdk_sdram - place code into external SDRAM and data to

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Joel Sherrill
On 8/14/2014 8:46 AM, Pavel Pisa wrote: > Hello Gedare, > > On Thursday 14 of August 2014 15:12:44 Gedare Bloom wrote: >> On Thu, Aug 14, 2014 at 4:53 AM, Pavel Pisa wrote: > > I am OK with single bit masks - BSP_BIT32(7), but I prefer only single >>> define per multi bit field. So my own approa

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Hi Sebastian, + int nToSend; Integer type is wrong. Yes, just what the original refill_transmitter uses and expects: nToSend is passed as return value to rtems_refill_transmitter, which also returns it to its caller as an int... + (void)rtems_termios_start_xmit (tty, tty->rawOutBuf.Tail

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Pavel Pisa
Hello Joel, I fully understand. On Thursday 14 of August 2014 15:44:54 Joel Sherrill wrote: > Thanks. > > I am just worried about reproducibility or the BSP and test results > combined with licensing and redistribution of the TI support > code. As long as everyone is comfortable with that, I am a

Console driver that needs extra TIMER

2014-08-14 Thread Kolja Waschk
Hi, I'm developing a DMA-based UART driver for Blackfin. It requires an extra timer to trigger data processing after a transmission ended. This increases the amount of timers required by every application that uses it for the console. E.g. most of the tests won't even start without modificat

Re: Console driver that needs extra TIMER

2014-08-14 Thread Joel Sherrill
On 8/14/2014 9:11 AM, Kolja Waschk wrote: > Hi, > > I'm developing a DMA-based UART driver for Blackfin. It requires an > extra timer to trigger data processing after a transmission ended. This > increases the amount of timers required by every application that uses > it for the console. Don't

Re: Console driver that needs extra TIMER

2014-08-14 Thread Gedare Bloom
On Thu, Aug 14, 2014 at 10:15 AM, Joel Sherrill wrote: > > On 8/14/2014 9:11 AM, Kolja Waschk wrote: >> Hi, >> >> I'm developing a DMA-based UART driver for Blackfin. It requires an >> extra timer to trigger data processing after a transmission ended. This >> increases the amount of timers require

Re: Console driver that needs extra TIMER

2014-08-14 Thread Sebastian Huber
On 14/08/14 16:15, Joel Sherrill wrote: E.g. most of the tests won't even start without modifications. So >effectively I have to fall back to a polling driver for console if I >want to run the tests unmodified, or is there any mechanism to generally >increment the amount of timers for all tests?

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Sebastian Huber
On 14/08/14 15:58, Kolja Waschk wrote: Hi Sebastian, + int nToSend; Integer type is wrong. Yes, just what the original refill_transmitter uses and expects: nToSend is passed as return value to rtems_refill_transmitter, which also returns it to its caller as an int... Ok, rtems_termios_ref

Re: Console driver that needs extra TIMER

2014-08-14 Thread Joel Sherrill
On 8/14/2014 9:20 AM, Gedare Bloom wrote: > On Thu, Aug 14, 2014 at 10:15 AM, Joel Sherrill > wrote: >> On 8/14/2014 9:11 AM, Kolja Waschk wrote: >>> Hi, >>> >>> I'm developing a DMA-based UART driver for Blackfin. It requires an >>> extra timer to trigger data processing after a transmission end

Re: Console driver that needs extra TIMER

2014-08-14 Thread Gedare Bloom
On Thu, Aug 14, 2014 at 10:21 AM, Sebastian Huber wrote: > On 14/08/14 16:15, Joel Sherrill wrote: >>> >>> E.g. most of the tests won't even start without modifications. So >>> >effectively I have to fall back to a polling driver for console if I >>> >want to run the tests unmodified, or is there

Re: Console driver that needs extra TIMER

2014-08-14 Thread Joel Sherrill
On 8/14/2014 9:21 AM, Sebastian Huber wrote: > On 14/08/14 16:15, Joel Sherrill wrote: >>> E.g. most of the tests won't even start without modifications. So effectively I have to fall back to a polling driver for console if I want to run the tests unmodified, or is there any mechanism to

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Renamed startXmit(), nToSend is unsigned, just check FL_ORCVXOF, no (void) cast anymore, compute nToSend in single if/else if/else. --- cpukit/libcsupport/src/termios.c | 135 --- 1 file changed, 85 insertions(+), 50 deletions(-) diff --git a/cpukit/libcsupp

Re: Console driver that needs extra TIMER

2014-08-14 Thread Kolja Waschk
[...] DMA-based UART driver for Blackfin. It requires an extra timer to trigger data processing after a transmission ended. [...] Don't you get an end of DMA TX interrupt? No, it's about RX - the driver doesn't know beforehand how many bytes are expected and thus can configure DMA only to co

Re: Console driver that needs extra TIMER

2014-08-14 Thread Kolja Waschk
If you are working with rtems.git, you could probably just add another BSP setting in confdefs.h for this and push the patch out for Thanks for that hint. There already seems to be such mechanism in place for SHARED_MEMORY_DRIVER: confdefs.h ... rtems_api_configuration_table Configuration_RTEM

Re: Console driver that needs extra TIMER

2014-08-14 Thread Joel Sherrill
On 8/14/2014 12:02 PM, Kolja Waschk wrote: >>> If you are working with rtems.git, you could probably just add another >>> BSP setting in confdefs.h for this and push the patch out for > Thanks for that hint. There already seems to be such mechanism in place for > SHARED_MEMORY_DRIVER: Glad you h

Re: Console driver that needs extra TIMER

2014-08-14 Thread Gedare Bloom
Joel, A problem with the approach you outlined is as Sebastian said, you still end up overestimating if for example the application does not use the DMA-based console but uses a different console within the same bsp. -Gedare On Thu, Aug 14, 2014 at 1:08 PM, Joel Sherrill wrote: > > On 8/14/2014

Re: Console driver that needs extra TIMER

2014-08-14 Thread Joel Sherrill
On 8/14/2014 12:13 PM, Gedare Bloom wrote: > Joel, > > A problem with the approach you outlined is as Sebastian said, you > still end up overestimating if for example the application does not > use the DMA-based console but uses a different console within the same > bsp. That is true but the bspop