Hi Sebastian,
+ int nToSend;
Integer type is wrong.
Yes, just what the original refill_transmitter uses and expects: nToSend
is passed as return value to rtems_refill_transmitter, which also
returns it to its caller as an int...
+ (void)rtems_termios_start_xmit (tty, tty->rawOutBuf.Tail, false);
Please don't use this (void).
Only one of the two callers (rtems_refill_transmitter) is interested in
that information. Is it preferred to omit the "(void)" in the other or
rather do not pass the info as a return value, but e.g. into a variable
pointed to by a further argument?
http://stackoverflow.com/questions/11888594/ignoring-return-values-in-c
Thanks,
Kolja
--
mr.k.waschk - ixo.de - hamburg, germany
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
