Re: [PATCH] RSB: Fetch recent version of newlib that solves or1knd build failure.

2015-03-09 Thread Chris Johns
On 10/03/2015 2:05 am, Hesham ALMatary wrote: On Mon, Mar 9, 2015 at 2:45 PM, Gedare Bloom wrote: On Sun, Mar 8, 2015 at 5:46 PM, Chris Johns wrote: On 6/03/2015 1:23 am, Hesham ALMatary wrote: --- rtems/config/tools/rtems-gcc-4.8.3-newlib-git-1.cfg | 2 +- 1 file changed, 1 insertion(

RFC: Moving or removing some m68k .h files

2015-03-09 Thread Joel Sherrill
Hi I am trying to clean up some .h files which have irritated me a long time. I am looking at these: score/cpu/m68k/rtems/m68k/qsm.h score/cpu/m68k/rtems/m68k/sim.h score/cpu/m68k/rtems/m68k/m68302.h score/cpu/m68k/rtems/m68k/m68360.h qsm.h - only used by mrm332 BSP, move to it sim.h - only used

[PATCH 2/3] Remove unused cpukit/libcsupport/include/zilog/z8536.h

2015-03-09 Thread Joel Sherrill
--- cpukit/libcsupport/Makefile.am | 8 --- cpukit/libcsupport/include/zilog/z8536.h | 110 --- cpukit/libcsupport/preinstall.am | 4 -- 3 files changed, 122 deletions(-) delete mode 100644 cpukit/libcsupport/include/zilog/z8536.h diff --git a/cp

[PATCH 3/3] Move contents of libcsupport/include/zilog into libbsp/shared

2015-03-09 Thread Joel Sherrill
Only a few BSPs use this and it should not have been in libcsupport. --- c/src/lib/libbsp/m68k/mvme136/Makefile.am | 4 + c/src/lib/libbsp/m68k/mvme136/preinstall.am | 9 +++ c/src/lib/libbsp/m68k/mvme147/Makefile.am | 4 + c/src/lib/libbsp/m68k/mvme147/preinstall.am | 9 +++ c

[PATCH 1/3] Move libcsupport/include/motorola/*.h to m68k/idp BSP

2015-03-09 Thread Joel Sherrill
These header files were only used by one BSP and they are hardware dependent. The hardware dependency always made them bad candidates for where they were in the tree. But this fixes that. --- c/src/lib/libbsp/m68k/idp/Makefile.am | 5 + .../lib/libbsp/m68k/idp/include/motorola/mc682

Re: [PATCH 11/15] lpc1768_mbed.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Joel Sherrill
On March 9, 2015 2:38:19 PM CDT, "Marcos Díaz" wrote: >Thanks for the answer! > >I can see that we shouldn't have any asserts in the code, we are >submitting some changes and drivers for the lpc1768 soon and will try >to delete all the asserts in that code. I think the rtems assert is ok since

Re: [PATCH 11/15] lpc1768_mbed.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Marcos Díaz
Thanks for the answer! I can see that we shouldn't have any asserts in the code, we are submitting some changes and drivers for the lpc1768 soon and will try to delete all the asserts in that code. Thanks again! On Mon, Mar 9, 2015 at 4:31 PM, Joel Sherrill wrote: > > > On March 9, 2015 2:25:29

Re: [PATCH 11/15] lpc1768_mbed.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Joel Sherrill
On March 9, 2015 2:25:29 PM CDT, "Marcos Díaz" wrote: >Hi! > >I wanted to know which warning this raised, and how is the correct way >to set this flag in production code? First, there should be no assert's in cpukit so those there should be fixed. I think the same applies for BSPs. It trippe

Re: Fwd: [PATCH 000/111] GRLIB/LEON RTEMS RCC patches

2015-03-09 Thread Amar Takhar
On 2015-03-09 14:23 -0400, Gedare Bloom wrote: > We are close to branching 4.11, but I think there may be value in > merging the patch set for 4.11. Would it be acceptable to all if we I would be against this. The patch is too large to land just before we cut 4.11. With the new waf build syste

Re: [PATCH 11/15] lpc1768_mbed.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Marcos Díaz
Hi! I wanted to know which warning this raised, and how is the correct way to set this flag in production code? Thanks! On Mon, Mar 9, 2015 at 2:38 PM, Joel Sherrill wrote: > --- > c/src/lib/libbsp/arm/lpc176x/make/custom/lpc1768_mbed.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Serious Doxygen Warnings

2015-03-09 Thread Joel Sherrill
Hi Most Doxygen warnings indicate we haven't documented something yet but the following indicate something is structurally wrong with the markup or ifdef's. It would be appreciated if these could be addressed. If no patch shows up shortly, I will file individual PRs on each file: /data/docs/build

Fwd: [PATCH 000/111] GRLIB/LEON RTEMS RCC patches

2015-03-09 Thread Gedare Bloom
On Fri, Feb 27, 2015 at 3:42 AM, Daniel Hellstrom wrote: > On 02/26/2015 05:58 PM, Gedare Bloom wrote: >> >> On Thu, Feb 26, 2015 at 11:38 AM, Daniel Hellstrom >> wrote: >>> >>> Hi, >>> >>> I have rebased and tested briefly the RTEMS code that we have used on >>> LEON2/3/4 >>> on RTEMS-4.10 durin

[PATCH 15/15] cpukit/libcrypt/misc.c: Conditionally correct 16-bit unclean code

2015-03-09 Thread Joel Sherrill
--- cpukit/libcrypt/misc.c | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/libcrypt/misc.c b/cpukit/libcrypt/misc.c index 9f2c13e..9ca26d4 100644 --- a/cpukit/libcrypt/misc.c +++ b/cpukit/libcrypt/misc.c @@ -52,7 +52,11 @@ b64_from_24bit(uint8_t B2, uint8_t B1, uint8_t B0, int n, i

[PATCH 14/15] cpukit/libdl/rtl-mdreloc-m32r.c: Add parentheses per Chris' suggestion

2015-03-09 Thread Joel Sherrill
--- cpukit/libdl/rtl-mdreloc-m32r.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libdl/rtl-mdreloc-m32r.c b/cpukit/libdl/rtl-mdreloc-m32r.c index de32f06..265e9cb 100644 --- a/cpukit/libdl/rtl-mdreloc-m32r.c +++ b/cpukit/libdl/rtl-mdreloc-m32r.c @@ -69,7 +69,7 @@ rtem

[PATCH 13/15] libcpu/powerpc/mpc8260/console-generic/console-generic.c: Include bsp.h to fix warning

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libcpu/powerpc/mpc8260/console-generic/console-generic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/c/src/lib/libcpu/powerpc/mpc8260/console-generic/console-generic.c b/c/src/lib/libcpu/powerpc/mpc8260/console-generic/console-generic.c index 03fd7bf..e325

[PATCH 12/15] rtl22xx.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx.cfg b/c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx.cfg index 7ab08a7..f213d0c 100644 --- a/c/src/lib/libbsp/arm/rtl22xx

[PATCH 11/15] lpc1768_mbed.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/arm/lpc176x/make/custom/lpc1768_mbed.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/arm/lpc176x/make/custom/lpc1768_mbed.cfg b/c/src/lib/libbsp/arm/lpc176x/make/custom/lpc1768_mbed.cfg index 4cf24c8..a5ed9c6 100644 --- a/c/src/lib/lib

[PATCH 10/15] mvme136.cfg: Remove -DNDEBUG flag

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/m68k/mvme136/make/custom/mvme136.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/m68k/mvme136/make/custom/mvme136.cfg b/c/src/lib/libbsp/m68k/mvme136/make/custom/mvme136.cfg index 2f63f04..c90a7a3 100644 --- a/c/src/lib/libbsp/m68k/mvm

[PATCH 08/15] or1k/rtems/score/cpu.h: Add no_return attribute to _CPU_Context_restore

2015-03-09 Thread Joel Sherrill
--- cpukit/score/cpu/or1k/rtems/score/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/or1k/rtems/score/cpu.h b/cpukit/score/cpu/or1k/rtems/score/cpu.h index d7b7093..c7d7f46 100644 --- a/cpukit/score/cpu/or1k/rtems/score/cpu.h +++ b/cpukit/score/cpu/or1k

[PATCH 09/15] vprintk.c: Reorder switch and add default to eliminate warning

2015-03-09 Thread Joel Sherrill
--- cpukit/libcsupport/src/vprintk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cpukit/libcsupport/src/vprintk.c b/cpukit/libcsupport/src/vprintk.c index 68c7556..51e4947 100644 --- a/cpukit/libcsupport/src/vprintk.c +++ b/cpukit/libcsupport/src/vprintk.c @@ -158,

[PATCH 07/15] tools/cpu/sh/sci.c: Add include of bsp.h to generated file

2015-03-09 Thread Joel Sherrill
--- tools/cpu/sh/sci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/cpu/sh/sci.c b/tools/cpu/sh/sci.c index bc7fdd8..a092bce 100644 --- a/tools/cpu/sh/sci.c +++ b/tools/cpu/sh/sci.c @@ -117,6 +117,7 @@ int shgen_gensci( " * Hitachi's HW manual recommends bitrates with an error

[PATCH 06/15] cpukit/score/cpu/sh/context.c: Correct name of _CPU_Context_switch

2015-03-09 Thread Joel Sherrill
--- cpukit/score/cpu/sh/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/sh/context.c b/cpukit/score/cpu/sh/context.c index bd40f20..dfa12c3 100644 --- a/cpukit/score/cpu/sh/context.c +++ b/cpukit/score/cpu/sh/context.c @@ -168,7 +168,7 @@ asm volatile

[PATCH 05/15] or1k: Correct _CPU_Thread_Idle_body prototype

2015-03-09 Thread Joel Sherrill
--- cpukit/score/cpu/or1k/cpu.c | 2 +- cpukit/score/cpu/or1k/rtems/score/cpu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/score/cpu/or1k/cpu.c b/cpukit/score/cpu/or1k/cpu.c index c81aa1e..cd89f55 100644 --- a/cpukit/score/cpu/or1k/cpu.c +++ b/cpukit/

[PATCH 04/15] gensh1/include/bsp.h: Add needed prototype

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/sh/gensh1/include/bsp.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/c/src/lib/libbsp/sh/gensh1/include/bsp.h b/c/src/lib/libbsp/sh/gensh1/include/bsp.h index ced4967..0b023eb 100644 --- a/c/src/lib/libbsp/sh/gensh1/include/bsp.h +++ b/c/src/lib/libbsp/sh/gensh1

[PATCH 03/15] gensh4/include/bsp.h: Remove unused prototype and include

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/sh/gensh4/include/bsp.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/c/src/lib/libbsp/sh/gensh4/include/bsp.h b/c/src/lib/libbsp/sh/gensh4/include/bsp.h index e9d39a9..85f8f1a 100644 --- a/c/src/lib/libbsp/sh/gensh4/include/bsp.h +++ b/c/src/lib/libbsp/sh/gensh4/i

[PATCH 02/15] powerpc/shared/bootloader/pci.c: Remove warnings

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/powerpc/shared/bootloader/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/shared/bootloader/pci.c b/c/src/lib/libbsp/powerpc/shared/bootloader/pci.c index 59bf862..0c9472e 100644 --- a/c/src/lib/libbsp/powerpc/shared/boot

[PATCH 01/15] shared/include/grcan.h: Add prototypes to fix warnings

2015-03-09 Thread Joel Sherrill
--- c/src/lib/libbsp/sparc/shared/include/grcan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/sparc/shared/include/grcan.h b/c/src/lib/libbsp/sparc/shared/include/grcan.h index e76dee7..9f01455 100644 --- a/c/src/lib/libbsp/sparc/shared/include/grcan.h +

[PATCH 00/15] Warning Removal Patch Series

2015-03-09 Thread Joel Sherrill
Hi This series of patches includes two I posted over the weekend. Most are pretty obvious changes to fix warnings or minor issues I spotted while removing warnings. Again, the warning removal pass does not have tests or networking enabled. We have about 30 printf() format warnings which may be

Re: New source layout.

2015-03-09 Thread Amar Takhar
On 2015-03-09 14:18 +0100, Sebastian Huber wrote: > This is actually a big problem and will break a lot of thinks. Currently > you use > > #include > > and get for example RTEMS_BSP_NETWORK_DRIVER_ATTACH for the network > configuration. > > You find the via the -B compiler switch. This will

Re: [PATCH] RSB: Fetch recent version of newlib that solves or1knd build failure.

2015-03-09 Thread Hesham ALMatary
On Mon, Mar 9, 2015 at 2:45 PM, Gedare Bloom wrote: > On Sun, Mar 8, 2015 at 5:46 PM, Chris Johns wrote: >> On 6/03/2015 1:23 am, Hesham ALMatary wrote: >>> >>> --- >>> rtems/config/tools/rtems-gcc-4.8.3-newlib-git-1.cfg | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --

Re: [PATCH 1/5] score: Add rtems_set_errno_and_return_value()

2015-03-09 Thread Gedare Bloom
Does it make sense to provide rtems_set_errno_and_return_cast_value(_error, _cast_type, _value)...and replace the other two macros in seterr.h? On Mon, Mar 9, 2015 at 8:18 AM, Sebastian Huber wrote: > --- > cpukit/score/include/rtems/seterr.h | 10 ++ > 1 file changed, 10 insertions(+) >

Re: New source layout.

2015-03-09 Thread Sebastian Huber
On 09/03/15 02:42, Amar Takhar wrote: > >include/arch/- Private architecture specific > >include/bsp/ - Common BSP files > >include/bsp/ - Architecture specific > >Does this mean all references are explicit and not using compiler >include path tricks ? Yes, 100% of include p

[PATCH 3/3] Use latest from FreeBSD for RTEMS

2015-03-09 Thread Sebastian Huber
Import the latest from FreeBSD and adjust it for RTEMS. The OpenMP support from GCC (libgomp) needs a . --- newlib/libc/sys/rtems/include/semaphore.h | 58 +++ 1 file changed, 58 insertions(+) create mode 100644 newlib/libc/sys/rtems/include/semaphore.h diff --git a/

[PATCH 1/3] Add and use latest from FreeBSD

2015-03-09 Thread Sebastian Huber
This addresses a potential multiple definition problem and makes it easier to use FreeBSD header files in Newlib. newlib/ChangeLog 2015-03-09 Sebastian Huber * libc/include/sys/_timespec.h: Import from FreeBSD. * libc/include/sys/timespec.h: Likewise. * libc/include/sys

[PATCH 2/3] Use latest from FreeBSD for RTEMS

2015-03-09 Thread Sebastian Huber
Import the latest from FreeBSD for RTEMS. This has two reasons. 1. We want to use the FreeBSD timecounters for timekeeping in RTEMS. See also https://devel.rtems.org/ticket/2271. 2. This makes the port of the network stack from FreeBSD easier. newlib/ChangeLog 2015-03-09 Sebastian Huber

Re: [PATCH 2/5] posix: Change sem_t to the 32-bit object type

2015-03-09 Thread Joel Sherrill
Object ides are not always 32 bits On March 9, 2015 7:18:33 AM CDT, Sebastian Huber wrote: >--- > cpukit/posix/include/semaphore.h | 2 +- > cpukit/posix/src/semopen.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cpukit/posix/include/semaphore.h >b/cpukit/posix/

[PATCH 4/5] posix: Install only if not provided

2015-03-09 Thread Sebastian Huber
--- cpukit/configure.ac| 3 +++ cpukit/posix/Makefile.am | 2 ++ cpukit/posix/preinstall.am | 3 ++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cpukit/configure.ac b/cpukit/configure.ac index 2b16964..0058082 100644 --- a/cpukit/configure.ac +++ b/cpukit/configure.ac @

[PATCH 3/5] posix: Use SEM_FAILED in sem_open()

2015-03-09 Thread Sebastian Huber
Use a value of 0 (standard NULL pointer) for SEM_FAILED to be in line with FreeBSD. --- cpukit/posix/include/semaphore.h | 2 +- cpukit/posix/src/semopen.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/posix/include/semaphore.h b/cpukit/posix/include/semapho

[PATCH 1/5] score: Add rtems_set_errno_and_return_value()

2015-03-09 Thread Sebastian Huber
--- cpukit/score/include/rtems/seterr.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/cpukit/score/include/rtems/seterr.h b/cpukit/score/include/rtems/seterr.h index 1e9e0d0..a3a977d 100644 --- a/cpukit/score/include/rtems/seterr.h +++ b/cpukit/score/include/rtems/seterr.h @@ -5

[PATCH 5/5] libcsupport: Delete superfluous _gettimeofday()

2015-03-09 Thread Sebastian Huber
--- cpukit/libcsupport/src/__gettod.c | 16 testsuites/psxtests/psxtime/test.c | 7 --- 2 files changed, 23 deletions(-) diff --git a/cpukit/libcsupport/src/__gettod.c b/cpukit/libcsupport/src/__gettod.c index 0b1ea97..b0b60de 100644 --- a/cpukit/libcsupport/src/__gettod.c

[PATCH 2/5] posix: Change sem_t to the 32-bit object type

2015-03-09 Thread Sebastian Huber
--- cpukit/posix/include/semaphore.h | 2 +- cpukit/posix/src/semopen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/posix/include/semaphore.h b/cpukit/posix/include/semaphore.h index b22453d..58b77e7 100644 --- a/cpukit/posix/include/semaphore.h +++ b/cpukit

Re: GSoC 2015 Introduction - Condition Variables (CV)

2015-03-09 Thread Andrei - Constantin Popescu
Hello! As discussed with Sebastian Huber on IRC , is there someone else able/willing to mentor this project or should I look for a different one ? Kind regards, Andrei 2015-03-09 8:51 GMT+02:00 Andrei - Constantin Popescu < popescu.andrei1...@gmail.com>: > Hello! > > I'm Andrei(Andrei - Constan