Re: MPC55xx Warning for Undefined Behavior

On 13/10/14 18:05, Joel Sherrill wrote: Hi I noticed this going over the logs and wanted help resolving it. 5 c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c:170:27: warning: iteration 474ul invokes undefined behavior [-Waggressive-loop-optimizations] $ grep "undefined be" log/* log/powerpc

Re: Batch of Patches from Joel

On 13/10/14 17:48, Joel Sherrill wrote: On 10/13/2014 10:43 AM, Sebastian Huber wrote: On 10/13/2014 05:18 PM, Joel Sherrill wrote: NOTE: For defaults for weak symbols, I am just adding a prototype to the C file. How do you then ensure that a non-weak implementation has the same signature?

Re: main_lsof.c Warning

On 13/10/14 18:33, Joel Sherrill wrote: Is this fixed once we get to tools with your new long long checking in newlib? No, this is a bug for all 32-bit targets with uintptr_t != unsigned int. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone

Re: __assert.c Wpointer-to-int-cast

On 14/10/14 04:21, Gedare Bloom wrote: cpukit/libcsupport/src/__assert.c52:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] rtems_fatal( RTEMS_FATAL_SOURCE_ASSERT, (rtems_fatal_code) &assert_context ); This code casts the address of assert_control into an

Re: [PATCH] rfs: explicitly cast to dev_t

This fixes a warning about conversion to int without a cast. On Tue, Oct 14, 2014 at 12:04 AM, Gedare Bloom wrote: > --- > cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems.c > b/cpukit/libfs/src/

[PATCH] rfs: explicitly cast to dev_t

--- cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems.c b/cpukit/libfs/src/rfs/rtems-rfs-rtems.c index ec9dd2c..6cefe9d 100644 --- a/cpukit/libfs/src/rfs/rtems-rfs-rtems.c +++ b/cpukit/libfs/src/rfs/rtem

Re: [PATCH] rfs: fix pointer conversion warnings

On Mon, Oct 13, 2014 at 10:54 PM, Joel Sherrill wrote: > > > On October 13, 2014 9:46:50 PM CDT, Gedare Bloom wrote: >>--- >> cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >>diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c >>b/cpu

Re: [PATCH] rfs: fix pointer conversion warnings

On October 13, 2014 9:46:50 PM CDT, Gedare Bloom wrote: >--- > cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c >b/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c >index 28e4739..48a6737 10

[PATCH] rfs: fix pointer conversion warnings

--- cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c b/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c index 28e4739..48a6737 100644 --- a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c +++ b/cpuki

Re: __assert.c Wpointer-to-int-cast

On October 13, 2014 9:21:26 PM CDT, Gedare Bloom wrote: >Hi, >cpukit/libcsupport/src/__assert.c52:43: >warning: cast from pointer to integer of different size >[-Wpointer-to-int-cast] >rtems_fatal( RTEMS_FATAL_SOURCE_ASSERT, (rtems_fatal_code) >&assert_context ); > >This code casts the address o

__assert.c Wpointer-to-int-cast

Hi, cpukit/libcsupport/src/__assert.c52:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] rtems_fatal( RTEMS_FATAL_SOURCE_ASSERT, (rtems_fatal_code) &assert_context ); This code casts the address of assert_control into an rtems_fatal_code, which is uint32_t. I

powerpc/mbx8xx warning removal request

Hi I need help getting the warnings out of the powerpc/mbx8xx family. This is the current count per BSP variant. 27 powerpc-mbx821_001 27 powerpc-mbx821_002 27 powerpc-mbx821_002b 27 powerpc-mbx860_001b 27 powerpc-mbx860_002 27 powerpc-mbx860_1b 31 powerpc-mbx860_005b Please and thanks. -- Joe

sparc64 warnings fixed

Hi, I have pushed some commits to fix sparc64-specific warnings. The remaining warnings that are only seen on sparc64 builds are caused by 64-bit problems mostly related to integer/pointer conversions. I don't have the time to hunt all these down myself. Most of them are in jffs2, capture, or shel

Re: MPC55xx Warning for Undefined Behavior

Following up on Gedare's comment. I am fighting warnings and there was one buried in the mass which we need help running down. Peter has found an inconsistency in the Freescale documentation which is reflected in the code which in turn causes the warning in the code. Read the thread below and help

Re: MPC55xx Warning for Undefined Behavior

On Oct 13, 2014, at 16:00 , Joel Sherrill wrote: > > On 10/13/2014 2:56 PM, Peter Dufault wrote: >> On Oct 13, 2014, at 15:22 , Peter Dufault wrote: >> >>> This looks like an issue in the header. I downloaded the MPC5674F >>> Reference Manual and it does specify 479 interrupt request source

Re: MPC55xx Warning for Undefined Behavior

On 10/13/2014 2:56 PM, Peter Dufault wrote: > On Oct 13, 2014, at 15:22 , Peter Dufault wrote: > >> This looks like an issue in the header. I downloaded the MPC5674F Reference >> Manual and it does specify 479 interrupt request sources. See table 9-2, >> INTC Memory Map >> >> Base + (0x0040–0

Re: MPC55xx Warning for Undefined Behavior

On Oct 13, 2014, at 15:22 , Peter Dufault wrote: > This looks like an issue in the header. I downloaded the MPC5674F Reference > Manual and it does specify 479 interrupt request sources. See table 9-2, > INTC Memory Map > > Base + (0x0040–0x0219) INTC_PSRn—INTC priority select registers 2

Re: [PATCH] sparc/leon2: Fix warnings

Ignore this. It is already merged. I found it on a branch on another machine and thought I hadn't moved it to the build machine I was working patches from. --joel On 10/13/2014 2:25 PM, Joel Sherrill wrote: > --- > c/src/lib/libbsp/sparc/leon2/cchip/cchip.c | 13 +--- > c/src/lib/li

Re: MPC55xx Warning for Undefined Behavior

On Oct 13, 2014, at 13:07 , Peter Dufault wrote: > but the upper limit of loop is #defined to 479: > > #if MPC55XX_CHIP_FAMILY == 555 >#define MPC55XX_IRQ_MAX 307U > #elif MPC55XX_CHIP_FAMILY == 556 >#define MPC55XX_IRQ_MAX 360U > #elif MPC55XX_CHIP_FAMILY == 567 >#define MPC55XX

Re: [PATCH 2/2] libbsp/or1ksim: Fix warnings.

OK. When my build finishes, I will commit this unless someone beats me to it. --joel On 10/13/2014 1:30 PM, Hesham Moustafa wrote: > > > On Mon, Oct 13, 2014 at 8:24 PM, Joel Sherrill > mailto:joel.sherr...@oarcorp.com>> wrote: > > > On 10/13/2014 1:06 PM, Hesham Moustafa wrote: >> Please

Re: [PATCH 2/2] libbsp/or1ksim: Fix warnings.

On Mon, Oct 13, 2014 at 8:24 PM, Joel Sherrill wrote: > > On 10/13/2014 1:06 PM, Hesham Moustafa wrote: > > Please have a look at this patch. > > On Fri, Oct 10, 2014 at 6:45 PM, Hesham ALMatary > wrote: > >> --- >> c/src/lib/libbsp/or1k/or1ksim/clock/clockdrv.c | 2 +- >> c/src/lib/libbsp/or1

Re: [PATCH 2/2] libbsp/or1ksim: Fix warnings.

On 10/13/2014 1:06 PM, Hesham Moustafa wrote: > Please have a look at this patch. > > On Fri, Oct 10, 2014 at 6:45 PM, Hesham ALMatary > mailto:heshamelmat...@gmail.com>> wrote: > > --- > c/src/lib/libbsp/or1k/or1ksim/clock/clockdrv.c | 2 +- > c/src/lib/libbsp/or1k/or1ksim/console/u

Re: Warnings Report 13 Oct

Hi, Thanks for providing these results. or1ksim related warnings should be greatly decreased after the latest two patches I submitted. Regards, Hesham On Mon, Oct 13, 2014 at 6:50 PM, Joel Sherrill wrote: > Hi > > Attached is the set of unique warnings and list of warnings > count per BSP afte

Re: [PATCH 2/2] libbsp/or1ksim: Fix warnings.

Please have a look at this patch. On Fri, Oct 10, 2014 at 6:45 PM, Hesham ALMatary wrote: > --- > c/src/lib/libbsp/or1k/or1ksim/clock/clockdrv.c | 2 +- > c/src/lib/libbsp/or1k/or1ksim/console/uart.c | 15 +++ > 2 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/c

Re: [PATCH 1/2] libcpu/or1k: Fix warnings.

On Mon, Oct 13, 2014 at 7:03 PM, Joel Sherrill wrote: > > On 10/13/2014 11:45 AM, Hesham Moustafa wrote: > > Missed patch? > > Yep. Committed now. This should address a bunch of the or1ksim > build warnings. I fixed another in console/uart.c for an unused > variable. > > Thanks. There is another

Re: MPC55xx Warning for Undefined Behavior

On Oct 13, 2014, at 12:05 , Joel Sherrill wrote: > Hi > > I noticed this going over the logs and wanted help resolving it. > > 5 c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c:170:27: warning: > iteration 474ul invokes undefined behavior [-Waggressive-loop-optimizations] > > $ grep "undefined

Re: [PATCH 1/2] libcpu/or1k: Fix warnings.

On 10/13/2014 11:45 AM, Hesham Moustafa wrote: > Missed patch? > Yep. Committed now. This should address a bunch of the or1ksim build warnings. I fixed another in console/uart.c for an unused variable. Starting another build of all BSPs to see if I fixed all "-Wunused-variables" cases. Thanks. >

Warnings Report 13 Oct

Hi Attached is the set of unique warnings and list of warnings count per BSP after committing all my patches. This is with tests=samples and networking disabled. On 6 Oct, there were 1737 unique warnings. Today, there are 759 unique warnings. The warnings break down in categories like this:

Re: [PATCH 1/2] libcpu/or1k: Fix warnings.

Missed patch? On Fri, Oct 10, 2014 at 7:23 PM, Hesham ALMatary wrote: > --- > c/src/lib/libcpu/or1k/shared/cache/cache.c | 16 > c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 + > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/c/src/lib/libcpu/or1k/shared

main_lsof.c Warning

Hi Is this fixed once we get to tools with your new long long checking in newlib? $ grep main_lsof.c warnings-20141013a.txt 78 c/src/../../cpukit/libmisc/shell/main_lsof.c:66:7: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wforma

MPC55xx Warning for Undefined Behavior

Hi I noticed this going over the logs and wanted help resolving it. 5 c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c:170:27: warning: iteration 474ul invokes undefined behavior [-Waggressive-loop-optimizations] $ grep "undefined be" log/* log/powerpc-mpc5674f_ecu508_app.log:../../../../../../

Noting C Methods Called from .S Re: Batch of Patches from Joel

On 10/13/2014 10:51 AM, Gedare Bloom wrote: > On Mon, Oct 13, 2014 at 11:18 AM, Joel Sherrill > wrote: >> On 10/13/2014 9:48 AM, Gedare Bloom wrote: >>> These 23 look good to me. -Gedare >> Thanks. I know this many patches is a real pain but it >> is unfortunately needed to get the warning count

Re: Batch of Patches from Joel

On Mon, Oct 13, 2014 at 11:18 AM, Joel Sherrill wrote: > > On 10/13/2014 9:48 AM, Gedare Bloom wrote: >> These 23 look good to me. -Gedare > Thanks. I know this many patches is a real pain but it > is unfortunately needed to get the warning count down. > > The unique warning count has dropped from

Re: Batch of Patches from Joel

On 10/13/2014 10:43 AM, Sebastian Huber wrote: > On 10/13/2014 05:18 PM, Joel Sherrill wrote: >> NOTE: For defaults for weak symbols, I am just adding >> a prototype to the C file. > How do you then ensure that a non-weak implementation has the same > signature? > Don't ask me. I didn't add any o

Re: Batch of Patches from Joel

On 10/13/2014 05:18 PM, Joel Sherrill wrote: NOTE: For defaults for weak symbols, I am just adding a prototype to the C file. How do you then ensure that a non-weak implementation has the same signature? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Ger

[PATCH 51/54] libbsp/shared/umon: Fix warnings

--- c/src/lib/libbsp/shared/umon/monlib.c| 27 +++ c/src/lib/libbsp/shared/umon/tfsDriver.c | 4 ++-- c/src/lib/libbsp/shared/umon/umon.h | 11 ++- 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/c/src/lib/libbsp/shared/umon/monlib.c b/c/s

[PATCH 53/54] mips/gdbstub: Fix warnings

--- c/src/lib/libbsp/mips/shared/gdbstub/mips-stub.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/mips/shared/gdbstub/mips-stub.c b/c/src/lib/libbsp/mips/shared/gdbstub/mips-stub.c index 8f7278c..8451ce8 100644 --- a/c/src/lib/libbsp/mips/shared/gdbs

[PATCH 52/54] mips/genmongoosev: Fix warnings

--- .../lib/libbsp/mips/genmongoosev/console/conscfg.c | 5 ++- .../lib/libbsp/mips/genmongoosev/console/mg5uart.c | 46 +++--- .../lib/libbsp/mips/genmongoosev/console/mg5uart.h | 5 +-- c/src/lib/libbsp/mips/genmongoosev/include/bsp.h | 6 +++ .../libbsp/mips/genmongoosev/st

[PATCH 54/54] libcpu/i386/cache.c: Fix warnings

--- c/src/lib/libcpu/i386/cache.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libcpu/i386/cache.c b/c/src/lib/libcpu/i386/cache.c index 9e51a4c..66657ab 100644 --- a/c/src/lib/libcpu/i386/cache.c +++ b/c/src/lib/libcpu/i386/cache.c @@ -5,8 +5,10 @@ #includ

[PATCH 43/54] libcpu/sh/sh7032/clock/ckinit.c: Fix warnings

--- c/src/lib/libcpu/sh/sh7032/clock/ckinit.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git a/c/src/lib/libcpu/sh/sh7032/clock/ckinit.c b/c/src/lib/libcpu/sh/sh7032/clock/ckinit.c index d7fba00..6faaf27 100644 --- a/c/src/lib/libcpu/sh/sh7032/c

[PATCH 40/54] libcpu/arm/pxa255/clock/clock.c: Fix warnings

--- c/src/lib/libcpu/arm/pxa255/clock/clock.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/c/src/lib/libcpu/arm/pxa255/clock/clock.c b/c/src/lib/libcpu/arm/pxa255/clock/clock.c index 6d61b67..92d9b21 100644 --- a/c/src/lib/libcpu/arm/pxa255/c

[PATCH 45/54] libcpu/sh/sh7750/clock/ckinit.c: Fix warnings

--- c/src/lib/libcpu/sh/sh7750/clock/ckinit.c | 338 +- 1 file changed, 151 insertions(+), 187 deletions(-) diff --git a/c/src/lib/libcpu/sh/sh7750/clock/ckinit.c b/c/src/lib/libcpu/sh/sh7750/clock/ckinit.c index 5976e87..795203d 100644 --- a/c/src/lib/libcpu/sh/sh775

[PATCH 39/54] libcpu/arm/mc9328mxl/clock/clockdrv.c: Fix warnings

--- c/src/lib/libcpu/arm/mc9328mxl/clock/clockdrv.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/c/src/lib/libcpu/arm/mc9328mxl/clock/clockdrv.c b/c/src/lib/libcpu/arm/mc9328mxl/clock/clockdrv.c index d814d38..0c3ab5d 100644 --- a/c/src/lib/libcpu/arm

[PATCH 50/54] m68k/mcf5225x: Fix warnings

--- c/src/lib/libbsp/m68k/mcf5225x/console/console.c | 2 +- c/src/lib/libbsp/m68k/mcf5225x/startup/init5225x.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mcf5225x/console/console.c b/c/src/lib/libbsp/m68k/mcf5225x/console/console.c index d094ae

[PATCH 41/54] libcpu/arm/s3c24xx/clock/clockdrv.c: Fix warnings

--- c/src/lib/libcpu/arm/s3c24xx/clock/clockdrv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/c/src/lib/libcpu/arm/s3c24xx/clock/clockdrv.c b/c/src/lib/libcpu/arm/s3c24xx/clock/clockdrv.c index 4a32db7..519d3f8 100644 --- a/c/src/lib/libcpu/arm/s3c24xx/clock/clo

[PATCH 47/54] libbsp/i386/shared/comm: Fix warnings

--- c/src/lib/libbsp/i386/shared/comm/i386-stub-glue.c | 6 +++--- c/src/lib/libbsp/i386/shared/comm/i386-stub.c | 4 ++-- c/src/lib/libbsp/i386/shared/comm/uart.c | 4 ++-- c/src/lib/libbsp/i386/shared/comm/uart.h | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-)

[PATCH 44/54] libcpu/sh/sh7045/clock/ckinit.c: Fix warnings

--- c/src/lib/libcpu/sh/sh7045/clock/ckinit.c | 35 ++- 1 file changed, 6 insertions(+), 29 deletions(-) diff --git a/c/src/lib/libcpu/sh/sh7045/clock/ckinit.c b/c/src/lib/libcpu/sh/sh7045/clock/ckinit.c index 3297238..5120b59 100644 --- a/c/src/lib/libcpu/sh/sh7045/c

[PATCH 46/54] libcpu/bfin/clock: Fix warnings

--- c/src/lib/libcpu/bfin/clock/clock.c | 51 - c/src/lib/libcpu/bfin/clock/rtc.c | 22 2 files changed, 21 insertions(+), 52 deletions(-) diff --git a/c/src/lib/libcpu/bfin/clock/clock.c b/c/src/lib/libcpu/bfin/clock/clock.c index 7bd5d34..

[PATCH 49/54] score/cpu/m32c: Fix warnings

--- cpukit/score/cpu/m32c/cpu_asm.c | 7 --- cpukit/score/cpu/m32c/rtems/score/cpu.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cpukit/score/cpu/m32c/cpu_asm.c b/cpukit/score/cpu/m32c/cpu_asm.c index 9515264..f992c57 100644 --- a/cpukit/score/cpu/m32c/cpu_as

[PATCH 33/54] no_cpu/no_bsp/clock/ckinit.c: Remove clock major/minor and clean up

--- c/src/lib/libbsp/no_cpu/no_bsp/clock/ckinit.c | 49 +-- 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/c/src/lib/libbsp/no_cpu/no_bsp/clock/ckinit.c b/c/src/lib/libbsp/no_cpu/no_bsp/clock/ckinit.c index 5badbe1..fbfe541 100644 --- a/c/src/lib/libbsp/no

[PATCH 31/54] powerpc/virtex5/include/bsp.h: Add prototypes to fix warnings

--- c/src/lib/libbsp/powerpc/virtex5/include/bsp.h | 5 + 1 file changed, 5 insertions(+) diff --git a/c/src/lib/libbsp/powerpc/virtex5/include/bsp.h b/c/src/lib/libbsp/powerpc/virtex5/include/bsp.h index 8558faa..c5d2dd9 100644 --- a/c/src/lib/libbsp/powerpc/virtex5/include/bsp.h +++ b/c/sr

[PATCH 29/54] powerpc/psim/include/bsp.h: Add prototypes to fix warnings

--- c/src/lib/libbsp/powerpc/psim/include/bsp.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/psim/include/bsp.h b/c/src/lib/libbsp/powerpc/psim/include/bsp.h index 45c46e0..53822d5 100644 --- a/c/src/lib/libbsp/powerpc/psim/include/bsp

[PATCH 34/54] powerpc/shared/clock/clock.c: Remove clock major/minor and clean up

--- c/src/lib/libbsp/powerpc/shared/clock/clock.c | 311 +- 1 file changed, 158 insertions(+), 153 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/shared/clock/clock.c b/c/src/lib/libbsp/powerpc/shared/clock/clock.c index ed482fa..e9b1d4d 100644 --- a/c/src/lib/libbsp/

[PATCH 26/54] libcpu/m68k/mcf5272/clock/ckinit.c: Fix warnings

--- c/src/lib/libcpu/m68k/mcf5272/clock/ckinit.c | 192 ++- 1 file changed, 68 insertions(+), 124 deletions(-) diff --git a/c/src/lib/libcpu/m68k/mcf5272/clock/ckinit.c b/c/src/lib/libcpu/m68k/mcf5272/clock/ckinit.c index 0a81be7..26c5c90 100644 --- a/c/src/lib/libcpu/m68

[PATCH 28/54] libbsp/lm32/shared: Fix warnings

--- c/src/lib/libbsp/lm32/shared/clock/ckinit.c| 12 +++--- c/src/lib/libbsp/lm32/shared/console/console.c | 52 +++--- 2 files changed, 11 insertions(+), 53 deletions(-) diff --git a/c/src/lib/libbsp/lm32/shared/clock/ckinit.c b/c/src/lib/libbsp/lm32/shared/clock/ckinit.

[PATCH 27/54] libcpu/powerpc/ppc403: Fix warnings

--- c/src/lib/libcpu/powerpc/ppc403/clock/clock.c | 31 +- .../lib/libcpu/powerpc/ppc403/console/console405.c | 3 +-- c/src/lib/libcpu/powerpc/ppc403/tty_drv/tty_drv.c | 18 - 3 files changed, 13 insertions(+), 39 deletions(-) diff --git a/c/src/lib/libcpu/

[PATCH 25/54] libcpu/m68k/mcf5206/clock/ckinit.c: Fix warnings

--- c/src/lib/libcpu/m68k/mcf5206/clock/ckinit.c | 156 +-- 1 file changed, 48 insertions(+), 108 deletions(-) diff --git a/c/src/lib/libcpu/m68k/mcf5206/clock/ckinit.c b/c/src/lib/libcpu/m68k/mcf5206/clock/ckinit.c index e3ff932..c28c541 100644 --- a/c/src/lib/libcpu/m68

[PATCH 24/54] sparc64/shared/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/sparc64/shared/clock/ckinit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/sparc64/shared/clock/ckinit.c b/c/src/lib/libbsp/sparc64/shared/clock/ckinit.c index bbef4f8..dede6d8 100644 --- a/c/src/lib/libbsp/sparc64/shared/clock/ckin

[PATCH 30/54] powerpc/score603e/include/bsp.h: Add prototypes to fix warnings

--- c/src/lib/libbsp/powerpc/score603e/include/bsp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/c/src/lib/libbsp/powerpc/score603e/include/bsp.h b/c/src/lib/libbsp/powerpc/score603e/include/bsp.h index 95b89e4..f6e3c5a 100644 --- a/c/src/lib/libbsp/powerpc/score603e/include/bsp.h +

[PATCH 32/54] m68k/mrm332/clock/ckinit.c: Remove clock major/minor and clean up

--- c/src/lib/libbsp/m68k/mrm332/clock/ckinit.c | 41 +++-- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mrm332/clock/ckinit.c b/c/src/lib/libbsp/m68k/mrm332/clock/ckinit.c index 5c48013..b650275 100644 --- a/c/src/lib/libbsp/m68k/m

[PATCH 36/54] libcsupport/include/clockdrv.h: Remove rtems_clock_major/minor

--- cpukit/libcsupport/include/clockdrv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpukit/libcsupport/include/clockdrv.h b/cpukit/libcsupport/include/clockdrv.h index 985d569..5d7a92c 100644 --- a/cpukit/libcsupport/include/clockdrv.h +++ b/cpukit/libcsupport/include/clockdrv.h @@ -27

[PATCH 23/54] sparc/erc32/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/sparc/erc32/clock/ckinit.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/c/src/lib/libbsp/sparc/erc32/clock/ckinit.c b/c/src/lib/libbsp/sparc/erc32/clock/ckinit.c index 25504f1..2afe770 100644 --- a/c/src/lib/libbsp/sparc/erc32/clock/ckinit.c ++

[PATCH 35/54] arm/gba/console: Fix warnings and clean up

--- c/src/lib/libbsp/arm/gba/console/conio.c | 176 - c/src/lib/libbsp/arm/gba/console/console.c | 75 ++-- 2 files changed, 140 insertions(+), 111 deletions(-) diff --git a/c/src/lib/libbsp/arm/gba/console/conio.c b/c/src/lib/libbsp/arm/gba/console/conio.c

[PATCH 17/54] powerpc/shared/console: Fix warnings

--- c/src/lib/libbsp/powerpc/shared/console/console.c | 4 +++ c/src/lib/libbsp/powerpc/shared/console/uart.c| 35 +++ 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/shared/console/console.c b/c/src/lib/libbsp/powerpc/shared/cons

[PATCH 08/54] gen68302/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/gen68302/clock/ckinit.c | 32 ++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/c/src/lib/libbsp/m68k/gen68302/clock/ckinit.c b/c/src/lib/libbsp/m68k/gen68302/clock/ckinit.c index 8251019..1e4982e 100644 --- a/c/src/lib/libbsp/m68

[PATCH 04/54] i386/pc386: Clean up and fix warnings

--- c/src/lib/libbsp/i386/pc386/clock/ckinit.c| 2 -- c/src/lib/libbsp/i386/pc386/console/inch.c| 10 -- c/src/lib/libbsp/i386/pc386/include/bsp.h | 5 + c/src/lib/libbsp/i386/shared/comm/i386-stub.c | 6 +++--- c/src/lib/libbsp/i386/shared/comm/uart.c | 20

[PATCH 12/54] mvme162/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/mvme162/clock/ckinit.c | 29 ++-- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mvme162/clock/ckinit.c b/c/src/lib/libbsp/m68k/mvme162/clock/ckinit.c index 7e2206e..83a018e 100644 --- a/c/src/lib/libbsp/m68k/

[PATCH 19/54] lm32/lm32_evr/include/bsp.h: Fix warnings

--- c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h b/c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h index 65fcdef..e63e9fe 100644 --- a/c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h +++ b/c/src/lib/libbsp

[PATCH 20/54] lm32/shared/milkymist_clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/lm32/shared/milkymist_clock/ckinit.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/c/src/lib/libbsp/lm32/shared/milkymist_clock/ckinit.c b/c/src/lib/libbsp/lm32/shared/milkymist_clock/ckinit.c index 599c58d..65651e6 100644 --- a/c/src/lib/lib

[PATCH 21/54] nios2/nios2_iss/clock/clock.c: Fix warnings

--- c/src/lib/libbsp/nios2/nios2_iss/clock/clock.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/c/src/lib/libbsp/nios2/nios2_iss/clock/clock.c b/c/src/lib/libbsp/nios2/nios2_iss/clock/clock.c index d5be1fc..939af651 100644 --- a/c/src/lib/libbsp/nios2/nios2_iss/clock

[PATCH 13/54] mvme167/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/mvme167/clock/ckinit.c | 76 +++- 1 file changed, 7 insertions(+), 69 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mvme167/clock/ckinit.c b/c/src/lib/libbsp/m68k/mvme167/clock/ckinit.c index e3d8514..9d6be44 100644 --- a/c/src/lib/libbsp/m68k/

[PATCH 05/54] powerpc/mvme3100/startup/misc.c: Fix warnings

--- c/src/lib/libbsp/powerpc/mvme3100/startup/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/mvme3100/startup/misc.c b/c/src/lib/libbsp/powerpc/mvme3100/startup/misc.c index 6b2b701..3a15397 100644 --- a/c/src/lib/libbsp/powerpc/mvme3100/startu

[PATCH 14/54] ods68302/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/ods68302/clock/ckinit.c | 32 ++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/c/src/lib/libbsp/m68k/ods68302/clock/ckinit.c b/c/src/lib/libbsp/m68k/ods68302/clock/ckinit.c index ac570a0..e0a8074 100644 --- a/c/src/lib/libbsp/m68

[PATCH 03/54] sparc/leon2: Fix warnings

--- c/src/lib/libbsp/sparc/leon2/cchip/cchip.c | 13 ++ c/src/lib/libbsp/sparc/leon2/console/console.c | 8 +++ c/src/lib/libbsp/sparc/leon2/console/debugputs.c | 6 + c/src/lib/libbsp/sparc/leon2/include/bsp.h | 6 - .../sparc/leon2/leon_open_eth/leon_

[PATCH 15/54] sim68000/clock/clockdrv.c: Fix warnings

--- c/src/lib/libbsp/m68k/sim68000/clock/clockdrv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/c/src/lib/libbsp/m68k/sim68000/clock/clockdrv.c b/c/src/lib/libbsp/m68k/sim68000/clock/clockdrv.c index 911cc4f..3cf9818 100644 --- a/c/src/lib/libbsp/m68k/sim68000/clock/

[PATCH 07/54] m68k/uC5282: Fix warnings

--- c/src/lib/libbsp/m68k/uC5282/clock/clock.c | 2 +- c/src/lib/libbsp/m68k/uC5282/include/bsp.h | 10 + c/src/lib/libbsp/m68k/uC5282/startup/bspstart.c | 52 ++--- c/src/lib/libbsp/m68k/uC5282/startup/init5282.c | 14 ++- 4 files changed, 27 insertions(+),

[PATCH 10/54] idp/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/idp/clock/ckinit.c | 58 +++- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git a/c/src/lib/libbsp/m68k/idp/clock/ckinit.c b/c/src/lib/libbsp/m68k/idp/clock/ckinit.c index 8018ae5..a2ee940 100644 --- a/c/src/lib/libbsp/m68k/idp/clo

[PATCH 16/54] powerpc/haleakala: Fix warnings

--- c/src/lib/libbsp/powerpc/haleakala/irq/irq_init.c | 11 +-- c/src/lib/libbsp/powerpc/haleakala/startup/bspstart.c | 16 +++- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/haleakala/irq/irq_init.c b/c/src/lib/libbsp/powerpc/ha

[PATCH 01/54] m68k/mvme136: Fix warnings

--- c/src/lib/libbsp/m68k/mvme136/clock/ckinit.c | 30 +++- c/src/lib/libbsp/m68k/mvme136/console/console.c | 60 +++- c/src/lib/libbsp/m68k/mvme136/include/bsp.h | 11 +++-- c/src/lib/libbsp/m68k/mvme136/startup/bspclean.c | 12 ++--- c/src/lib/libbsp/m68k/mv

[PATCH 22/54] powerpc/shared/clock/p_clock.c: Fix warnings

--- c/src/lib/libbsp/powerpc/shared/clock/p_clock.c | 29 +++-- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/shared/clock/p_clock.c b/c/src/lib/libbsp/powerpc/shared/clock/p_clock.c index 2a1ec0b..1ff7ca0 100644 --- a/c/src/lib/libbs

[PATCH 18/54] powerpc/tqm8xx: Fix warnings

--- c/src/lib/libbsp/powerpc/tqm8xx/clock/p_clock.c | 9 +++-- c/src/lib/libbsp/powerpc/tqm8xx/include/bsp.h | 48 +++-- 2 files changed, 27 insertions(+), 30 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/tqm8xx/clock/p_clock.c b/c/src/lib/libbsp/powerpc/tqm8xx/clock/

[PATCH 11/54] mvme147/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/mvme147/clock/ckinit.c | 30 ++-- 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mvme147/clock/ckinit.c b/c/src/lib/libbsp/m68k/mvme147/clock/ckinit.c index bfbb6da..2dae3a7 100644 --- a/c/src/lib/libbsp/m68k/

[PATCH 02/54] libbsp/shared/dummy_printk_support.c: Fix warning

--- c/src/lib/libbsp/shared/dummy_printk_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/shared/dummy_printk_support.c b/c/src/lib/libbsp/shared/dummy_printk_support.c index e0bb64c..8273edb 100644 --- a/c/src/lib/libbsp/shared/dummy_printk_support.c

[PATCH 06/54] powerpc/mvme5500: Fix warnings

--- .../libbsp/powerpc/mvme5500/GT64260/MVME5500I2C.c | 5 ++-- c/src/lib/libbsp/powerpc/mvme5500/irq/irq_init.c | 30 ++ .../lib/libbsp/powerpc/mvme5500/startup/bspstart.c | 10 +++- .../powerpc/mvme5500/vectors/exceptionhandler.c| 1 + c/src/lib/libbsp/powerpc/mv

[PATCH 09/54] gen68340/clock/ckinit.c: Fix warnings

--- c/src/lib/libbsp/m68k/gen68340/clock/ckinit.c | 125 +- 1 file changed, 41 insertions(+), 84 deletions(-) diff --git a/c/src/lib/libbsp/m68k/gen68340/clock/ckinit.c b/c/src/lib/libbsp/m68k/gen68340/clock/ckinit.c index d308531..de3df6e 100644 --- a/c/src/lib/libbsp/m6

Next Round of Warnings Patches

Hi This is a set of 57 boring patches which eliminate warnings and do some clean up. Mostly this is adding static to methods, addressing set but not used warnings, using uint32_ for pci dword operations, correcting IRQ structures, and clean up. As with the previous rounds, I have tried to stick t

Re: Batch of Patches from Joel

On 10/13/2014 9:48 AM, Gedare Bloom wrote: > These 23 look good to me. -Gedare Thanks. I know this many patches is a real pain but it is unfortunately needed to get the warning count down. The unique warning count has dropped from ~1750 to ~800 in the past week. Of those ~800, there are still 533

[PATCH 11/23] arm/rtl22xx/startup/bspreset.c: Include

--- c/src/lib/libbsp/arm/rtl22xx/startup/bspreset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/c/src/lib/libbsp/arm/rtl22xx/startup/bspreset.c b/c/src/lib/libbsp/arm/rtl22xx/startup/bspreset.c index deb58ac..573b4a2 100644 --- a/c/src/lib/libbsp/arm/rtl22xx/startup/bspreset.c +++ b/c/src

[PATCH 20/23] m68k/genmcf548x/console/console.c: Eliminate unused debug methods

--- c/src/lib/libbsp/m68k/genmcf548x/console/console.c | 23 -- 1 file changed, 23 deletions(-) diff --git a/c/src/lib/libbsp/m68k/genmcf548x/console/console.c b/c/src/lib/libbsp/m68k/genmcf548x/console/console.c index c5aa359..e85b934 100644 --- a/c/src/lib/libbsp/m68k/genmc

[PATCH 21/23] m68k/mcf5235/console/console.c: Eliminate unused debug methods

--- c/src/lib/libbsp/m68k/mcf5235/console/console.c | 20 1 file changed, 20 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mcf5235/console/console.c b/c/src/lib/libbsp/m68k/mcf5235/console/console.c index d0e556c..b543765 100644 --- a/c/src/lib/libbsp/m68k/mcf5235/console/

[PATCH 16/23] powerpc/mvme5500/startup/bspreset.c: Include

--- c/src/lib/libbsp/powerpc/mvme5500/startup/bspreset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/mvme5500/startup/bspreset.c b/c/src/lib/libbsp/powerpc/mvme5500/startup/bspreset.c index 1429afd..b25888e 100644 --- a/c/src/lib/libbsp/powerpc/mvm

[PATCH 13/23] mips/csb350/startup/bspreset.c: Include

--- c/src/lib/libbsp/mips/csb350/startup/bspreset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/c/src/lib/libbsp/mips/csb350/startup/bspreset.c b/c/src/lib/libbsp/mips/csb350/startup/bspreset.c index 32c109c..811a6f9 100644 --- a/c/src/lib/libbsp/mips/csb350/startup/bspreset.c +++ b/c/s

[PATCH 23/23] m68k/uC5282/console/console.c: Eliminate unused debug methods

--- c/src/lib/libbsp/m68k/uC5282/console/console.c | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/c/src/lib/libbsp/m68k/uC5282/console/console.c b/c/src/lib/libbsp/m68k/uC5282/console/console.c index 6662956..0daa99b 100644 --- a/c/src/lib/libbsp/m

[PATCH 07/23] arm/edb7312/startup/bspreset.c: Include

--- c/src/lib/libbsp/arm/edb7312/startup/bspreset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/c/src/lib/libbsp/arm/edb7312/startup/bspreset.c b/c/src/lib/libbsp/arm/edb7312/startup/bspreset.c index fa4ff1a..436bdf0 100644 --- a/c/src/lib/libbsp/arm/edb7312/startup/bspreset.c +++ b/c/src

[PATCH 18/23] powerpc/shared/startup/pretaskinghook.c: Include

--- c/src/lib/libbsp/powerpc/shared/startup/pretaskinghook.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/shared/startup/pretaskinghook.c b/c/src/lib/libbsp/powerpc/shared/startup/pretaskinghook.c index a0030b1..dbdf80e 100644 --- a/c/src/lib

[PATCH 17/23] powerpc/beatnik/startup/bspreset.c: Include

--- c/src/lib/libbsp/powerpc/beatnik/startup/bspreset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/c/src/lib/libbsp/powerpc/beatnik/startup/bspreset.c b/c/src/lib/libbsp/powerpc/beatnik/startup/bspreset.c index 0e6af19..ecdc034 100644 --- a/c/src/lib/libbsp/powerpc/beatnik/startup/bspres

[PATCH 19/23] m68k/av5282/console/console.c: Eliminate unused debug methods

--- c/src/lib/libbsp/m68k/av5282/console/console.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/c/src/lib/libbsp/m68k/av5282/console/console.c b/c/src/lib/libbsp/m68k/av5282/console/console.c index 85ec37f..bc1d9e5 100644 --- a/c/src/lib/libbsp/m68k/av5282/console/c

[PATCH 15/23] powerpc/motorola_powerpc/startup/bspreset.c: Include

--- c/src/lib/libbsp/powerpc/motorola_powerpc/startup/bspreset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/motorola_powerpc/startup/bspreset.c b/c/src/lib/libbsp/powerpc/motorola_powerpc/startup/bspreset.c index ab21611..0931bad 100644 --- a/c/

[PATCH 12/23] arm/smdk2410/startup/bspreset.c: Include

--- c/src/lib/libbsp/arm/smdk2410/startup/bspreset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/c/src/lib/libbsp/arm/smdk2410/startup/bspreset.c b/c/src/lib/libbsp/arm/smdk2410/startup/bspreset.c index d6c583b..95ccc42 100644 --- a/c/src/lib/libbsp/arm/smdk2410/startup/bspreset.c +++ b/c

[PATCH 22/23] m68k/mcf5329/console/console.c: Eliminate unused debug methods

--- c/src/lib/libbsp/m68k/mcf5329/console/console.c | 21 - 1 file changed, 21 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mcf5329/console/console.c b/c/src/lib/libbsp/m68k/mcf5329/console/console.c index 8f72270..4b57131 100644 --- a/c/src/lib/libbsp/m68k/mcf5329/console

  1   2   >