Re: Review problems

2015-03-19 Thread Gavin Sharp
No doubt that things do not always go smoothly in practice. :) I was describing the ideal that we should be striving for, and the general process we should use to address problem cases (which will inevitably occur). As you point out, "escalation" can have some negative connotations, but it doesn't

Re: Review problems

2015-03-19 Thread Boris Zbarsky
On 3/19/15 7:07 AM, David Rajchenbach-Teller wrote: - encourage developers to say "no", either to high-priority features or to review requests, when they can't cope – this includes emulating bz' "I do not accept review requests at the moment"; Note that as of a week or so ago Bugzilla has a

Re: Review problems

2015-03-19 Thread David Rajchenbach-Teller
I have been faced a few times with reviews that languish several weeks/months, despite direct communication with the reviewer, so indeed, I definitely agree that we need to improve the situation. I suspect that, in most cases, the lack of reviews were due to succession of unexpected, high-priority

Re: Review problems

2015-03-19 Thread Gabor Krizsanits
On Wed, Mar 18, 2015 at 4:47 PM, Gavin Sharp wrote: > This is a difficult problem to discuss in the abstract. > > It should never be the case that you are "waiting for weeks/months" - > you should either be getting reviews within a week (at worst), or be > getting responses saying "can't spend ti

Re: Review problems

2015-03-18 Thread Kyle Huey
On Wed, Mar 18, 2015 at 8:39 AM, Gabor Krizsanits wrote: > I think I'm not the only one experienced issues with reviews from one side > or the other. > I'm wondering if we could do some improvements here for everyone's sake. > > Here are the issues the way I see it: > * some parts of the code nee

Re: Review problems

2015-03-18 Thread Gavin Sharp
This is a difficult problem to discuss in the abstract. It should never be the case that you are "waiting for weeks/months" - you should either be getting reviews within a week (at worst), or be getting responses saying "can't spend time reviewing this now". Where that is not happening, the escala

Review problems

2015-03-18 Thread Gabor Krizsanits
I think I'm not the only one experienced issues with reviews from one side or the other. I'm wondering if we could do some improvements here for everyone's sake. Here are the issues the way I see it: * some parts of the code need more peers - we should identify the areas - we should select can