On Wed, Mar 18, 2015 at 4:47 PM, Gavin Sharp <[email protected]> wrote:

> This is a difficult problem to discuss in the abstract.
>
> It should never be the case that you are "waiting for weeks/months" -
> you should either be getting reviews within a week (at worst), or be
> getting responses saying "can't spend time reviewing this now". Where
> that is not happening, the escalation path should be something like:
>

If it never happened I would not have written this email. But I agree it
should not.
It's a very nice gesture that someone at least reacts on the request and
tell me
an ETA or gives me a heads-up about the delay, and I can just encourage
people
to do so, but that does not fix the issue. And escalation can cause more
trouble
sometimes than it helps...

Let's say I'm at the other side, and all of a sudden I have to review
dozens of huge
patches I have not seen coming, while I'm working on P1 sec. crit.
blockers, or
have 100 other patches to review, what can I do? But let's forget about
extreme
cases and long delays for a second...

I've seen core developers on bugzilla closing their review queues... Example
could be smaug or bz, who probably have more reviews to do than I could
count.
I seriously have no idea how can they do any other work. All my gratitude
for their
amazing job with reviews, and juggling with all the things they do at once.
It's
incredible to me that someone can do 100 reviews a week... I just  think it
would
be nice if there were more people who could lift off some reviews from their
shoulders. Might be a stupid idea... Based on the reactions, or the lack of
them
probably it is.

 - Gabor
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to