This is a difficult problem to discuss in the abstract. It should never be the case that you are "waiting for weeks/months" - you should either be getting reviews within a week (at worst), or be getting responses saying "can't spend time reviewing this now". Where that is not happening, the escalation path should be something like:
1) bring it up with the peers you are asking for review 2) bring it up with the module owner 3) if there is no module owner or they are not being a responsible owner, bring it up with the module-ownership module or other technical leaders in the project That last one is pretty fuzzy, granted, but hopefully there are not too many areas of code that are that un-owned. Gavin On Wed, Mar 18, 2015 at 8:39 AM, Gabor Krizsanits <gkrizsan...@mozilla.com> wrote: > I think I'm not the only one experienced issues with reviews from one side > or the other. > I'm wondering if we could do some improvements here for everyone's sake. > > Here are the issues the way I see it: > * some parts of the code need more peers > - we should identify the areas > - we should select candidates > - there should be a clear path to become a peer > (reading up code/spec, asking for sr's first and starting with easier > ones, etc) > * reviews are not part of our goal system > - it makes no sense to work on something if for the > reviewer will likely take several weeks or even months > to get to the review (for various but foreseeable reasons) > - people who are flooded with reviews cannot focus on their > actual goals they signed up for, or have to block people by > not doing reviews > > Maybe I'm just not well informed, and all these issues are already being > taken care of... But if not, I would like to hear what others think. > > - Gabor > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
