Engineering Effectiveness Newsletter #2

to get you up to speed! This is the second iteration of the newsletter for the period of April, May and June.  = Highlights = - Andrew Halberstadt and Marco Castelluccio improved the `mach try auto` automatic test selector to run fewer tests and catch more failures <https://groups.google.

Re: Intent to unship: system SQLite support on Linux (--enable-system-sqlite)

The unship patch was just merged in mozilla-central in bug 1611386. Marco On Thu, Feb 6, 2020 at 4:11 PM Marco Bonardo wrote: > The Storage support team intends to remove support for building > Mozilla-based applications using the system provided SQLite library on > Linux (--enab

Intent to unship: system SQLite support on Linux (--enable-system-sqlite)

ew Sqlite release and apply them as soon as possible. Thanks, Marco ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Searchfox at All-Hands: Who's interested?

I'd be interested too, in particular about 1 as we'd like to integrate more things into Searchfox (code coverage, static analysis and linting issues to name a few). - Marco. Il 09/01/20 19:43, Andrew Sutherland ha scritto: > Are people interested in a session(s) at the All-Hands

New coverage frontend and zero coverage checker

, https://bugzilla.mozilla.org/show_bug.cgi?id=deadcode-codecoverage, or that it is tested in a configuration which is not yet supported by code coverage). As usual, you can also browse our full zero coverage report at https://mozilla.github.io/code-coverage-reports/zero_coverage_report.html. - Marco

Re: Update: m-c is now reformatted, trees will reopen shortly

cond3 ) { Also assignments let revHost = host.split("") .reverse() .join("") + "."; now are let revHost = host .split("") .reverse() .jo

PSA: Bot automatically assigning components to Untriaged (and some General) bugs

as in many cases a better component can be found. This is of course much more difficult than the Untriaged case, so we apply the change only when the bot "feels" confident enough. More information about the bot at https://hacks.mozilla.org/2019/04/teaching-machines-to-t

Re: Using inline variables (C++17) in Gecko

ug.cgi?id=1410217#c5), but I didn't investigate more. - Marco. Il 20/03/19 10:57, Mike Hommey ha scritto: > Sorry for the late answer. Thanks for prodding me on irc. > > On Sat, Feb 23, 2019 at 06:36:39PM -0800, Emilio Cobos Álvarez wrote: >> Hey, >> >> I have a us

Re: Running different instances of Firefox side-by-side

What is the bug where you made the initial changes? We should link to the bug the regressions caused by it (I've seen at least a couple regressions filed mentioning this post on dev-platform rather than the bug where the regression was introduced). - Marco. Il 13/03/19 22:14, Dave Townse

Re: Closure of #ateam irc channel

#codecoverage for code coverage-related questions. - Marco. Il 22/01/19 10:16, David Burns ha scritto: > > For the last 2 years the Automation and Tools team (#ateam) has not > existed as a single function as parts of the team were split up > between Firefox Engineer Operations

Code Coverage on Phabricator

able lines** (e.g. a comment, a definition, and so on), **dark blue** corresponds to **covered lines**. When hovering the bar, the corresponding line is highlighted in the same color. You can find an alternative version of this email with fancy screenshots at https://marco-c.github.io/2019/01/21/

Re: Rust code coverage

Il 07/01/19 14:36, Henri Sivonen ha scritto: > On Fri, Jan 4, 2019 at 2:54 PM Marco Castelluccio > wrote: >> Hi everyone, >> we have recently enabled collecting code coverage for Rust code too, > Nice! > >> running Rust tests in coverage builds. > Does this mean

Rust code coverage

C/C++/Java/JavaScript reports, and as usual you can find them at one of these links (we are working on a replacement for them, as they fail to scale to the size of our repository, often timing out on load): https://codecov.io/gh/mozilla/gecko-dev https://codecov.io/gh/marco-c/gecko-dev https://coveralls

Re: Extension to integrate Searchfox features in Phabricator

Thanks for the report, I had built it really quickly without actually looking into perf. I think the issue should be fixed in the newest version of the extension (0.2.1), let me know if it isn't (I couldn't reproduce it). - Marco. P.S.: Should you find other problems, you can file

Extension to integrate Searchfox features in Phabricator

es my workflow much more pleasant. You can find it at https://addons.mozilla.org/addon/searchfox-phabricator/ (the source code is at https://github.com/marco-c/mozsearch-phabricator-addon). Currently, the extension does: 1) Highlight keywords when you hover them, highlighting them both in the pre-patc

Re: Plan for Sunsetting MozReview

sitive behaviour and this > causes cl.exe to get confused. This bit me last week. > > -Jeff > > On Fri, Jul 27, 2018 at 9:30 AM, Marco Bonardo > wrote: > > As a side note, the WSL terminal on Windows works properly with arc. The > > only downside is that you ne

Re: Plan for Sunsetting MozReview

As a side note, the WSL terminal on Windows works properly with arc. The only downside is that you need a Windows terminal to build and a separate WSL terminal to arc diff... On Fri, Jul 27, 2018 at 3:25 PM Mark Côté wrote: > I plan on updating a bunch of MDN docs within the next couple weeks. I

Re: PSA: pay attention when setting multiple reviewers in Phabricator

On Mon, Jul 2, 2018 at 5:01 PM Andreas Tolfsen wrote: > > > When asking for review to multiple reviewers, and all of them must accept > > your revision, you must mark them as blocking reviews, either in the > > Phabricator ui or appending "!" at the end of the reviewer name. > Otherwise > > it's

PSA: pay attention when setting multiple reviewers in Phabricator

're not used to it, I found it quite surprising and risked to miss this request completely for days. Cheers, Marco ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Please try out clang-cl and lld-link on Windows

It sounds cool and I'd really love to try, but: "ERROR: Found SDK version 10.0.16299.0 but clang-cl builds currently don't work with SDK version 10.0.16299.0 and later..." I know that I can set WINDOWSSDKDIR, but I'm not willing to mess too much with the env. Is there a bug tracking the update to

Re: Proposal to replace the NS_ASSERT function in JS with console.assert

On Mon, Feb 26, 2018 at 7:02 PM, Brian Grinstead wrote: > console.assert doesn't throw an exception, and neither does NS_ASSERT. So I > don’t think replacing consumers with exceptions is correct if we want to keep > the current behavior. But I guess the intent for places code in bug 1431050 > i

Re: Proposal to replace the NS_ASSERT function in JS with console.assert

? Cheers, Marco On Mon, Feb 26, 2018 at 6:37 PM, Brian Grinstead wrote: > There have been some improvements to the console API for chrome callers > recently: > > * The WebIDL implementation is available as a global in JSMs - no need to > import Console.jsm (bug 1425574) > * Chrome

Re: PSA: Changes to JSM import APIs (or, Death to Cu.import)

Hi Kris, this change is awesome. Is it ok to continue use defineLazyModuleGetters (plural), since it internally now uses chromeUtils.defineModuleGetter? Any downsides? On Fri, Feb 2, 2018 at 7:48 AM, Ed Lee wrote: > Great to see these types of broad changes getting wins, so if there's > a good w

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

Is your profile local, or do you have it on a network share? It's possible your db has some kind of corruption that causes recursive references. I'd first of all check it using sqlite3 and the PRAGMA integrity_check query. If that passes (returns "ok"), I'd also try to run the Places Maintenance f

Re: Re: nsAutoConfig

Are you sure the test you wrote is testing nsAutoConfig and not nsReadConfig? nsReadConfig does not instantiate nsAutoConfig unless autoadmin.global_config_url exists and is not emtpy: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig

Re: nsAutoConfig

It is not covered by any automated test: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp (this doesn't mean it isn't actually used ever, but it can be a clue). - Marco. Il 31/10/2017 05:09, Nicholas

Re: #pragma once?

See the previous pragma once proposal: https://groups.google.com/forum/#!msg/mozilla.dev.platform/PgDjWw3xp8k/PLYQc5xoWmsJ On Wed, Oct 11, 2017 at 11:45 AM, Emilio Cobos Álvarez wrote: > Hi, > > I'm adding a header to the build, and I'm wondering: Can we use pragma once? _

Re: Changes to tab min-width

On Tue, Oct 3, 2017 at 10:36 PM, Jeff Griffiths wrote: > 1. do you prefer the existing behaviour or the new behaviour? > 2. if you prefer a value for this pref different than 50 or 100, what > is it? Why? I prefer being able to see a minimum part of the title, because I very often have multiple t

Re: Intent to require `mach try` for submitting to Try

On Sun, Sep 17, 2017 at 6:05 AM, Andrew Halberstadt wrote: > Interesting, please file a bug either way and CC me. It worked > for me back when it first landed, though I haven't tried it since. > I'll see if I can reproduce sometime this week. Done: https://bugzilla.mozilla.org/show_bug.cgi?id=140

Re: Intent to require `mach try` for submitting to Try

I have a problem with try fuzzy, not sure if it's just my system, so didn't file a bug yet. On Windows it always hangs after it tries to cleanup its own stuff at the end, I must terminate it and manually uncommit and purge the config file. Does anyone have the same problem?

Re: Reminder on Try usage and infrastructure resources

On Thu, Sep 14, 2017 at 6:13 PM, Andrew Halberstadt wrote: > Yes, all mochitests except Android restart between manifests (which is > usually the same as folders). Thank you very much, that's really useful to know and will allow me to save some infra time!

Re: Reminder on Try usage and infrastructure resources

On Thu, Sep 14, 2017 at 5:56 PM, James Graham wrote: > On 14/09/17 16:48, Marco Bonardo wrote: > mach try -p linux64 Afaict, that runs a single folder, but the intermittent may be caused by interactions across different tests in different folders. I'm not up-to-date to what we do t

Re: Reminder on Try usage and infrastructure resources

When I need to retrigger a mochitest-browser test multiple times (to investigate an intermittent), often I end up running all the mochitest-browser tests, looking at every log until I find the chunk where the test is, and retrigger just that chunk. The chunk number changes based on the platform and

Re: Triage Summary 2017-08-21

I've seen you started marking unassigned P1s as "stale" and stating their priority will be reset if they stay unassigned. Please don't do that, it's a very bad idea. We are using P1s to have a list of bugs the team should be working on as soon as they have time, and there must be no strict assigne

Firefox startup code coverage (ts_paint talos test)

Hello all, at https://marco-c.github.io/ts_paint_startup_coverage_report/ you can find a (C/C++-only for now) code coverage report of Firefox startup. The report was generated using the ts_paint talos test, considering code executed until the "MozAfterPaint" event and after a setTimeou

Re: No information about the related folder in the bookmark manager screen

There's an old bug about this https://bugzilla.mozilla.org/show_bug.cgi?id=469421 but no ETA (I also suspect a Library redesign may happen after Photon) On Sun, May 14, 2017 at 10:34 AM, wrote: > Hi, > > When searching for a bookmark we don't have any information about the > folder. > It could b

Re: Re: CodeCoverage Monthly Update

No, currently not, but we can build one ourselves using their API (which we might to do with codecov.io anyway, since we expect to have custom needs). - Marco. Il 04/05/17 08:22, Chris Peterson ha scritto: On 2017-05-03 8:44 PM, Kyle Lahnakoski wrote: * Daily coverage reports on

Re: Rounding to the jemalloc bucket size

I'm far from being an expert here, but I seem to remember from Storage that we have malloc_good_size On Thu, Apr 27, 2017 at 9:24 AM, Henri Sivonen wrote: > For growable buffer types that internally contain the logical length > (how many slots of the buffer are in use as far as external callers

Re: windows build anti-virus exclusion list?

On Fri, Mar 17, 2017 at 7:20 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 1:36 PM, Ted Mielczarek > wrote: > > With defender > disabled the best I can get is 18min. This is on one of the new lenovo > p710 machines with 16 xeon cores. > Just to add one datapoint, I just replaced my desktop wi

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Wed, Mar 8, 2017 at 2:12 PM, Kartikaya Gupta wrote: > What makes me sad is all the > developers in this thread trying to push back against disabling of > clearly problematic tests, asking for things like tracking bugs and > needinfos, when the reality is that the developers just don't have the

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 8:11 PM, wrote: > Thanks for checking up on this- there are 6 specific bugs that have this > signature in the disabled set- in this case they are all linux32-debug > devtools tests- we disabled devtools on linux32-debug because the runtime > was exceeding in many cases 90 s

Re: Is there a way to improve partial compilation times?

On Tue, Mar 7, 2017 at 8:05 PM, Mike Conley wrote: > FWIW, the MOZ_MAKE_FLAGS bit can probably be removed, as I believe mach > will just choose the optimal number based on examining your processor > cores. >From my experience the chosen value is too conservative, I think it defaults to cpu_coun

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 6:42 PM, Joel Maher wrote: > Thank for pointing that out. In some cases we have fixed tests that are > just timing out, in a few cases we disable because the test typically runs > much faster (i.e. <15 seconds) and is hanging/timing out. In other cases > extending the tim

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 6:34 PM, Marco Bonardo > > In case of mochitest browser tests failing on "This test exceeded the > timeout threshold", the temporary solution after 1 or 2 weeks should be to > add requestLongertimeout,rather than disabling them. They should still be &

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 3:26 PM, wrote: > In recent months we have been triaging high frequency (>=30 times/week) > failures in automated tests. We find that we are fixing 35% of the bugs > and disabling 23% of them. > In case of mochitest browser tests failing on "This test exceeded the timeout

Re: Telemetry Histogram Expiry

Bug 1334617 is taking care of FX_URLBAR_SELECTED_RESULT_INDEX FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH can likely be removed, also considering the future of Flash support. I'll file a bug for that. ___ dev-platform mailing list dev-platfor

Re: Visual Studio Code recommended extensions

On Mon, Feb 27, 2017 at 5:12 PM, Dan Mosedale wrote: > It sounds like you find it better than Atom. If that's true, any chance > you could elaborate on what you find particularly nicer and/or what's > missing? > Personally, I find it faster on common operations (starting up, opening documents)

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 6:28 PM, James Graham wrote: > On 23/02/17 16:48, Marco Bonardo wrote: > > // Rust language support. >> "saviorisdead.RustyCode" >> > > I haven't used either (or VS Code much), but my understanding is that is &g

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 5:56 PM, Jared Wein wrote: > Does the ESLint support hook in to the mozilla-eslint configuration? Can > you please update https://developer.mozilla.org/en-US/docs/ESLint or > https://wiki.mozilla.org/DevTools/CodingStandards#JS_linting_with_ESLint > with any steps required

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 6:03 PM, Joe Hildebrand > > // Hilight trailing whitespaces. > > "ybaumes.highlight-trailing-white-spaces", > > This one seems a little aggressive. I'd use it on my code, but on old > broken code, it would be really annoying. > Well, the hilight is very li

Visual Studio Code recommended extensions

Hi, I recently started testing VS Code as a replacement for Sublime Text or Atom, and so far the experience has been better than I was expecting. I suspect others of you are doing the same. In bug 1341585, I'm adding .vscode/settings.json to the ignore lists, so that everyone can create his own wo

Re: ARIA membership and role="password"

An update to this: I just re-joined the ARIA-WG on Mozilla's behalf. Marco 2016-06-02 17:47 GMT+02:00 David Bolter : > Hi Johnathan, > > Our lack of direct W3C ARIA involvement recently is mainly due to > time/resource constraints and we have influence via proxy. > &g

Re: Triage Plan for Firefox Components

On Fri, Apr 1, 2016 at 2:02 AM, Emma Humphries wrote: > Priority sounds like a great choice, but given that everyone's using the > Priority field their own way, there's enough heterogeneity in how it's used > to make it difficult. > Fwiw, we (Awesome Search Team) also use Priority for the backlo

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Wed, Feb 10, 2016 at 10:30 AM, James Graham wrote: > FWIW I think it's closer to the truth to say that these tests are not set > up to be performance regression tests > Right, but this was just one of the aspects that was pointed out. I think the performance analysis is not much about catchin

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Tue, Feb 9, 2016 at 6:54 PM, Ryan VanderMeulen wrote: > I'd have a much easier time accepting that argument if my experience > didn't tell me that nearly every single "Test took longer than expected" or > "Test timed out" intermittent ends with a RequestLongerTimeout as the fix this sounds e

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Tue, Feb 9, 2016 at 8:09 PM, Gijs Kruitbosch wrote: > I concur with Ryan here, and I'd add that IME 90% if not more of these > timeouts (where they are really timeouts because the test is long, rather > than just brokenness in the test that leaves it hanging until the timeout) > happen on debu

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

90 seconds for a simple test sounds like a lot of time and a huge bump from the current situation (45). The risk is people will start writing much bigger tests instead of splitting them into smaller an more manageable tests. Plus when a test depends on a long timeout in the product, developers are

Re: Does SSE2 usage still need to be conditional?

that use Windows 8.1 have a 64bit CPU. [1] http://windows.microsoft.com/en-GB/windows-8/what-is-pae-nx-sse2 - Marco. Il 01/02/16 15:00, Xidorn Quan ha scritto: On Tue, Feb 2, 2016 at 7:04 AM, Benjamin Smedberg wrote: On 1/29/2016 2:05 PM, Cameron Kaiser wrote: On 1/29/16 9:43 AM, Ashley Gull

Re: Bug Program Next Steps

On Sat, Jan 30, 2016 at 12:45 AM, Emma Humphries wrote: > Looking at the urgent bugs does not have to be one person’s task. You can > have a rotation of people doing this. Look at the Core::Graphics > triage wiki for an > example of what you

Re: Just Autoland It

checkin? is also used for large multi-patch bugs that land parts at different times. On Fri, Jan 22, 2016 at 3:38 PM, Paolo Amadini wrote: > On 1/22/2016 2:00 PM, Mark Hammond wrote: > >> (Hopefully) related - what exactly is the "checkin?" flag for? >> > > As far as I understand, it's used toge

Re: Maintaining the en-US dictionary that ships with Mozilla products

On 28/12/2015 22:32, Jörg Knobloch wrote: However, after sorting I was able to spot a few words the Mozilla version is lacking: residuary reproachfulness relict reformism enforceability makefile lycopod (I'm using a en-GB dictionary while writing this post, and all the words listed above are

Re: Maintaining the en-US dictionary that ships with Mozilla products

(Proofing Tool GUI) but he who has access to this post can already read the "hidden" FAQ: http://marcoagpinto.cidadevirtual.pt/faq.html Kind regards, >Marco A.G.Pinto ___ dev-platform mailing lis

Re: W3C Proposed Recommendation: longdesc

ages --, it is very useful and used actively in certain corner areas of the web not everyone might regularly visit. Therefore, I vote for just leaving it as is and letting it ride the recommendation train to its destination. Marco ___ dev-platform mailin

Re: Migrating defaults from other browsers

On 19/01/2015 13:58, Henri Sivonen wrote: I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? Note that we don't migrate IE prefs if they hav

Re: W3C Proposed Recommendation: longdesc

>> proposal that we do support. > Maybe Marco Zehe would be interested in removing it :-). I actually am not. ;) The reason is not that I care about this feature. I honestly don't. But the noise that is to be expected from "interested parties" if we remove the feature is

Re: e10s is now enabled by default for Nightly!

On 07/11/2014 18:05, ch...@pointlessone.org wrote: My nightly crashes on start. Well, that's fine and is expected from unstable software. But now that I've submitted a half a dozen crash reports which pref do I flip to continue using my browser? Hold down shift when launching Firefox to ente

Re: e10s is now enabled by default for Nightly!

On 07/11/2014 10:40, Gijs Kruitbosch wrote: Where can we read about how this decision was made? On my profiles with Force RTL, e10s perma-crashes ( https://bugzilla.mozilla.org/show_bug.cgi?id=1072980 ), and in most other cases, I only ever see spinners for remote content (ie can't actually brows

Re: Intent to ship: Web Speech API - Speech Recognition with Pocketsphinx

Hi Andre, It is a nice work and expect the voice recognition on B2G. Beside this final result, I am also interesting in the reason of you migrate from SpeechRTC -> emscripten -> Web Speech API. Could you also share what is the factor triggered these transition? Then that can be the lesson le

Re: [PresentationAPI] Intend to implement

erely yours. - 原始郵件 - 寄件者: "Ehsan Akhgari" 收件者: "Marco Chen" , "Fabrice Desré" 副本: dev-platform@lists.mozilla.org 寄件備份: 2014 9 月 16 星期二 下午 11:01:36 主旨: Re: [PresentationAPI] Intend to implement Does this mean that now the URLs in certified gaia apps must b

Re: [PresentationAPI] Intend to implement

Hi, According to our first version will be enabled on FxOS with Certified apps only, to enable/support "app://" can allow us to add values into Certified apps by this API. ex: An addon for desktop Firefox browser can launch an corresponding app in remote TV. Then you can fling what movie y

Re: Proposed W3C Charter: Second Screen Presentation WG

he scope of this WG. And that is just one opinion from a member only not the final decision or direction there. Though the interoperability between browser vendors is important too. [1] http://www.w3.org/2014/secondscreen/charter-draft.html - 原始郵件 - 寄件者: "Henri Sivonen"

Re: Proposed W3C Charter: Second Screen Presentation WG

Hi Henri, > So different that I wonder if the cases belong in the same spec. The answer is yes. There are two cases to be covered by presentation API - One UA: 1. (having another screen to push pixels to) 2. ex: Local UA can display the video via HDMI / WiFi Display / Air Play to Remote Scr

Re: Intent to implement: navigator.deviceStorage

原始郵件 - 寄件者: "Ehsan Akhgari" 收件者: "Marco Chen" 副本: dev-platform@lists.mozilla.org 寄件備份: 2014 7 月 22 星期二 上午 2:01:13 主旨: Re: Intent to implement: navigator.deviceStorage Yes, indeed. Below, I meant to agree with adding a new EventTarget where these events can be

Re: Intent to implement: navigator.deviceStorage

Yes, I agree with you for virtual device storage API. But before discussing the detail of virutal device storage api, the first step here is to figure out where should new event handler be added? Since there is not only new event handler been added but also a set of APIs potentially, I suppo

Re: OMTC on Windows

For reference -- if this is applicable --, these failures are tracked in bug 1014673: https://bugzilla.mozilla.org/show_bug.cgi?id=1014673 Marco On 23.05.2014 09:10, Marco Zehe wrote: > Hi all, > > for a couple of days on Nightly, I am seeing an increasing number of > WM_GETOB

Re: OMTC on Windows

? Marco On 22.05.2014 22:22, Girish Sharma wrote: > > On Fri, May 23, 2014 at 1:51 AM, Bas Schouten <mailto:bschou...@mozilla.com>> wrote: > > bug 1012213 > > > Yup, looks like that only. Thanks for the bug. > > > -- > Girish Sharma > B.Tech

Re: Announcing MozillaBuild 1.9.0 Release

On 03/04/2014 15:44, Ryan VanderMeulen wrote:> After a long delay and lots of hard work by 7 different contributors, I am pleased to announce the final release of MozillaBuild 1.9.0. Awesome, good job! I was using the pre-release from quite some time on win8.1 and VS2013, thanks for making it

Re: Too many system compartments at start-up

On 21/03/2014 15:37, Benjamin Smedberg wrote: On 3/21/2014 10:34 AM, Marco Bonardo wrote: Or directly make Cu.import act like defineLazyModuleGetter... Would that be possible? I don't think that's a good idea. It's not an uncommon pattern to try/catch around a module import i

Re: Too many system compartments at start-up

I started filing some low-hanging-fruit dependencies, though, looks like one of the main culprit is modules that are Cu.import-ed instead of defineLazyModuleGetter-ed. I wonder if we could somehow instrument Cu.import so that if a module is not used before N seconds (or M ticks?) from when it

Re: ISomething, nsISomething or mozISomething?

On 17/02/2014 15:15, David Rajchenbach-Teller wrote: Do we have naming conventions for new xpcom interfaces? I believe that I have seen all three forms on the tree. I need to pick one for my new bug. Which one should I pick? afaik there has been a period where we tried to move off of nsI prefi

Re: Removal of native notification systems on desktop platforms

On 10/08/2013 04:37 PM, Dave Townsend wrote: On Tue, Oct 8, 2013 at 3:30 PM, Marco <mailto:mar.castelluc...@studenti.unina.it>> wrote: The bug has regressed a lot of things. To me it looks like the decision to land it was a bit rushed. For example, I think we shouldn'

Re: Removal of native notification systems on desktop platforms

e notifications for Firefox notifications and XUL notifications for web notifications. 2) Backout the entire feature. 3) Backout the native notification removal. I don't know what we should do here, but I do think that this deserves a discussion. - Marco. On 10/08/2013 03:00 PM, Dave Townsend

Removal of native notification systems on desktop platforms

this support was reviewed, but the reviewer said to ask to the dev-platform newsgroup before landing, because the change had some impact. I couldn't find any thread on this list where this was discussed... There are proposals of backout in the bug. What should we do

Re: Coding style for functions called by Task.jsm tasks

On 10/08/2013 12:00 PM, dev-platform-requ...@lists.mozilla.org wrote: Message: 7 Date: Tue, 8 Oct 2013 11:47:52 -0700 From: Dave Townsend To: dev-platform Subject: Coding style for functions called by Task.jsm tasks Message-ID: Content-Type: text/plain; charset=ISO-8859-1 As Task.jsm

Re: reminder: content processes (e10s) are now used by desktop Firefox

On 02/08/2013 03:50, Nicholas Nethercote wrote: On Thu, Aug 1, 2013 at 6:29 PM, Gavin Sharp wrote: Do you have specific issues you're worried about, or are you just speaking about issues in general? This AdBlock issue worries me specifically. And the fact that there's breakage with our #1 a

Re: Rethinking separate Mercurial repositories

On 31/07/2013 13:14, Ben Hearsum wrote: On 07/31/13 05:54 AM, Marco Bonardo wrote: Now, maybe I'm wrong, but IIRC this is what we had before the rapid release, and we switched away from that cause: Releases have always had their own repositories (see https://hg.mozilla.org/releases/mo

Re: Rethinking separate Mercurial repositories

On 29/07/2013 19:43, Gregory Szorc wrote: I'm proposing that we merge all the release repositories (central, aurora, beta, release, esr, and b2g) into a single Mercurial repository. The "default" branch/bookmark of this repository would be the equivalent of mozilla-central. At train uplift time,

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

On 18/07/2013 20:34, highland...@gmail.com wrote: As for many other dbms around, comparisons are pretty much hard, just relying on microbenchmarking doesn't help much. What's best, LMDB, levelDB, kyotoCabinet, Sqlite4? It's hard to tell just by looking at these graphs, you'd need measurements don

Re: suggested reviewers for bugzilla products and components

On 18/07/2013 15:33, Byron Jones wrote: i have created an initial list on an etherpad using the module owners' wiki page as a source: https://bmo.etherpad.mozilla.org/suggested-reviewers please review and update this document where appropriate. Looks like most of Toolkit is missing. Is there

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

On 06/07/2013 11:26, Philip Chee wrote: "LMDB is an ultra-fast, ultra-compact key-value data store developed by Symas for the OpenLDAP Project. It uses memory-mapped files, so it has the read performance of a pure in-memory database while still offering the persistence of standard disk-based data

Re: Storage in Gecko

On 06/05/2013 18:41, David Dahl wrote:> KyotoCabinet might make a good backend for a new storage API: http://fallabs.com/kyotocabinet/ There is also a companion indexing engine: http://fallabs.com/kyototycoon/ Regards, David SQLite4 implements something very similar (log-structured merge d

Re: Storage in Gecko

On 26/04/2013 22:18, Andrew Sutherland wrote: Specifically, it does not look like IndexedDB's model; it still does a lot of fsync's in order to maintain the requisite SQL ACID semantics. Right, we can't expect miracles just by moving from SQLite3 to SQLite4, though it still uses an enhanced WA

Re: Landing on Trunk - Target Milestone vs. Status Flag Usage vs. Tracking for Future Releases

On 11/04/2013 18:23, Steve Fink wrote: The name "target milestone" implies an aspirational landing. Should we just change the bug template to change the name of the field? It could make sense, my understanding is that we started using it in the lack of better options, and has become a de-facto

Re: Landing on Trunk - Target Milestone vs. Status Flag Usage vs. Tracking for Future Releases

On 11/04/2013 07:22, Justin Dolske wrote: > I'd question if we really need to keep Target Milestone at all (given > replacements for how it's used now). We don't have replacements for "fixed from this version on", so far, as Alex well explained. > I don't see many Firefox/Gecko > teams using

Re: Notice of browser and toolkit theme renamings

On 26/02/2013 12:58, Mounir Lamouri wrote: On 23/02/13 07:25, Jared Wein wrote: I wanted to let you all know about bug 842913, of which I just landed the patch for on mozilla-inbound. Is themes/linux/ agnostic of the library being used (aka GTK vs QT)? -- Mounir See bug 844597 (https:/

Re: mozilla-central/inbound closed -- we hit the Windows PGO memory limit

On 22/01/2013 15:36, Benjamin Smedberg wrote: On 1/22/2013 9:28 AM, Axel Hecht wrote: How are the perf numbers looking? One of the reasons for asking is that I expect RDF to be part of the startup and window-open codepaths, at least. I would not expect PGO to optimize any of the RDF code for s

Re: mozilla-central/inbound closed -- we hit the Windows PGO memory limit

On 21/01/2013 21:47, Ehsan Akhgari wrote: 1. mozilla-central/inbound will remain closed to all check-ins except the ones that do not add any code which gets linked into libxul on Windows. Both inbound and central are APPROVAL REQUIRED as of now, any patches that don't touch libxul can land wit