Re: [b2g] Relevance of Super-Review (Was: Hardening the review requirements for changing .webidl files)

2014-04-25 Thread Boris Zbarsky
On 4/25/14, 10:06 PM, Doug Turner wrote: I tend to think that super review is a dumb idea. It's a hack around people doing bad reviews is what it is. There are certainly patches that are landing without official sr but that do the moral equivalent of what sr is supposed to ensure: running th

Re: [b2g] Relevance of Super-Review (Was: Hardening the review requirements for changing .webidl files)

2014-04-25 Thread Doug Turner
If my git fu is correct, we only landed 180 patches with sr=. In 2009, we landed 1033 patches with super review. Of the sr= that landed in the last year, most were sr’ed by people from the DOM team (olli, sicking, blake, bz, sicking, sicking, sicking). I tend to think that super review is a du

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Gavin Sharp
It would help a lot with bug-clarity if both the "record umask on startup" and "add API to OS.File" changes were split into their own bugs. The debate is really about the OS.File API. The API question depends a lot on the use cases people foresee. Are there any use cases identified for this API ot

intent to ship: mix-blend-mode

2014-04-25 Thread Rik Cabanier
Primary eng emails caban...@adobe.com, mih...@adobe.com *Spec* http://www.w3.org/TR/compositing-1/#mix-blend-mode The spec has been in CR since Feb 20 *Summary* The mix-blend-mode property allows you to specify how an element 'blends' with elements in the same stacking context. This property land

mozilla::pkix as default in gecko

2014-04-25 Thread Camilo Viecco
As many of you know we have a new ceritificate verificaion library that has been enabled by default in Firefox desktop since april 2. Today I am landing it as default in Gecko, this change passes all of our tests but I want Thunderbird and SeaMonkey developers aware, as there is still one bug t

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Neil
Wesley Hardman wrote: Shouldn't creating a file or directory, simply inherit the permissions from the parent? That is what I would expect (at least on Windows) when saving a file. Why would there be a need to explicitly set the permissions? On Windows, permissions are calculated when a fi

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Brian Smith
On Thu, Apr 24, 2014 at 4:23 PM, Mike Hommey wrote: > On Thu, Apr 24, 2014 at 04:15:45PM -0700, Brian Smith wrote: > > On Thu, Apr 24, 2014 at 4:03 PM, Ehsan Akhgari >wrote: > > > > > * Are there obvious places that people should inspect for code that's > > > > > >> being built but not used? S

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Ralph Giles
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-25 1:04 PM, Wesley Hardman wrote: > Shouldn't creating a file or directory, simply inherit the > permissions from the parent? I think Zack is describing the unix permissions model specifically here, where the 'x' permission is overloaded.

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Ralph Giles
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-25 12:26 PM, Zack Weinberg wrote: > AIUI, Windows makes no distinction between "readable" and > "executable" in file permissions. Files are executable if their > extension is recognized, and not otherwise. That's consistent with my tests.

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Wesley Hardman
On 2014-04-25 15:26, Zack Weinberg wrote: > On 04/25/2014 03:15 PM, Ralph Giles wrote: >> On 2014-04-25 11:47 AM, Mike Hoye wrote: >> >>> Because people download executable files with the expectation >>> that they can easily execute them. Agreed Here. I don't expect to have to go change file permi

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Zack Weinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/25/2014 03:15 PM, Ralph Giles wrote: > On 2014-04-25 11:47 AM, Mike Hoye wrote: > >> Because people download executable files with the expectation >> that they can easily execute them. > > I ask because allowing web content to add executable

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Ralph Giles
On 2014-04-25 11:47 AM, Mike Hoye wrote: > Because people download executable files with the expectation that they > can easily execute them. I ask because allowing web content to add executable files has security risks. URLs don't have unix permissions, but I see on Windows anything with a .exe

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Mike Hoye
On 2014-04-25, 2:41 PM, Ralph Giles wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-25 11:08 AM, Zack Weinberg wrote: Against these (particularly the third) was the claim that this API is only useful to the download manager. Forgive the derail, but why does the download manager

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Ralph Giles
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-25 11:08 AM, Zack Weinberg wrote: > Against these (particularly the third) was the claim that this API > is only useful to the download manager. Forgive the derail, but why does the download manager need to make things executable? -r

OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-25 Thread Zack Weinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bug 961080 asks for the new download manager to "support group and world-writable umasks for downloaded files". It is stalled on a design disagreement between me and the OS.File maintainers (well, it is also stalled because my development box corrup

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Ehsan Akhgari
On 2014-04-25, 3:31 AM, Henri Sivonen wrote: On Fri, Apr 25, 2014 at 2:03 AM, Ehsan Akhgari wrote: * Are we building and shipping dead code in ICU on B2G? No. That is at least partly covered by bug 864843. Using system ICU seems wrong in terms of correctness. That's the reason why we don't

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Mike Hoye
On 2014-04-25, 11:12 AM, Trevor Saunders wrote: On Fri, Apr 25, 2014 at 10:42:43AM -0400, Mike Hoye wrote: If we ask a thousand people to run a nightly under a profiler for a few days and aggregated the results, would that be valuable information? If the users are a good distribution and we col

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Trevor Saunders
On Fri, Apr 25, 2014 at 10:42:43AM -0400, Mike Hoye wrote: > On 2014-04-25, 3:31 AM, Henri Sivonen wrote: > >On Thu, Apr 24, 2014 at 4:20 PM, Benoit Jacob > >wrote: > >>> * How should we identify code that we build but that isn't used > >>>anywhere? > >>I'm afraid we need humans for that. > >Ye

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Mike Hoye
On 2014-04-25, 3:31 AM, Henri Sivonen wrote: On Thu, Apr 24, 2014 at 4:20 PM, Benoit Jacob wrote: * How should we identify code that we build but that isn't used anywhere? I'm afraid we need humans for that. Yeah, but how do we get humans to do that? We ask them! There are thousands of pe

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Mike Hommey
On Fri, Apr 25, 2014 at 12:10:24PM +0300, Henri Sivonen wrote: > On Fri, Apr 25, 2014 at 11:26 AM, Mike Hommey wrote: > > On Fri, Apr 25, 2014 at 10:31:44AM +0300, Henri Sivonen wrote: > >> Using system ICU seems wrong in terms of correctness. That's the > >> reason why we don't use system ICU on

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Benoit Jacob
2014-04-25 3:31 GMT-04:00 Henri Sivonen : > On Thu, Apr 24, 2014 at 4:20 PM, Benoit Jacob > wrote: > > 2014-04-24 8:31 GMT-04:00 Henri Sivonen : > > > >> I have prepared a queue of patches that removes Netscape-era (circa > >> 1999) internationalization code that efforts to implement the Encoding

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Henri Sivonen
On Fri, Apr 25, 2014 at 11:26 AM, Mike Hommey wrote: > On Fri, Apr 25, 2014 at 10:31:44AM +0300, Henri Sivonen wrote: >> Using system ICU seems wrong in terms of correctness. That's the >> reason why we don't use system ICU on Mac and desktop Linux, right? > > Actually the main reason is that ever

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Henri Sivonen
On Fri, Apr 25, 2014 at 10:31 AM, Henri Sivonen wrote: > Therefore, it looks like we should turn off (if we haven't already): > * The ICU LayoutEngine. I don't find this code in the tree at all. > * Ustdio I don't yet know what we are doing about this one. > * ICU encoding converters and th

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Mike Hommey
On Fri, Apr 25, 2014 at 10:31:44AM +0300, Henri Sivonen wrote: > Using system ICU seems wrong in terms of correctness. That's the > reason why we don't use system ICU on Mac and desktop Linux, right? Actually the main reason is that every version of desktop linux has a different version of ICU, wh

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Henri Sivonen
On Fri, Apr 25, 2014 at 10:31 AM, Henri Sivonen wrote: > So it looks like we already build with UCONFIG_NO_LEGACY_CONVERSION: > http://mxr.mozilla.org/mozilla-central/source/intl/icu/source/common/unicode/uconfig.h#264 Oops. No. I misread. -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.

Re: Policing dead/zombie code in m-c

2014-04-25 Thread Henri Sivonen
On Thu, Apr 24, 2014 at 4:20 PM, Benoit Jacob wrote: > 2014-04-24 8:31 GMT-04:00 Henri Sivonen : > >> I have prepared a queue of patches that removes Netscape-era (circa >> 1999) internationalization code that efforts to implement the Encoding >> Standard have shown unnecessary to have in Firefox.