On 4/25/14, 10:06 PM, Doug Turner wrote:
I tend to think that super review is a dumb idea.
It's a hack around people doing bad reviews is what it is.
There are certainly patches that are landing without official sr but
that do the moral equivalent of what sr is supposed to ensure: running
the API design by someone other than the reviewer whose judgment the
reviewer trusts (via feedback or needinfo or whatnot).
As long as all our reviewers are competent enough to know when to do
this (aka "know what you don't know") we don't need an official sr
requirement. In practice we seem to have been dealing without official
sr, as you note.
Of course if all our reviewers knew what they don't know we also
wouldn't need a commit hook on dom/webidl to catch patches there landing
without DOM peer review.... ;)
-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
