reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890416198
> See [jakartaee/servlet#66](https://github.com/jakartaee/servlet/issues/66)
Thanks for the link. See
https://github.com/jakartaee/servlet/issues/66#issuecomment-2890413278
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890457132
> IMHO what is described there is not what we need... because it has the
same problem we have now.
Which is what, exactly?
--
This is an automated message from the Apache Git Serv
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890882787
> > IMHO what is described there is not what we need... because it has the
same problem we have now.
>
> Which is what, exactly?
The problem now is: 1) "someone" calls getParam
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2890899779
@markt-asf http11nio protocol handler, the root cause is what i mentionned
in my mail to the list, the acceptor thread doesn't handle the fact stop is
being called properly so when serve
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890957828
> > IMHO what is described there is not what we need... because it has the
same problem we have now.
>
> Which is what, exactly?
You suggested to avoid using multipart... but a
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891015548
This issue does not occur on a clean install with `bindOnInit` set to
`false`.
For the first change, `localAddress` should not be null. The correct fix is
to address why `localAddr
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891074271
@markt-asf agree it fails similarly with `bindOnInit` or not set:
here is a reproducer:
```
package com.github.rmannibucau;
import org.apache.catalina.LifecycleExce
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891145754
It looks like Tomcat parsing parts for `multipart/form-data' with no
`` as a result of calling getParemeter() and friends is a bug
although I need to check the TCK. Fix that and the Wicket
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891175364
> It looks like Tomcat parsing parts for `multipart/form-data` with no
`` as a result of calling `getParameter()` and friends is a
bug although I need to check the TCK. Fix that and the Wic
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891191012
That test case doesn't log any exceptions or warnings for me with Tomcat
12.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891358727
> This is how all started ...
Not quite. The provided reproducer uses the `@MultipartConfig` annotation.
Therefore, for that configuration, it is working as designed.
--
This is a
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891401991
@markt-asf tested with main (ea0cdb044941f1ced5baf236aba395c170030768):
```
mai 19, 2025 5:13:12 PM org.apache.catalina.core.StandardService
startInternal
INFOS: Starting ser
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891405212
> > This is how all started ...
>
> Not quite. The provided reproducer uses the `@MultipartConfig` annotation.
Therefore, for that configuration, it is working as designed.
Not
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891416271
> * If you do not set the casualMultipartConfig or the @MultipartConfig
tomcat will complain when getParameters is called
That looks like a Tomcat bug but I need to confirm that. Ass
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891431758
> > * If you do not set the casualMultipartConfig or the @MultipartConfig
tomcat will complain when getParameters is called
>
> That looks like a Tomcat bug but I need to confirm that
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891481233
That error message suggests that the Acceptor either isn't unlocking at all
or isn't unlocking quickly enough. Can you run that test again with log level
set to `ALL`? That should point us
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891506680
@markt-asf did it using "one line formatter" and only copied from the http
request reception to the stop state to not flood with useless data:
https://gist.githubusercontent.com/rmannibu
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2889048692
@ChristopherSchultz I have implemented
https://github.com/apache/wicket/pull/1167
A way to get Wicket's support for upload with progress using work in this PR.
--
This is an
Chenjp opened a new pull request, #860:
URL: https://github.com/apache/tomcat/pull/860
RequestUtil#stripPathParams: enable support for multiple k=v pairs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
PauloMigAlmeida opened a new pull request, #861:
URL: https://github.com/apache/tomcat/pull/861
**Problem**
When creating a custom ``, developers may
also want to use their own `BlockingQueue` implementation instead of
the default `TaskQueue`.
While `ThreadPoolExecutor` accepts an
PauloMigAlmeida commented on PR #861:
URL: https://github.com/apache/tomcat/pull/861#issuecomment-2911914316
Thanks @markt-asf !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
markt-asf closed pull request #860: Fix issue on multiple path parameters
processing in RequestUtil
URL: https://github.com/apache/tomcat/pull/860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on PR #860:
URL: https://github.com/apache/tomcat/pull/860#issuecomment-2911642918
Thanks for the PR. I merged this manually as I wanted to modify the variable
naming slightly and add a couple of additional tests.
--
This is an automated message from the Apache Git Ser
markt-asf commented on PR #861:
URL: https://github.com/apache/tomcat/pull/861#issuecomment-2911655569
This looks to be a reasonable request. There are a few additional changes
that will also be required. I'll merge this. Make the additional changes and
then back-port the combination.
--
markt-asf merged PR #861:
URL: https://github.com/apache/tomcat/pull/861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2911737766
On my clean install, Tomcat correctly handles disabling of IPv4 via
`/proc/sys/net/ipv6/conf/all/disable_ipv6` at runtime.
All the indications are that an issue with your environment
markt-asf closed pull request #857: [fix] ensure that when acceptor is stopped
it doesn't log an error for nothing
URL: https://github.com/apache/tomcat/pull/857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rmaucher commented on PR #860:
URL: https://github.com/apache/tomcat/pull/860#issuecomment-2913059321
I verified this should not cause problems with the rewrite code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jmilktea opened a new pull request, #859:
URL: https://github.com/apache/tomcat/pull/859
As the title says, this is to facilitate troubleshooting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jmilktea commented on PR #859:
URL: https://github.com/apache/tomcat/pull/859#issuecomment-2900303902
Yes sir, the service will hang, but there is no log to help me find it
quickly. I need to find it through some other means. If there is a log, I can
find it at a glance, and it is reasonabl
rmaucher closed pull request #859: Acceptor & Poller Thread should print error
logs when it crashes now
URL: https://github.com/apache/tomcat/pull/859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmaucher commented on PR #859:
URL: https://github.com/apache/tomcat/pull/859#issuecomment-2900085331
I don't understand what this tries to do. If ExceptionUtils.handleThrowable
rethrows a fatal error, you will notice it.
--
This is an automated message from the Apache Git Service.
To res
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898190448
Fixed for 11.0.8 onwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
markt-asf closed pull request #856: allow users to plug in a ProgressListener
via some factory.
URL: https://github.com/apache/tomcat/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898290558
> Fixed for 11.0.8 onwards.
Saw the commit. Many thanks. Thus now applications can work as before. I
will test our application + Latest wicket 10.x against unreleased tomcat and
conf
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898611254
> > Fixed for 11.0.8 onwards.
>
> Saw the commit. Many thanks. Thus now applications can work as before. I
will test our application + Latest wicket 10.x against unreleased tomcat and
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2897627585
Looks like an OS issue (or more likely a network driver issue) since
`ifconfig` is reporting IPv6 addresses for a network adaptor when IPv6 is
disabled. I don't see that on my Ubuntu 25.04
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2897864027
@markt-asf not really, the issue is really on tomcat side and its any
handling at a time which is decoralated from the binding time. If using a
specific interface there is no issue but w
Chenjp commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2937920885
> Thanks. Fixing this did not seem to be a bad idea, but the proposed patch
seemed too convoluted. I did not add the test since encodeRedirectURL requires
a real session (and it is already te
markt-asf commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2938933585
@Chenjp You should look carefully at the implementation of
`encodeRedirectURL()` before you comment further.
--
This is an automated message from the Apache Git Service.
To respond to t
rmaucher commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2939013231
Servlet containers have to implement that (very complex) helper method that
does everything to achieve session tracking, depending on how the session
tracking was sent by the client, and th
Chenjp commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2939202088
> @Chenjp You should look carefully at the implementation of
`encodeRedirectURL()` before you comment further.
en...Current implementation checks session id source(COOKIES or
PathParam
cur1pro opened a new pull request, #864:
URL: https://github.com/apache/tomcat/pull/864
To fix the issue, we need to ensure that paths derived from
`entry.getName()` are validated to prevent directory traversal attacks. This
involves:
1. Normalizing the path using `java.nio.file.
markt-asf closed pull request #864: fix arbitrary file access during archive
extraction zipslip
URL: https://github.com/apache/tomcat/pull/864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
markt-asf commented on PR #864:
URL: https://github.com/apache/tomcat/pull/864#issuecomment-2939391552
Potential security vulnerabilities **DO NOT** belong in public pull requests.
Guidance on how to report security vulnerabilities responsibly can be found
at:
https://tomcat.apache
markt-asf commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2939822823
I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec for
markt-asf merged PR #863:
URL: https://github.com/apache/tomcat/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf merged PR #858:
URL: https://github.com/apache/tomcat/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
Chenjp opened a new pull request, #865:
URL: https://github.com/apache/tomcat/pull/865
It is not suitable to encode session id in URL if client support cookie.
per discuss in #862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Chenjp opened a new pull request, #863:
URL: https://github.com/apache/tomcat/pull/863
enable inline comment support for plain text rewrite map.
Per doc
[rewritemap.html#txt](https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html#txt)
:
```
# Comment line
MatchingKey Subs
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131953860
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131962779
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132131888
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
jfclere closed pull request #27: Test
URL: https://github.com/apache/tomcat-native/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
jfclere commented on PR #27:
URL: https://github.com/apache/tomcat-native/pull/27#issuecomment-2949193162
Oops sorry I am working on the next improvement...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jfclere opened a new pull request, #27:
URL: https://github.com/apache/tomcat-native/pull/27
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132132598
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2951104976
While this change makes sense to me, and it should be inexpensive for the
jdbc driver I am using (mysql-connector-java), I don't feel comfortable to add
this check unconditionally withou
markt-asf closed pull request #865: Enhance isEncodeable to determine putting
session id in URL using path parameter
URL: https://github.com/apache/tomcat/pull/865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
markt-asf commented on PR #865:
URL: https://github.com/apache/tomcat/pull/865#issuecomment-2943219506
This change is unnecessary. If cookies are supported, the original session
will have been created with a tracking cookie.
Irrespective of the above, if the client has, for whatever r
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945031973
Also reported: https://bz.apache.org/bugzilla/show_bug.cgi?id=66502
This bug is the only bug that has been bugging us; otherwise the pool works
flawlessly.
I wonder if you p
StudentGu opened a new pull request, #867:
URL: https://github.com/apache/tomcat/pull/867
In org.apache.coyote.Request#getCharsetHolder, when charsetHolder.getName()
returns null, parsing is performed repeatedly, resulting in unnecessary
performance overhead. The following optimizations are
StudentGu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961118047
@markt-asf @michael-o Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rmaucher closed pull request #867: Optimize Request#getCharsetHolder to avoid
repeated parsing when charset is null
URL: https://github.com/apache/tomcat/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962314501
@morning-gu Please don't ping specific members of this team to ask for a
review. Everyone is aware that this PR is here, and it will be reviewed when
these volunteers have time to
morning-gu commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139963921
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type
ChristopherSchultz commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139938437
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type ---
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962441562
This analysis looks correct to me, and the solution is staightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962444324
What does your flame graph look like after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962535411
> What does your flame graph look like after this change?
Sorry, I don't have a flame graph right now. I can capture one tomorrow.
--
This is an automated message from the Apache
ChristopherSchultz merged PR #867:
URL: https://github.com/apache/tomcat/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
rmaucher commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962991943
I think it is likely ok. I did not like it since it is backwards from the
original intent of the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to th
markt-asf commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2963154081
Looks reasonable to me. Needs a change log entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmaucher commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961464959
Why would the charset name be null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962026185
@rmaucher Please review and approve the workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961546330
> Why would the charset name be null ?
Because it is not included in the request headers, as shown below:
Content-Type=application/x-www-form-urlencoded
--
This is an automate
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961553998
reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
rmaucher commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966521488
Are you trying to fix a problem you noticed, or is this PR based on code
analysis ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
qingdaoheze commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966572313
Sorry. I don't understand what you mean. My issue is that the metrics in
org.apache.coyote.RequestGroupInfo#removeRequestProcessor is not counted
correctly when
org.apache.coyote.http2.
rmaucher closed pull request #868: recycle RequestInfo when Request is reused
in pool
URL: https://github.com/apache/tomcat/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
rmaucher commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966635424
Definitely this PR is wrong. RequestInfo is not the stats for an individual
request, so it should not be reset.
--
This is an automated message from the Apache Git Service.
To respond to
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964740795
> Looks reasonable to me. Needs a change log entry.
Thank you for the feedback. I have added a changelog entry to
webapps/docs/changelog.xml for this change.
--
This is an automa
qingdaoheze opened a new pull request, #868:
URL: https://github.com/apache/tomcat/pull/868
The request statistics will be wrong when Request object is reused in the
object pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964764619
> What does your flame graph look like after this change?
After optimization, the consumption of `Request#getCharsetHolder` is only
present during the first parsing. Subsequently, d
markt-asf commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2967321515
HTTP/2 is handled differently because of the multiplexing. We probably do
need a `recycle()` method on `RequestInfo`. It looks like it should be called
around line 440 (current 9.0.x code)
Chenjp opened a new pull request, #862:
URL: https://github.com/apache/tomcat/pull/862
redirect target url: append session id path parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942678690
> I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec f
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942917295
@markt-asf
This is just a simple question out of curiosity — doesn’t the Tomcat project
use Copilot for code reviews?
I’m a committer for the Seata project, and I’ve found that C
devjohnpark commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942968996
@markt-asf I agree that explicitly including the order in enum constant
names, like PHASE_0_NEW, enhances clarity without requiring HTTP/1.1 spec
knowledge. So I updated RequestLineParse
rmaucher commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2943043327
-1, let's keep an int instead. It works and nobody will change this code at
this point. If they do, they should have a good understanding of it.
--
This is an automated message from the A
rmaucher closed pull request #855: [Bug 69693] - Improve readability and type
safety by changing parsingRequestLinePhase to an enum in Http11InputBuffer
URL: https://github.com/apache/tomcat/pull/855
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rmaucher closed pull request #862: BZ 69699 - Propagate Session ID path
parameter during rewrite redirect
URL: https://github.com/apache/tomcat/pull/862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmaucher commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2934934189
Thanks. Fixing this did not seem to be a bad idea, but the proposed patch
seemed too convoluted. I did not add the test since encodeRedirectURL requires
a real session (and it is already te
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945093472
Cool, I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
markt-asf commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945085547
If you can address Chris's concerns with the test then I don't see why this
PR (or one based on it) could not be merged.
--
This is an automated message from the Apache Git Service.
To r
jfclere opened a new pull request, #26:
URL: https://github.com/apache/tomcat-native/pull/26
Use a github workflow to test a build on windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131934294
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
1901 - 2000 of 2013 matches
Mail list logo
