fmeheust commented on PR #677:
URL: https://github.com/apache/tomcat/pull/677#issuecomment-2718315476
Hi @aooohan and @ahai-code this contribution has been approved for a while,
is it possible to have an idea on when it will be comitted? Thank you!
--
This is an automated message from th
rmaucher commented on PR #810:
URL: https://github.com/apache/tomcat/pull/810#issuecomment-2700562654
Made changes to try it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher closed pull request #810: Ensure partial put data range not exceed
ContentRange declared
URL: https://github.com/apache/tomcat/pull/810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dsoumis commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657902498
The revised code, though less nested, adheres to the CORS flow as specified.
In my opinion, this structure offers a more maintainable and understandable
implementation.
Also the ordering
koust6u commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657908424
@n828cl
Which part do you find harder to follow? If you could clarify, it would help
me understand better.
I also believe that calling `isSameOrigin()` before `isValidOrigin()`
n828cl commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657751803
If this were to be merged, the CORS flowchart should be updated accordingly.
See
--
This is an automated mes
n828cl commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657748693
I'm not sure that the revised code properly implements the spec.
(Unfortunately, the current spec is much harder to follow than the previous
iteration.) Also, calling IsSameOrigin() before is
dsoumis merged PR #826:
URL: https://github.com/apache/tomcat/pull/826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
dsoumis commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658927616
Indeed Mark, that's a fair point. I've refactored the order as suggested in:
[commit](https://github.com/apache/tomcat/commit/e451872) .
--
This is an automated message from the Apache Git
markt-asf commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658848926
I echo n828cl's concerns about calling `isSameOrigin()` before
`isValidOrigin()`. I can't see an obvious issue but swapping the order of those
two checks is going to be a lot faster than d
markt-asf commented on PR #825:
URL: https://github.com/apache/tomcat/pull/825#issuecomment-2662781242
This is now working perfectly. Thanks to @rainerjung for all the effort put
into this. Being able to build Tomcat releases on MacOS without having to
install Wine means I can now easily re
markt-asf closed pull request #825: Replace wine by makensis for Linux and use
finalization to sign (un)installer
URL: https://github.com/apache/tomcat/pull/825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
dsoumis commented on PR #828:
URL: https://github.com/apache/tomcat/pull/828#issuecomment-2661457556
1) Please ensure that you run ant validate or use Checkstyle tool with the
checkstyle rules provided before submitting a PR. There are currently some
checkstyle errors in your import stateme
koust6u closed pull request #824: Prevention of Util Class Institution
URL: https://github.com/apache/tomcat/pull/824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
Chenjp commented on PR #823:
URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670515402
@rmaucher @markt-asf I have to talk here since previous vul report has been
rejected. I really think the target issue of this PR is a perfect match of
CWE-770 / CWE-400. ***```The product all
Hakky54 commented on PR #805:
URL: https://github.com/apache/tomcat/pull/805#issuecomment-2671109381
Hi @markt-asf any thoughts regarding this pr? Would love to get your
opinion/feedback as we have worked together on the other pr in the past
--
This is an automated message from the Apache
rmaucher commented on PR #823:
URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670663780
We answered this quite a few times already, so let's leave it at that. Write
enabled allows editing webapp contents, which is reserved to administrators.
--
This is an automated message f
rmaucher closed pull request #823: BZ69446 - add parameter maxPutFileSize in
DefaultServlet
URL: https://github.com/apache/tomcat/pull/823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Chenjp commented on PR #823:
URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670712406
Ok, final decision ups to you.
Write is reserved to administrators... If share this standard, would to know
your opinion on RCE
[CVE-2017-12617](http://cve.mitre.org/cgi-bin/cvename.c
Chenjp commented on PR #823:
URL: https://github.com/apache/tomcat/pull/823#issuecomment-2673452793
> > Rate limiter filter, or WAF can detect and block those requests.
>
> Either of those two can also provide the limits you are requesting, here.
Adding a feature to Tomcat which requi
koust6u commented on PR #828:
URL: https://github.com/apache/tomcat/pull/828#issuecomment-2681419698
Thank you for your valuable feedback and for providing the coverage report
link. I appreciate your insights on improving test coverage. I'll review the
uncovered code paths and work on addin
markt-asf commented on PR #828:
URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677681461
The code coverage of `AsyncStateMachine` is already fairly good. I'd prefer
to see some tests using real requests that exercised the few code paths
(excluding trace level logging and `Ille
rmaucher commented on PR #828:
URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677710733
BTW, the code coverage report is here:
https://nightlies.apache.org/tomcat/tomcat-12.0.x/coverage/index.html#dn-a
It can be generated using test.coverage=true property in build.properties
markt-asf closed pull request #821: BZ69504 move force recycle from log access
method
URL: https://github.com/apache/tomcat/pull/821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
markt-asf commented on PR #821:
URL: https://github.com/apache/tomcat/pull/821#issuecomment-2677711179
I share Rémy's concerns. I see multiple concerns being addressed in this PR.
Correct recycling is critical to the correct operation of Tomcat and log
still recycles the request/response
markt-asf closed pull request #814: log connectionId
URL: https://github.com/apache/tomcat/pull/814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-
markt-asf commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678517529
Manually applied as there were a few things I needed to add/change
- %{xxx}L is for ID attributes not connection attributes
- new settings needed to be added to the docs
- change lo
Dmole commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678622306
https://github.com/apache/tomcat/commit/3cfc9bc048109c5a566fc24539e5bb9759c114b6
https://github.com/apache/tomcat/commit/987f737afe4f08da939d870b5b1ec4b96010d926
--
This is an automa
bergander opened a new pull request, #830:
URL: https://github.com/apache/tomcat/pull/830
Fix info-then-debug logging in `Http2UpgradeHandler` by making the
`UserDataHelper` static. Otherwise the _lastInfoTime_ in `UserDataHelper` will
be per HTTP2-connection, but it should be a global scop
markt-asf commented on PR #830:
URL: https://github.com/apache/tomcat/pull/830#issuecomment-2679115250
Tx. Well-spotted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf merged PR #830:
URL: https://github.com/apache/tomcat/pull/830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
ChristopherSchultz commented on PR #823:
URL: https://github.com/apache/tomcat/pull/823#issuecomment-2671713171
> > The feedback was that this serves no purpose. I believe it is correct.
> > For processing of POST and some others like that, processing takes
memory. Also we do not know wha
Chenjp opened a new pull request, #829:
URL: https://github.com/apache/tomcat/pull/829
Discarding the file name case sensitivity of resource directory.
Detection of a directory case sensitivity is expansive, we have to create
file with different upper/lower case name and check result.
Chenjp commented on PR #820:
URL: https://github.com/apache/tomcat/pull/820#issuecomment-2670122793
+1
Since create a case sensitivity verification file is not a good idea, then
treats all as insensitive simply, remove the indicator.
see PR #829.
--
This is an automated message
Chenjp closed pull request #829: WebResource read/write lock key changed to in
lowercase arbitrarily
URL: https://github.com/apache/tomcat/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
adoroszlai commented on PR #2:
URL: https://github.com/apache/tomcat-tck/pull/2#issuecomment-2766744340
Thanks @markt-asf for merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ChristopherSchultz commented on code in PR #834:
URL: https://github.com/apache/tomcat/pull/834#discussion_r2020937294
##
java/org/apache/catalina/realm/DigestCredentialHandlerBase.java:
##
@@ -288,7 +289,7 @@ protected String mutate(String inputCredentials, byte[]
salt, int it
markt-asf merged PR #2:
URL: https://github.com/apache/tomcat-tck/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf merged PR #840:
URL: https://github.com/apache/tomcat/pull/840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
dependabot[bot] opened a new pull request, #69:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/69
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
Release notes
Sourced from https://github.com/actions/checkout/releases";>actions/checkout's
dependabot[bot] opened a new pull request, #70:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/70
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.0 to 4.2.3.
Release notes
Sourced from https://github.com/actions/cache/releases";>actions/cache's
rele
markt-asf merged PR #69:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf merged PR #71:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
dependabot[bot] opened a new pull request, #71:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/71
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to
4.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup
dependabot[bot] opened a new pull request, #72:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/72
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action)
from 3 to 5.
Release notes
Sourced from https://github.com/codecov/codecov-action/releases";>c
markt-asf merged PR #70:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf merged PR #68:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf merged PR #72:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
dependabot[bot] opened a new pull request, #68:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/68
Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent)
from 33 to 34.
Release notes
Sourced from https://github.com/apache/maven-apache-parent/release
markt-asf commented on PR #832:
URL: https://github.com/apache/tomcat/pull/832#issuecomment-2752080674
I like the idea. I don't think we have a list of ServletContext attributes
in a single place. The implementation needs a few tweaks to fit in with how we
build the Tomcat docs. I'll re-wor
dk2k commented on code in PR #834:
URL: https://github.com/apache/tomcat/pull/834#discussion_r2019811567
##
java/org/apache/catalina/realm/DigestCredentialHandlerBase.java:
##
@@ -288,7 +289,7 @@ protected String mutate(String inputCredentials, byte[]
salt, int iterations, in
rmaucher closed pull request #835: Changed string concatenations to chained
calls of append()
URL: https://github.com/apache/tomcat/pull/835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rmaucher commented on PR #835:
URL: https://github.com/apache/tomcat/pull/835#issuecomment-2757236637
Doing this should not be needed for constant strings (so the IDE does not
complain about it).
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
PaulLodge opened a new pull request, #841:
URL: https://github.com/apache/tomcat/pull/841
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
rmaucher commented on PR #841:
URL: https://github.com/apache/tomcat/pull/841#issuecomment-2773748095
Thanks ! Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rmaucher closed pull request #841: Added missing useCanonCaches define
URL: https://github.com/apache/tomcat/pull/841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
jengebr opened a new pull request, #842:
URL: https://github.com/apache/tomcat/pull/842
Enables optimized, non-standard behavior for the most common JSP tags, when
configured to do so.
**Unit tests pending**
**Off by default.**
When activated, the code generation to call `
felix-zhang-0818 commented on PR #849:
URL: https://github.com/apache/tomcat/pull/849#issuecomment-2868827471
From source code level.
if (isRequestThread(thread)) {
log.warn(sm.getString("webappClassLoader.stackTraceRequestThread",
getContextName(), threadName,
get
felix-zhang-0818 closed pull request #849: improve log context in order to add
thread name information.
URL: https://github.com/apache/tomcat/pull/849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ChristopherSchultz commented on PR #852:
URL: https://github.com/apache/tomcat/pull/852#issuecomment-2873354046
Taken care of by PR #851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ChristopherSchultz commented on PR #851:
URL: https://github.com/apache/tomcat/pull/851#issuecomment-2873353861
Taken care of by PR #851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ChristopherSchultz closed pull request #852: improve log context to add thread
name for webappClassLoader.stackTra…
URL: https://github.com/apache/tomcat/pull/852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ChristopherSchultz commented on PR #853:
URL: https://github.com/apache/tomcat/pull/853#issuecomment-2873354191
Taken care of by PR #851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ChristopherSchultz closed pull request #853: improve log context to add thread
name for webappClassLoader.stackTra…
URL: https://github.com/apache/tomcat/pull/853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ChristopherSchultz closed pull request #851: improve log context to add thread
name for webappClassLoader.stackTra…
URL: https://github.com/apache/tomcat/pull/851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
n828cl closed pull request #854: Refactor: Use enum for parsingRequestLinePhase
in Http11InputBuffer
URL: https://github.com/apache/tomcat/pull/854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
n828cl commented on PR #854:
URL: https://github.com/apache/tomcat/pull/854#issuecomment-2872651956
You can't seriously think that someone is going to even review, let alone
merge, a PR with 3,271 files changed...
Seems like a rebase is warranted first.
--
This is an automated mess
ChristopherSchultz merged PR #850:
URL: https://github.com/apache/tomcat/pull/850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
devjohnpark opened a new pull request, #854:
URL: https://github.com/apache/tomcat/pull/854
## Refactor `parsingRequestLinePhase` in `Http11InputBuffer` to use `enum
RequestLineParsePhase`
* Changed the type of the `parsingRequestLinePhase` field from `int` to
the `enum RequestLine
markt-asf commented on PR #850:
URL: https://github.com/apache/tomcat/pull/850#issuecomment-2875237568
There is a comment at the top of all of the non-English resource files that
states:
```
# Do not edit this file directly.
# To edit translations see:
https://tomcat.apache.org/get
devjohnpark opened a new pull request, #855:
URL: https://github.com/apache/tomcat/pull/855
## Refactor `parsingRequestLinePhase` in `Http11InputBuffer` to use `enum
RequestLineParsePhase`
* Changed the type of the `parsingRequestLinePhase` field from `int` to
the `enum RequestLine
ChristopherSchultz commented on PR #850:
URL: https://github.com/apache/tomcat/pull/850#issuecomment-2877047878
Oh, sorry @markt-asf I forgot about POEditor.com. I'll coordinate off-line
about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
reiern70 opened a new pull request, #856:
URL: https://github.com/apache/tomcat/pull/856
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
rmannibucau opened a new pull request, #857:
URL: https://github.com/apache/tomcat/pull/857
Proposal to have a clean shutdown (follow up of the mail on the list).
This only handles the case bindOnInit=false.
--
This is an automated message from the Apache Git Service.
To respond to
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2894390398
Personally, I think this PR is worth reviewing!
Using enums is definitely easier to understand than using integers like `0`
and `1`.
--
This is an automated message from the Apache Gi
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2894460535
@markt-asf hmm, think it is current status:
tomcat does:
> ServerSocketChannel.open()
which ends in
> ServerSocketChannelImpl(SelectorProvider sp) throw
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893802873
Just downloading the iso to try and reproduce this. Any networking
configured beyond the default using DHCP such as a VPN?
--
This is an automated message from the Apache Git Service.
To
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893807955
@markt-asf no vpn, just a plain default setup with this /etc/hosts:
```
127.0.0.1 localhost local.dev
127.0.1.1 romain
# The following lines are desirable for IPv6 capa
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893783262
Interesting, so adding `-Djava.net.preferIPv4Stack=true` i do not have the
error anymore and indeed the error seems to come from the fact i'm using
"localhost" so i enter into `localAddr
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893829754
@markt-asf any reason to not enforce family in
org.apache.tomcat.util.net.NioEndpoint#initServerSocket based on addr ? updated
the PR in that sense
--
This is an automated message fro
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893838723
May have unintended consequences for dual-stack systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893704284
Tx. That helps. The unlock is trying to use an IPv6 address to unlock the
Acceptor which Tomcat doesn't appear to be listening on. I'll see if I can
reproduce this but if I can't, I'll add
rainerjung commented on PR #858:
URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895052975
Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same
two separators, that JvmOptions can use. Namely ";" and "#". Currently we use
";" for JvmOptions and "#" for Jvm
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2895192922
I'm very reluctant to make changes until I understand the root cause of an
issue - especially in an area such as networking where there can be subtle
behaviour differences across platforms
mhoffrog commented on PR #858:
URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895493402
> Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same
two separators, that JvmOptions can use. Namely ";" and "#". Currently we use
";" for JvmOptions and "#" for Jvm
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099371131
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLo
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2896763570
Thanks for the `ifconfig` output. Configuration seems very similar. I
installed Docker in case that was a factor but that didn't help trigger the
issue. I still can't recreate this issue.
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099684597
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoa
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099821491
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLo
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099778013
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoa
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2897398231
> Apart from exceptional circumstances, Tomcat does not attempt to work
around bugs in other components or OS configuration issues. This is a design
decision to avoid bloat.
well
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2896993852
@markt-asf you nailed it, after way deeper investigation I realized ipv6 was
bound but only ipv4 (all) were working. It led me to checking some conf os.
gai.conf was plain default so not
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099737527
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLo
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099932516
##
bin/catalina.bat:
##
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set
LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoa
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2889918221
This appears to be addressing a symptom (various error messages) rather than
the cause (no local address available to unlock the `Acceptor`). We should be
looking at the root cause. What c
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890201043
@ChristopherSchultz any chances to get this PR merged into Tomcat 11?
- Any other work to be done from my side?
- Add tests?
- Back-port this to previous tomcat versions?
rmaucher commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890245052
Personally I am not a fan at all right now:
- About the way it is hooked in Request and esp ApplicationContext.
- It changes fileupload, which is a separate component (fileupload would
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890250497
See https://github.com/jakartaee/servlet/issues/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmaucher commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890282071
Let's see how the feature proposal progresses first then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890315507
> Personally I am not a fan at all right now:
>
Ok.
> * About the way it is hooked in Request and esp ApplicationContext.
I'm totally new to Tomcat code-base. I tried to
1801 - 1900 of 2012 matches
Mail list logo
