markt-asf commented on PR #821: URL: https://github.com/apache/tomcat/pull/821#issuecomment-2677711179
I share Rémy's concerns. I see multiple concerns being addressed in this PR. Correct recycling is critical to the correct operation of Tomcat and log still recycles the request/response in some circumstances. I'm not against refactoring to make the code cleaner and/or clearer but this needs to be done in small steps that can be verified as the refactoring progresses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org