dk2k commented on code in PR #834:
URL: https://github.com/apache/tomcat/pull/834#discussion_r2019811567
##########
java/org/apache/catalina/realm/DigestCredentialHandlerBase.java:
##########
@@ -288,7 +289,7 @@ protected String mutate(String inputCredentials, byte[]
salt, int iterations, in
* @return <code>true</code> if the strings are equal to each other,
<code>false</code> otherwise.
*/
public static boolean equals(final String s1, final String s2, final
boolean ignoreCase) {
- if (s1 == s2) {
+ if (Objects.equals(s1, s2)) {
Review Comment:
memory adresses are compared here instead of string values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
