reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890315507
> Personally I am not a fan at all right now: > Ok. > * About the way it is hooked in Request and esp ApplicationContext. I'm totally new to Tomcat code-base. I tried to solve a problem. If the way I did it is not correct then I'm all ears about changing code in the right way. > * It changes fileupload, which is a separate component (fileupload would need to accept the changes). What shall I do with respect to this? > * This capability if desired should probably be added to the Servlet specification itself. I do agree about adding this to specification... But way Tomcat behaves now is not good because: 1. if someone calls getParameter then the application will not be able to call getInputStream and parse it (in this case Wicket and fileupload2) 2. I managed to get our application working (upload + upload progress) by hunting down all calls to getParameter (in wicket and our application). 3. Solution in 2 is very fragile. A web applications are normally a stack of filters... One filter calls getParameter before Wicket filter and our application will suddenly fail. My fear is version X of a third party filter works Ok. Then we upgrade to version X + 1 and this new filter now calls getParameters and our application will be broken and we don't know why. We will also need to monitor how we develop in our application just not to break uploads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
