markt-asf merged PR #795:
URL: https://github.com/apache/tomcat/pull/795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
ChristopherSchultz commented on PR #799:
URL: https://github.com/apache/tomcat/pull/799#issuecomment-2546981057
Aw.
Mark, I was actually going to encourage this kind of thing _as long as it's
constructive_.
In this particular case, it seems like a change just for the sake of a
markt-asf commented on PR #794:
URL: https://github.com/apache/tomcat/pull/794#issuecomment-2545878413
You can't remove methods from the `RateLimiter` interface as it been
included in a stable release.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Chenjp commented on PR #794:
URL: https://github.com/apache/tomcat/pull/794#issuecomment-2545394554
minimize API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Chenjp commented on PR #794:
URL: https://github.com/apache/tomcat/pull/794#issuecomment-2548168272
> You can't remove methods from the `RateLimiter` interface as it been
included in a stable release.
Updated
--
This is an automated message from the Apache Git Service.
To respond
Chenjp commented on PR #802:
URL: https://github.com/apache/tomcat/pull/802#issuecomment-2552561603
It’s confusing.
When clients send Options request later , delete method will still on the
available table.
--
This is an automated message from the Apache Git Service.
To respond to the
Chenjp opened a new pull request, #802:
URL: https://github.com/apache/tomcat/pull/802
Since allowed methods check has been performed previously, failure status
code switch to 409 / SC_CONFLICT.
Root cause may be insufficient privileges, OS file locking, or already
deleted by another
adoroszlai commented on PR #2:
URL: https://github.com/apache/tomcat-tck/pull/2#issuecomment-2549076448
@markt-asf could you please help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmaucher closed pull request #802: for delete failure case, respond with
SC_CONFLICT rather than SC_METHOD_NOT_ALLOWED
URL: https://github.com/apache/tomcat/pull/802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rmaucher commented on PR #802:
URL: https://github.com/apache/tomcat/pull/802#issuecomment-2550963853
Changing things just for the sake of it is not a good plan. The return code
is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
markt-asf commented on issue #61:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/61#issuecomment-2540159056
Thanks for the confirmation. I'll close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mattnelson commented on issue #61:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/61#issuecomment-2539828768
Turns out it was not necessary to transform those files. We had previously
manually updated the file while working through some issues, and incorrectly
made the as
adoroszlai opened a new pull request, #2:
URL: https://github.com/apache/tomcat-tck/pull/2
## What changes were proposed in this pull request?
Fix repository definitions:
1. prefer `central`, not `repository.apache.org`
2. `asf-snapshots` does not have release artifacts
Chenjp commented on PR #802:
URL: https://github.com/apache/tomcat/pull/802#issuecomment-2554376773
> Changing things just for the sake of it is not a good plan. The return
code is acceptable.
@rmaucher cause inconsistent allowed methods with Options results.
--
This is an automate
ChristopherSchultz commented on PR #764:
URL: https://github.com/apache/tomcat/pull/764#issuecomment-2491096139
The Servlet 6.2 spec doesn't actually exist yet... at least not in any
published form.
That reference is speculative, assuming that the work being done here will
ultimately
Chenjp commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853835909
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
markt-asf closed pull request #784: enhanced http/2 early hints behavior
URL: https://github.com/apache/tomcat/pull/784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
markt-asf commented on code in PR #782:
URL: https://github.com/apache/tomcat/pull/782#discussion_r1854564015
##
java/org/apache/catalina/servlets/DefaultServlet.java:
##
@@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) {
(range.getEnd
markt-asf closed pull request #785: Http11Processor minor change - magic int
103 to HttpServletResponse.SC_EARLY_HINTS
URL: https://github.com/apache/tomcat/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
markt-asf commented on PR #785:
URL: https://github.com/apache/tomcat/pull/785#issuecomment-2494595319
I've committed a change that replaces both uses of the 103 literal with the
constant from the Servlet API.
--
This is an automated message from the Apache Git Service.
To respond to the
markt-asf commented on PR #784:
URL: https://github.com/apache/tomcat/pull/784#issuecomment-2494596877
The acceptable changes of this PR (literal 103 to constant) have been
applied separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Chenjp commented on PR #782:
URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495274861
> I'd like to see similar protection for `Content-Range` when used with
partial `PUT`.
@markt-asf done with PR #778
--
This is an automated message from the Apache Git Service.
To r
Chenjp commented on PR #782:
URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495275038
> I'd like to see similar protection for `Content-Range` when used with
partial `PUT`.
@markt-asf done with PR #778
--
This is an automated message from the Apache Git Service.
To r
markt-asf commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853843378
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
Chenjp commented on PR #790:
URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516095894
Since the ***Range Requests*** feature is optional, may a reason stand there.
This feature affects the "Accept-Range" header of responses, and server
behavior for requests (with "Range“, "I
Chenjp opened a new pull request, #795:
URL: https://github.com/apache/tomcat/pull/795
Document of DefaultServlet - correct the referenced RFC spec number about
partial PUT - a PUT with Content-Range Header.
The original text of ***RFC7231*** #4.3.4 (which is obsoleted by RFC9110):
A
Chenjp opened a new pull request, #804:
URL: https://github.com/apache/tomcat/pull/804
comply [rfc 9110 Section
15.5.6.](https://httpwg.org/specs/rfc9110.html#status.405) 405 Method Not
Allowed:
The origin server ***MUST*** generate an
***[Allow](https://httpwg.org/specs/rfc9110.htm
Chenjp opened a new pull request, #803:
URL: https://github.com/apache/tomcat/pull/803
In GeneratorVisitor#generateIncludeWithParameters, since we introduce an
extra variable urlVariableName to store include page param, then we need
explicit specify literal=false when call #printParams.
-
markt-asf merged PR #63:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf merged PR #66:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
Chenjp commented on PR #810:
URL: https://github.com/apache/tomcat/pull/810#issuecomment-2608927392
As expected:
```
curl -i http://localhost:1080/uploads/size-1.dat -X PUT -H "Content-Range:
Bytes 0-0/1" -d 11
```
HTTP/1.1 201 Created
```
curl -i http://localh
rmaucher commented on code in PR #753:
URL: https://github.com/apache/tomcat/pull/753#discussion_r1926753242
##
java/org/apache/catalina/valves/ParameterLimitValve.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
Dmole opened a new pull request, #811:
URL: https://github.com/apache/tomcat/pull/811
Every log relating to data sent from a connection should log the IP for
fail2ban etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
markt-asf commented on code in PR #811:
URL: https://github.com/apache/tomcat/pull/811#discussion_r1933498993
##
java/org/apache/coyote/http2/Http2Parser.java:
##
@@ -327,7 +329,7 @@ protected void readSettingsFrame(int flags, int
payloadSize, ByteBuffer buffer)
markt-asf merged PR #804:
URL: https://github.com/apache/tomcat/pull/804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
Chenjp opened a new pull request, #810:
URL: https://github.com/apache/tomcat/pull/810
Ensure updated content size not exceeds bounds ***(end-start+1)*** declared
by Content-Range header.
For backwards compatibility, just discard the rest part instead of a sending
400.
--
This is
Chenjp commented on PR #808:
URL: https://github.com/apache/tomcat/pull/808#issuecomment-2606566775
> This is trivial, mostly already tested, so I did not bother adding them.
en... the bug stayed there over a decade until my code review.
Existing special path testcase (TestWebda
adwsingh commented on PR #812:
URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623018669
My use case is I want to avoid having to convert byte to String on repeated
invocation of
[MimeHeaders.getHeader](https://github.com/apache/tomcat/blob/main/java/org/apache/tomcat/util/http
rmaucher closed pull request #812: Forward toString in MessageBytes toStringType
URL: https://github.com/apache/tomcat/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmaucher commented on PR #812:
URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623028916
toStringType changes the MB type. toString does not.
This should indicate that it is wise to not change the MB type in some
cases. There's a long history with these changes, you should lo
adwsingh commented on PR #812:
URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623032339
@rmaucher in that case is the proposal in my comment acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adwsingh commented on PR #812:
URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623032404
@rmaucher in that case is the proposal in my comment acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adwsingh opened a new pull request, #813:
URL: https://github.com/apache/tomcat/pull/813
This is to avoid having to convert from Bytes to String again for the same
header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
adwsingh opened a new pull request, #812:
URL: https://github.com/apache/tomcat/pull/812
toString doesn't check if the value hasn't been cached and toStringType does
it. I couldn't find a reason not to do the same for toString
--
This is an automated message from the Apache Git Service.
T
markt-asf commented on PR #811:
URL: https://github.com/apache/tomcat/pull/811#issuecomment-2621914508
I have relatively little tolerance for PRs that fail to compile. I have even
less tolerance for PRs that still fail to compile after this problem has been
pointed out once.
Logging
Chenjp opened a new pull request, #806:
URL: https://github.com/apache/tomcat/pull/806
maxSwallowSize is semantically equivalent to max file size of upload file
size. Send 413 when length of Content-Range request exceeds maxSwallowSize.
--
This is an automated message from the Apache Git
rmaucher closed pull request #806: fix BZ 69446 - Propagate maxSwallowSize to
enforce partial PUT request target file size
URL: https://github.com/apache/tomcat/pull/806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rmaucher commented on PR #806:
URL: https://github.com/apache/tomcat/pull/806#issuecomment-2586420543
As per the response in the BZ, we're not going to address this (esp not
using an unrelated configuration setting).
--
This is an automated message from the Apache Git Service.
To respond
Chenjp commented on PR #806:
URL: https://github.com/apache/tomcat/pull/806#issuecomment-2586425470
> As per the response in the BZ, we're not going to address this (esp not
using an unrelated configuration setting).
Per message from apache httpd team:
```
It's true that mod_dav
Chenjp commented on PR #803:
URL: https://github.com/apache/tomcat/pull/803#issuecomment-2589141931
@markt-asf @rmaucher Suggest fix the BZ in next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf closed pull request #803: Fix BZ69508 - Javasource generator -
explicitly set literal false when call printParams to process jsp include page
URL: https://github.com/apache/tomcat/pull/803
--
This is an automated message from the Apache Git Service.
To respond to the message, please
markt-asf commented on PR #803:
URL: https://github.com/apache/tomcat/pull/803#issuecomment-2590746042
Tx for the PR.
Merged manually so I could make some minor changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Chenjp commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592561309
> I see a few things to cleanup as well.
+1.
rename method is better.
about testcase: pls try to cover allowSpecialPaths and nonroot webdav path.
Current testcase is not enoug
rmaucher commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592078702
Ok, the check should be similar to what it is in StandardContextValve. I
won't rename the method however, and I see a few things to cleanup as well.
--
This is an automated message from t
rmaucher commented on PR #808:
URL: https://github.com/apache/tomcat/pull/808#issuecomment-2594731714
This is trivial, mostly already tested, so I did not bother adding them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rmaucher closed pull request #809: Fix memory leak in CrawlerSessionManagerValve
URL: https://github.com/apache/tomcat/pull/809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmaucher commented on PR #809:
URL: https://github.com/apache/tomcat/pull/809#issuecomment-2598084629
This is a leftover following a refactoring and got unnoticed. I added a test
fix and the changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf merged PR #65:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf closed pull request #60: matchExcludesAgainstPathName not match with
absolutePath and no rewrite file if not changed
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
markt-asf merged PR #67:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf commented on PR #60:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/60#issuecomment-2577235590
I've manually applied the `matchExcludesAgainstPathName`. Please open a new
PR for the modification changes.
--
This is an automated message from the Apache Git Servic
markt-asf commented on PR #57:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/57#issuecomment-2577262511
Note this migrates both the Servlet and the JSP APIs but given the
dependency of JSP on Servlet that seems perfectly reasonable to me.
--
This is an automated message
markt-asf merged PR #64:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf merged PR #57:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
Chenjp opened a new pull request, #807:
URL: https://github.com/apache/tomcat/pull/807
1. fix: "/web-information.xml" is not a special path.
2. method name refactoring: from isSpecialPath to checkSpecialPath.
--
This is an automated message from the Apache Git Service.
To respond to th
rmaucher closed pull request #807: Webdav special path handling fix
URL: https://github.com/apache/tomcat/pull/807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
rmaucher commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592187806
I did not pick up the test since it doesn't add much.
Also because of:
File appDir = new File(getBuildDirectory(), "webapps" + contextPath);
try (FileWriter fw = new
koust6u opened a new pull request, #826:
URL: https://github.com/apache/tomcat/pull/826
This PR refactors the checkRequestType method in the CORS filter to simplify
and improve the readability of the request type determination logic. The main
changes are:
+ Early Returns: The code ha
dsoumis commented on PR #827:
URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661100096
1) I am not in favor of the helper class. Conditions like if
(log.isDebugEnabled()) and if (log.isTraceEnabled()) are widely used in the
code and I believe it makes it more transparent when
koust6u closed pull request #827: Refactor CSRF Filter: Simplify Logic, Improve
Logging, and Enhance Code Readability
URL: https://github.com/apache/tomcat/pull/827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
koust6u commented on PR #827:
URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661166088
Thank you for the thorough review and detailed feedback. I now understand
your concerns regarding the logging helper and the importance of explicitly
showing when logging occurs. Your point
koust6u opened a new pull request, #828:
URL: https://github.com/apache/tomcat/pull/828
+ Added unit tests for various asyncPostProcess state transitions.
+ Replaced dependencies with fake objects for isolated testing.
--
This is an automated message from the Apache Git Service.
To resp
ChristopherSchultz commented on PR #825:
URL: https://github.com/apache/tomcat/pull/825#issuecomment-2651887736
> Worked perfectly. Release built and signed on Linux without wine. Build
100% reproducible on Windows. Signatures good. Installer and uninstaller work
perfectly. That was only wi
markt-asf commented on PR #825:
URL: https://github.com/apache/tomcat/pull/825#issuecomment-2652853678
Yes, I had to build makensis from source - but that was trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
markt-asf commented on PR #832:
URL: https://github.com/apache/tomcat/pull/832#issuecomment-2735585039
If you mention one request attribute you should mention them all. You might
need a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
usmazat commented on PR #832:
URL: https://github.com/apache/tomcat/pull/832#issuecomment-2741217016
> If you mention one request attribute you should mention them all. You
might need a table.
I put together a table of attributes. wasn't sure where to put it so I
created a separate x
usmazat opened a new pull request, #832:
URL: https://github.com/apache/tomcat/pull/832
Added a paragraph in the Parallel deployment section of Tomcat docs to
include an example of getting current webappVersion via property
Original example was provided by @ChristopherSchultz
--
Thi
dependabot[bot] opened a new pull request, #74:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/74
Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco)
from 0.8.12 to 0.8.13.
Release notes
Sourced from https://github.com/jacoco/jacoco/releases";>o
rmaucher commented on PR #833:
URL: https://github.com/apache/tomcat/pull/833#issuecomment-2755690885
The purpose of the code is to check the configuration. For clarity, I would
like to keep it that way.
--
This is an automated message from the Apache Git Service.
To respond to the messag
rmaucher closed pull request #833: [optimization] Removed unused code
URL: https://github.com/apache/tomcat/pull/833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
rmaucher closed pull request #834: Changed string comparison - need to use
equals() instead of == or !=
URL: https://github.com/apache/tomcat/pull/834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dk2k opened a new pull request, #833:
URL: https://github.com/apache/tomcat/pull/833
the result of call Pattern.compile() isn't used. Variable int flags is
redundant as a result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dk2k commented on PR #834:
URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755612999
@rmaucher Purpose like what? == comparison is OK when both strings are
interned, and I don't think it's the case.
And it's safe to use equals() for interned strings anyway
--
This is an a
dk2k opened a new pull request, #835:
URL: https://github.com/apache/tomcat/pull/835
Justification: each string concatenation becomes an anonimous stringbuilder,
from which toString() result is used.
It's about performance.
--
This is an automated message from the Apache Git Service.
T
markt-asf commented on PR #834:
URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755623844
There should be an explanation for each of those in the spot bugs exclusion
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dk2k opened a new pull request, #834:
URL: https://github.com/apache/tomcat/pull/834
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
rmaucher commented on PR #834:
URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755594755
This is most likely on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf closed pull request #832: Expanding Parallel Deployment section of
Tomcat Docs
URL: https://github.com/apache/tomcat/pull/832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
markt-asf commented on PR #832:
URL: https://github.com/apache/tomcat/pull/832#issuecomment-2753632042
Nothing to do on your part. Thanks for the work you put into this. I've
added a new runtime attribute section to the configuration documentation that
documents the request and servlet cont
usmazat commented on PR #832:
URL: https://github.com/apache/tomcat/pull/832#issuecomment-2753348292
> I like the idea. I don't think we have a list of ServletContext attributes
in a single place. The implementation needs a few tweaks to fit in with how we
build the Tomcat docs. I'll re-wor
Hakky54 commented on PR #805:
URL: https://github.com/apache/tomcat/pull/805#issuecomment-2760505261
Amazing, thank you mate. I really appreciate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
markt-asf commented on PR #805:
URL: https://github.com/apache/tomcat/pull/805#issuecomment-2760402109
Thanks for the PR. I applied it manually so I could add a few Javadoc
comments and a change log entry.
--
This is an automated message from the Apache Git Service.
To respond to the mess
markt-asf closed pull request #805: Simplify usage of custom ssl configuration
URL: https://github.com/apache/tomcat/pull/805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
funkman commented on PR #842:
URL: https://github.com/apache/tomcat/pull/842#issuecomment-2794610781
While only targeting `c:set/c:remove` - Do you also need to check the tag
belongs to `http://java.sun.com/jsp/jstl/core` ? I suspect the user
wouldn't enable the flag then use a different li
jengebr commented on PR #842:
URL: https://github.com/apache/tomcat/pull/842#issuecomment-2794646560
> While only targeting `c:set/c:remove` - Do you also need to check the tag
belongs to `http://java.sun.com/jsp/jstl/core` ? I suspect the user
wouldn't enable the flag then use a different
jbampton opened a new pull request, #73:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/73
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
codecov-commenter commented on PR #73:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/73#issuecomment-2769595942
##
[Codecov](https://app.codecov.io/gh/apache/tomcat-jakartaee-migration/pull/73?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=
rmaucher commented on PR #839:
URL: https://github.com/apache/tomcat/pull/839#issuecomment-2769705121
I don't agree with using PRs for trivial fixes like this. A committer has to
do them (in batches, like I did), otherwise it creates a mountain of spam (and
CI runs, and so on).
--
This i
jbampton opened a new pull request, #839:
URL: https://github.com/apache/tomcat/pull/839
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
jbampton opened a new pull request, #837:
URL: https://github.com/apache/tomcat/pull/837
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
1601 - 1700 of 2012 matches
Mail list logo
