koust6u commented on PR #827: URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661166088
Thank you for the thorough review and detailed feedback. I now understand your concerns regarding the logging helper and the importance of explicitly showing when logging occurs. Your point about the removal of else blocks making the code harder to analyze also makes sense, especially given that early returns were not applied consistently. Additionally, I see the issue with the filter being invoked twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
