dsoumis commented on PR #827: URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661100096
1) I am not in favor of the helper class. Conditions like if (log.isDebugEnabled()) and if (log.isTraceEnabled()) are widely used in the code and I believe it makes it more transparent when the logging occurs. 2) Since early returns (guard clauses) are not applied to all conditions, removing the else blocks makes the code harder to analyze. 3) The filter is being invoked twice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
