koust6u opened a new pull request, #826: URL: https://github.com/apache/tomcat/pull/826
This PR refactors the checkRequestType method in the CORS filter to simplify and improve the readability of the request type determination logic. The main changes are: + Early Returns: The code has been simplified to return early for various conditions (e.g., invalid CORS requests, same-origin requests, missing or invalid headers). This reduces nesting and enhances readability. + Consolidation of Conditions: Some conditional blocks that check for empty or invalid headers were merged to avoid redundant checks, making the code more concise. + Improved Flow: The logic now more clearly distinguishes between the different CORS request types by handling the OPTIONS method, GET/HEAD methods, and POST method (with content type checks) in a more straightforward manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
