tcnative documentation is broken on tomcat.apache.org

2012-06-07 Thread Christopher Schultz
All, http://tomcat.apache.org/native-doc/ It says that tcnative 2.0.0 has been released, has no date, and links to non-existent files. Same thing with http://tomcat.apache.org/native-doc/news/2010.html Can someone take a look? -chris signature.asc Description: OpenPGP digital signature

Re: tcnative documentation is broken on tomcat.apache.org

2012-06-11 Thread Christopher Schultz
Konstantin, On 6/7/12 5:49 PM, Konstantin Kolinko wrote: > 2012/6/8 Konstantin Kolinko : >> 2012/6/8 Christopher Schultz : >>> All, >>> >>> http://tomcat.apache.org/native-doc/ >>> >>> It says that tcnative 2.0.0 has been released, has no d

Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Christopher Schultz
Mark, On 6/11/12 5:24 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 11 09:24:53 2012 > New Revision: 1348762 > > URL: http://svn.apache.org/viewvc?rev=1348762&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 > Stepping through the code, light dawns as t

[OT] Subversion and recording bugzilla bug ids

2012-06-14 Thread Christopher Schultz
All, Since I know we've got some infra folks on this list but I'm not on the infra mailing list, I hope nobody minds if I ask here: When I do an svn commit to the ASF repository, one of the options (in Eclipse) is to provide a Bugzilla bug id. Can anyone tell me what svn plug-in (or whatever) is

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-18 Thread Christopher Schultz
Mark, On 6/15/12 1:00 PM, Mark Thomas wrote: > Since this is fairly major work, any objections before I start? I like the unification of all these things. Would this be a good time to consider making Tomcat 7 RTC with such a significant change to the core of the trunk? -chris signature.asc De

[OT] Moving entire directory structures in svn

2012-06-25 Thread Christopher Schultz
All, I apologize for another OT post to the dev list, but I know there are svn experts here and it's somewhat relevant. I have a project, recently migrated from CVS to SVN, and one of the things I'd like to be able to do that I couldn't do in CVS is to re-name files and do it all in one Big Commi

Re: [OT] Moving entire directory structures in svn

2012-06-25 Thread Christopher Schultz
Mark, On 6/25/12 12:45 PM, Mark Thomas wrote: > On 25/06/2012 17:42, Christopher Schultz wrote: >> $ mkdir src/newpackage >> $ svn add src/newpackage > > Skip the above 2 lines I'm actually introducing a new directory into the mix -- not just renaming but also putting

Get-and-set with JMXProxyServlet

2012-07-03 Thread Christopher Schultz
All, I have a slight interest in implementing either a get-and-set or get-and-invoke (or both) in JMXProxyServlet. While it is easy to script get-then-set (or get-then-invoke), I'd like to be able to, with a single URL, get one value and (for example) reset the value to zero (or call something lik

Missing classes in stock 5.5.35 JARs?

2012-07-11 Thread Christopher Schultz
All, http://stackoverflow.com/questions/11427522/ssl-configuration-getting-classpuretlsimplementation-jsse15factory-not-foun The SO poster is using 5.5.30 but the problem appears to still exist in 5.5.35 (latest). I downloaded the "core" Tomcat 5.5.35 tarball and none of the .jar files in there

Re: svn commit: r1371678 - in /tomcat/tc6.0.x/trunk: 53531.diff java/org/apache/catalina/startup/LocalStrings.properties src/

2012-08-10 Thread Christopher Schultz
Konstantin, On 8/10/12 8:07 AM, kkoli...@apache.org wrote: > Author: kkolinko > Date: Fri Aug 10 12:07:37 2012 > New Revision: 1371678 > > URL: http://svn.apache.org/viewvc?rev=1371678&view=rev > Log: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 > Followup to r1371355. > Add missing

Re: svn commit: r1372002 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-08-12 Thread Christopher Schultz
Konstantin, On 8/11/12 3:26 PM, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sat Aug 11 19:26:30 2012 > New Revision: 1372002 > > URL: http://svn.apache.org/viewvc?rev=1372002&view=rev > Log: > Update Christopher Schultz' proposal with an actual patch. >

Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
All, Recently, I have made a proposal or to to back-port changes into Tomcat 6. In one case, Konstantin has (helpfully!) provided a new patch based upon several changes to trunk/TC7. In this case, is it more appropriate to apply the single patch to TC6 and ignore those patches made to trunk, or s

Re: svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 9:06 AM, kkoli...@apache.org wrote: > Author: kkolinko > @@ -178,12 +161,14 @@ PATCHES PROPOSED TO BACKPORT: >Patch from 7.0.x should apply relatively cleanly, as it is very small: >http://svn.apache.org/viewvc?view=revision&revision=1041892 >

Re: Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 3:26 PM, Konstantin Kolinko wrote: > Regarding size of a patch: > > It is up to you. You do it in your own name. The lesser the patch the > lesser are chances to screw it. But if you feel that something needs > to be included as well, feel free to include it.

Re: error while shutting down tomcat

2012-08-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ijlal, On 8/14/12 6:18 PM, Ijlal EL HAZITI wrote: > I installed a wab application (sakai precisely) on a distant > server remotely, but it doesn't start, and when I shutdown tomcat, > I get that error: This is a question better targeted at the Tomcat

Re-factoring TLD parsing

2012-08-16 Thread Christopher Schultz
All, The first item in the TOMCAT-NEXT.txt is this: 1. Refactor the TLD parsing. TLDs are currently parsed twice. Once by Catalina looking for listeners and once by Jasper. I had a conversation in Vancouver with David Blevins about the scourge of JAR-scanning in general (in that case, we we

Re: Re-factoring TLD parsing

2012-08-16 Thread Christopher Schultz
Sebb, On 8/16/12 7:11 PM, sebb wrote: > On 16 August 2012 23:44, Christopher Schultz > wrote: >> >> I had a conversation in Vancouver with David Blevins about the scourge >> of JAR-scanning in general (in that case, we were discussing >> annotation-processing) and

Re: Tomcat + j_security_check (JDBCRealm) + salt / jBCrypt

2012-08-27 Thread Christopher Schultz
Salek, On 8/20/12 3:31 PM, Salek Talangi wrote: > Hi all, > > I just started using Tomcat+j_security_check (JDBCRealm) for Form-based > Webapp-Login. > I read [1] that only a few standard (MD5, SHA-1, MD2?) > java.security.MessageDigest methods are supported, which isn't enough in > times of (

Re: pooledconnection & tccl?

2012-08-27 Thread Christopher Schultz
Filip, On 8/22/12 9:12 AM, Filip Hanik (mailing lists) wrote: > I've thought about this, you see if it is using TCCL it will cause a memory > leak on app reload as the app wont be unloaded due to the pool holding it. > But I think we should make it an option It's always been my position that Data

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-27 Thread Christopher Schultz
Mark, On 8/27/12 5:36 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 > > Mark Thomas changed: > >What|Removed |Added > > Componen

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-28 Thread Christopher Schultz
Mark, On 8/27/12 7:57 PM, Mark Thomas wrote: > On 28/08/2012 00:53, Christopher Schultz wrote: >> Mark, > >> On 8/27/12 5:36 PM, bugzi...@apache.org wrote: >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 >>> >>> M

Re: Tomcat 5.5.36

2012-09-20 Thread Christopher Schultz
Jim, On 7/25/12 7:25 AM, Jim Jagielski wrote: > > On Jul 24, 2012, at 12:17 PM, Mark Thomas wrote: > >> On 24/07/2012 14:40, Jim Jagielski wrote: >>> Any interest in seeing a 5.5.36 release in the near future? >> >> We should to tie up the remaining loose ends before 5.5.x is EOL. No >> great ru

Re: to improve the performance of form-based upload for Tomcat 7

2012-09-25 Thread Christopher Schultz
Link, On 9/25/12 10:14 AM, Fastupload wrote: > What's the right org that I can apply a commuter account of apache > open source project? Committers are invited by the current group of active participants. The best way to be invited is to become active in the community (i.e. this mailing list an

Re: WebClassLoader using SystemClassLoader to load ServletDef?

2012-09-25 Thread Christopher Schultz
Elgs, On 9/25/12 1:15 PM, Elgs Chen wrote: > Hi Mark, > > I finally get my homework done. Thank you so much for pointing me to the > right direction. That really helped me to gain huge insight into the inner > world of the tomcat. > > I used JPDA to attach my eclipse to tomcat. Then I was able

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 5:16 AM, Mark Thomas wrote: > On 15/09/2012 23:02, Mark Thomas wrote: >> On 06/09/2012 16:02, schu...@apache.org wrote: >>> Author: schultz >>> Date: Thu Sep 6 15:02:42 2012 >>> New Revision: 1381633 >>> >>> URL: htt

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 12:16 PM, Christopher Schultz wrote: > Mark, > > On 10/2/12 5:16 AM, Mark Thomas wrote: >> On 15/09/2012 23:02, Mark Thomas wrote: >>> On 06/09/2012 16:02, schu...@apache.org wrote: >>>> Author: schultz >>>> Date: Thu Sep 6 15:02:

Re: svn commit: r1381635 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/changelog.xml webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 5:22 AM, Mark Thomas wrote: > On 08/09/2012 14:37, Mark Thomas wrote: >> On 08/09/2012 11:52, Konstantin Kolinko wrote: >>> 2012/9/6 : >>>> Author: schultz >>>> Date: Thu Sep 6 15:08:58 2012 >>>> New Revision: 1381635 >&g

Re: trunk: An buffer exception in AccessLogValve.log(..)

2012-10-02 Thread Christopher Schultz
Konstantin, On 10/2/12 2:32 PM, Konstantin Kolinko wrote: > Running current trunk + Nio connector + JDK 7u7, I see a lot of the > following exceptions. > > It looks like there is some bug in AccessLogValve optimization when > StringBuilder was replaced with a CharBuffer. > > A CharBuffer cannot

Re: trunk: An buffer exception in AccessLogValve.log(..)

2012-10-02 Thread Christopher Schultz
Konstantin, On 10/2/12 3:58 PM, Konstantin Kolinko wrote: > 2012/10/2 Christopher Schultz : >> Konstantin, >> >> On 10/2/12 2:32 PM, Konstantin Kolinko wrote: >>> Running current trunk + Nio connector + JDK 7u7, I see a lot of the >>> following exceptions.

Surprising implementation of SSL.hasOp

2012-10-03 Thread Christopher Schultz
All, I was preparing a 6.0 patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=53481 (Add support for OpenSSL SSLHonorCipherOrder) and I found a missing method SSL.hasOp that is used in trunk and 7.0. The javadoc for SSL.hasOp says: /** * Return true if SSL_OP_ if defined.

Re: Surprising implementation of SSL.hasOp

2012-10-03 Thread Christopher Schultz
Rainer, On 10/3/12 1:30 PM, Rainer Jung wrote: > On 03.10.2012 18:02, Christopher Schultz wrote: >> Looking at the OpenSSL API (wow, I really miss javadoc), it doesn't >> appear that there's any function that can sniff the capabilities of the >> engine and check to

Re: [VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Christopher Schultz
Mark, On 10/3/12 5:24 AM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.32 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.32/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/or

Re: [VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Christopher Schultz
All, On 10/3/12 3:01 PM, Christopher Schultz wrote: > I did however get a unit test failure: details below. I'll check to see > if it is repeatable. > > Testsuite: > org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak A second run of this test (BIO, NIO, APR)

Re: Surprising implementation of SSL.hasOp

2012-10-04 Thread Christopher Schultz
Rainer, On 10/3/12 2:49 PM, Christopher Schultz wrote: > I like the idea of using a macro to compact the code a bit, but in spite > of tcnative's use of macros that don't contain "arguments" for all data > that will be operated on, I prefer to be explicit about menti

Re: Surprising implementation of SSL.hasOp

2012-10-04 Thread Christopher Schultz
Rainer, On 10/4/12 5:27 PM, Rainer Jung wrote: > On 04.10.2012 23:14, Christopher Schultz wrote: >> For instance, we could use a technique similar to the above to set a >> static bitset: >> >> static int supported_ssl_opts = 0; >> >&

Re: svn commit: r1394452 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java java/overview.html xdocs/miscellaneous/changelog.xml

2012-10-05 Thread Christopher Schultz
Konstantin, On 10/5/12 7:33 AM, kkoli...@apache.org wrote: > Author: kkolinko > Date: Fri Oct 5 11:33:22 2012 > New Revision: 1394452 > > URL: http://svn.apache.org/viewvc?rev=1394452&view=rev > Log: > Followup to r1394343: Update javadoc for hasOp method. > It seems that is the only place where

Re: svn commit: r1394104 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2012-10-05 Thread Christopher Schultz
Konstantin, On 10/5/12 8:45 AM, Konstantin Kolinko wrote: > 2012/10/4 : >> Author: markt >> Date: Thu Oct 4 14:55:59 2012 >> New Revision: 1394104 >> >> URL: http://svn.apache.org/viewvc?rev=1394104&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 >> Provide optio

Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread Christopher Schultz
All, On 10/9/12 6:07 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 > > --- Comment #4 from Christopher Schultz --- > (In reply to comment #3) >> Possible cause: r1381417 > > Reverting that patch resolves the issue in 7.0.x/

Re: Time for 6.0.36?

2012-10-10 Thread Christopher Schultz
Mark, On 10/10/12 11:04 AM, Mark Thomas wrote: > It has been just over 10 months since the last 6.0.x release. The change > log is looking pretty lengthy. I think we need a release. If it's likely that there will be a long interval before the following release, I think I'd like to complete my wor

Re: Time for 6.0.36?

2012-10-11 Thread Christopher Schultz
Konstantin, On 10/11/12 6:47 AM, Konstantin Kolinko wrote: > 2012/10/10 Mark Thomas : >> It has been just over 10 months since the last 6.0.x release. The change >> log is looking pretty lengthy. I think we need a release. >> > > +1 > > 2012/10/10 Christopher

Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml

2012-11-17 Thread Christopher Schultz
Mark, Apologies for the late reply. Please see comments inline. On 11/13/12 9:17 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Nov 13 14:17:42 2012 > New Revision: 1408739 > > URL: http://svn.apache.org/viewvc?rev=1408739&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bu

Re: Delete catalina.out

2012-11-17 Thread Christopher Schultz
Josh, On 11/15/12 2:45 PM, Josh Gooding wrote: > That is the tomcat default log file. Nothing server wise will happen if > you delete if that is your concern. It just removes that particular log > file. I believe that you have to either be root and/or have the server > stopped to remove the fil

Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml

2012-11-17 Thread Christopher Schultz
Mark, On 11/17/12 8:04 PM, Christopher Schultz wrote: > Apologies for the late reply. Please see comments inline. > > On 11/13/12 9:17 AM, ma...@apache.org wrote: >> Author: markt >> Date: Tue Nov 13 14:17:42 2012 >> New Revision: 1408739 >> >> URL: http:/

Re: [VOTE] Release Apache Tomcat 7.0.33

2012-11-21 Thread Christopher Schultz
Mark, On 11/18/12 6:34 PM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.33 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.33/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/o

Re: Test failures with trunk/head

2012-11-21 Thread Christopher Schultz
Rainer, On 11/21/12 8:33 AM, Rainer Jung wrote: > On 21.11.2012 13:34, Toby Hobson wrote: >> I'm trying to build the latest source code which I've checked out from >> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk. >> >> I created a build.properties file and I'm able to successfully build To

Re: Bug # 52529 on Tomcat 7.0.30 still rearing it's ugly head?

2012-11-30 Thread Christopher Schultz
Josh, On 11/30/12 3:47 PM, Josh Gooding wrote: > Hey, I can do that: > > java.lang.NullPointerException > at > org.intermedix.emr.ui.AbstractComboBoxInfo.populateSortedMap(AbstractComboBoxInfo.java:48) > at > org.intermedix.emr.ui.AbstractComboBoxInfo.(AbstractComboBoxInfo.java:21) > at > org.int

Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-07 Thread Christopher Schultz
Mark, On 12/4/12 4:21 PM, ma...@apache.org wrote: > +private int hashCode=0; > +// did we compute the hashcode ? > +private boolean hasHashCode = false; Should hashCode and hasHashCode be volatile? > // Hash code > > +@Override >

Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml

2012-12-07 Thread Christopher Schultz
Konstantin, On 12/5/12 3:06 AM, Konstantin Kolinko wrote: > 2012/12/5 Caldarale, Charles R : >>> From: kkoli...@apache.org [mailto:kkoli...@apache.org] >>> Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: >>> ajp.xml executor.xml http.xml >> >>> Author: kkolinko >>> Date: Wed

Re: svn commit: r1420586 [1/48] - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/auth

2012-12-12 Thread Christopher Schultz
Mark, On 12/12/12 4:42 AM, ma...@apache.org wrote: > Author: markt > Date: Wed Dec 12 09:32:51 2012 > New Revision: 1420586 > > URL: http://svn.apache.org/viewvc?rev=1420586&view=rev > Log: > Update website t.0.x docs to 7.0.34 Did we ever decide that the API Javadoc for javax.servlet was copywr

Re: svn commit: r1420586 [1/48] - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/auth

2012-12-12 Thread Christopher Schultz
Mark, On 12/12/12 3:13 PM, Mark Thomas wrote: > On 12/12/2012 19:59, Christopher Schultz wrote: >> Mark, > >> On 12/12/12 4:42 AM, ma...@apache.org wrote: >>> Author: markt Date: Wed Dec 12 09:32:51 2012 New Revision: >>> 1420586 >>> >>> URL:

Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml

2011-05-24 Thread Christopher Schultz
hould we just wait for a new release? Thanks, -chris On 5/24/2011 6:02 PM, schu...@apache.org wrote: > Author: schultz > Date: Tue May 24 22:02:27 2011 > New Revision: 1127315 > > URL: http://svn.apache.org/viewvc?rev=1127315&view=rev > Log: > Added detailed information ab

Re: mod_jk 1.2.32 [was: Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml]

2011-05-26 Thread Christopher Schultz
Rainer, On 5/26/2011 5:06 AM, Rainer Jung wrote: > There are enough changes for a 1.2.32 anyhow, so I would propose we > start a new release cycle in about 2 weeks. Sounds great. -chris signature.asc Description: OpenPGP digital signature

Re: Expected behavior of Tomcat under load

2011-05-26 Thread Christopher Schultz
Asankha, On 5/26/2011 5:01 AM, Asankha C. Perera wrote: > First of all, this is a repost from the user@ list from yesterday, as I > think this requires a reply from a developer instead of a user. The dev@ list shouldn't be used as a support forum. The user@ list is the appropriate place to post y

Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-05-31 Thread Christopher Schultz
All, I just went to check something in the 3.0 Servlet API and the most convenient place I've found is on the Tomcat site. Unfortunately, it looks like it's out of date: http://tomcat.apache.org/tomcat-7.0-doc/servletapi/index.html Many of the 3.0 classes and methods are left undocumented (for e

Re: Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-06-01 Thread Christopher Schultz
Tim, On 6/1/2011 8:35 AM, Tim Funk wrote: > Is the PDF of the spec which is downloadable up to date with respect to > comments? The version of the PDF I'm looking at (3.0 Final, 1434610 bytes, dated 10 December 2009) does not include the javadoc at all... it does include some documentation of cer

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Christopher Schultz
Keiichi, On 6/7/2011 7:37 AM, Keiichi Fujino wrote: > Index: conf/web.xml > === > --- conf/web.xml (revision 1127122) > +++ conf/web.xml (working copy) > @@ -4176,4 +4176,6 @@ > index.jsp > > > + > + >

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-07 Thread Christopher Schultz
Mark, On 6/4/2011 4:21 PM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.15 release is now available for voting. > > The proposed 7.0.15 release is: > > [X] Broken - do not release Based upon broken capability. :( -chris signature.asc Description: OpenPGP digital signature

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Christopher Schultz
Mark, On 6/7/2011 2:36 PM, Mark Thomas wrote: > On 07/06/2011 19:30, Christopher Schultz wrote: >> Keiichi, >> >> On 6/7/2011 7:37 AM, Keiichi Fujino wrote: >>> Index: conf/web.xml >>> === &g

Re: Crash in APR when pausing endpoint

2011-06-15 Thread Christopher Schultz
Rainer, On 6/13/2011 11:49 AM, Mark Thomas wrote: > Analysis and patch make sense to me. +1 Nice analysis. Nice to see I'm not the only one who can code-up a nice race condition. -chris signature.asc Description: OpenPGP digital signature

Re: Diagram for AsyncStateMachine.java

2011-06-19 Thread Christopher Schultz
Konstantin, On 6/18/2011 8:15 PM, Konstantin Kolinko wrote: > I have redrawn the state diagram for trunk's > org/apache/coyote/AsyncStateMachine.java. Would it be worth including the state transitions in AsyncStateMachine.java in "dot" format for rendering in GraphViz? -chris signature.asc De

Re: OneLineFormatter by default?

2011-06-20 Thread Christopher Schultz
Mark, On 6/20/2011 10:54 AM, Mark Thomas wrote: > On 20/06/2011 15:51, Rainer Jung wrote: >> Should we use the new OneLineFormatter as the default juli formatter? >> >> I never found anyone who liked the default java.util.logging log format, >> which spreads all messages out via two lines. One lin

Re: Overhauling setclasspath.(bat|sh)?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 7:33 AM, Rainer Jung wrote: > On 21.06.2011 11:40, Konstantin Kolinko wrote: >> 2011/6/20 Rainer Jung : >>> 1) Renaming >>> >>> Since quite some time now the setclasspath script doesn't have anything >>> to do with setting a class path. It only searches for JRE / JDK and sets

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 10:39 AM, Rainer Jung wrote: > Globs in the file name and not > the directory part is the most important use case and easy to understand > in its consequences. So I lean towards this type of improvement right now. So: /path/to/*.jar (allowed today) /path/to/foo*.ja

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 4:02 PM, Rainer Jung wrote: > But supporting a glob in the file name would also work. I'm always irritated when something that looks like it should work doesn't work. The fact that .../*.jar works but .../foo*.jar does not work is surprising, so I'm in support of adding filen

Tomcat native build requirements

2011-06-28 Thread Christopher Schultz
All, I'm reviewing a patch against the Java portion of tcnative, and I wanted to know what level of JDK support we can require. Specifically, StringBuilder is not available before JDK 1.5. Is that acceptable to use at this point? Not sure if we have to support 1.4 JVMs for the tcnative project sp

Tomcat FIPS mode questions

2011-06-28 Thread Christopher Schultz
Chris, I've been reviewing your patches to BZ 50570 (https://issues.apache.org/bugzilla/show_bug.cgi?id=50570) and I have a few questions. First, why did you change the name of the init method to initializeAPR? The method is private and should therefore be safe to re-name, but I was wondering why

Re: Tomcat FIPS mode questions

2011-06-28 Thread Christopher Schultz
Chris, On 6/28/2011 2:55 PM, Christopher Schultz wrote: > I've been reviewing your patches to BZ 50570 > (https://issues.apache.org/bugzilla/show_bug.cgi?id=50570) and I have a > few questions. Also, why the changes to java/org/apache/tomcat/jni/Library.java? If there's

Looking for review of new FIPS mode patches

2011-06-28 Thread Christopher Schultz
All, I have a small patch for tcnative's SSL.c and a somewhat more involved patch for AprLifecycleListener.java, both attached to https://issues.apache.org/bugzilla/show_bug.cgi?id=50570 I'd appreciate some review by those familiar with that code so make sure I haven't made any terrible mistakes

No release date for 7.0.16 on web site changelog

2011-06-30 Thread Christopher Schultz
All, Though TC7.0.x trunk changelog has the release date, the public web site does not. Can you trigger an update of the website to publish this date? -chris signature.asc Description: OpenPGP digital signature

Re: Time for 6.0.33?

2011-07-01 Thread Christopher Schultz
Mark, On 7/1/2011 4:32 AM, Mark Thomas wrote: > On 14/06/2011 14:09, Mark Thomas wrote: >> The changelog is getting quite long for 6.0.x. Is it time for another >> release? Jean-Frederic - are you able to RM this or do we need to find a >> volunteer for this one? > > No replies to this. Is this b

Re: extreemly simple request to add process name variable to catalina.out

2011-07-07 Thread Christopher Schultz
Lance, On 7/7/2011 12:03 PM, Campbell, Lance wrote: > Tomcat 6 enhancement: > Please consider giving us the ability to change the process name for linux > applications. I have identified all of the places I believe this needs to be > done. > > Would you please consider adding the following to

Using reflection to call tcnative methods

2011-07-08 Thread Christopher Schultz
All, I've been working in AprLifecycleListener to add FIPS support. I need to make an additional native method call in initializeSSL and I'm wondering why all of the native methods are called using reflection instead of direct method calls. The SSL class, for instance, and the AprLifecycleListene

Re: Using reflection to call tcnative methods

2011-07-09 Thread Christopher Schultz
Mladen, On 7/8/2011 11:44 PM, Mladen Turk wrote: > On 07/09/2011 04:14 AM, Christopher Schultz wrote: >> All, >> >> I've been working in AprLifecycleListener to add FIPS support. I need to >> make an additional native method call in initializeSSL and I'm wonde

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Christopher Schultz
Rainer, On 7/10/2011 3:38 PM, Rainer Jung wrote: > Unfortunately I stumbled into some code in StandardSession: > > public void setAttribute(String name, Object value, boolean notify) { > ... > if ((manager != null) && manager.getDistributable() && > !(value instanceof Serializable)) > throw

Re: [SECURITY] CVE-2011-2526 Apache Tomcat Information disclosure and availability vulnerabilities

2011-07-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, Great catch to all who were involved in discovery and mitigation of this vulnerability. Since the APR flavor of this vulnerability uses native code to crash the JVM and/or read files without asking the SecurityManager for permission, does that m

Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Christopher Schultz
All, Is there any interest in having a configuration option for WCL that allows certain thread names to be ignored during webapp shutdown? See http://markmail.org/message/vqeeyosbqxq3tim6 for a short discussion. It appears that there may sometimes be a race condition where the webapp can't force

Re: Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Christopher Schultz
Pid, On 7/14/2011 11:25 AM, Pid wrote: > On 14/07/2011 16:11, Pid wrote: >> On 14/07/2011 15:23, Christopher Schultz wrote: >>> All, >>> >>> Is there any interest in having a configuration option for WCL that >>> allows certain thread names to be ign

Re: Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Christopher Schultz
Konstantin, On 7/14/2011 11:37 AM, Konstantin Kolinko wrote: > If application is well behaving by itself (and it is up to you to > define what is well behaving) you can turn off this cleanup. > > What matters is whether there are leaks in the end or not. If there > are none, just turn off this cl

Re: tagging tc-native 1.1.21

2011-07-25 Thread Christopher Schultz
Jean-Frederic, On 7/25/2011 6:06 AM, jean-frederic clere wrote: > On 07/25/2011 11:21 AM, Henri Gomez wrote: >> nope, let's go for release. >> >> BTW, what's the main changes ? > > Just bug fixes. I will update the changelog now. Nope, it also includes the native part of FIPS mode. I forgot to u

Re: tagging tc-native 1.1.21

2011-08-01 Thread Christopher Schultz
Mladen, On 7/25/2011 3:16 PM, Mladen Turk wrote: > On 07/25/2011 07:31 PM, Christopher Schultz wrote: >> Jean-Frederic, >> >> >> Nope, it also includes the native part of FIPS mode. I forgot to update >> the changelog when I did that commit. Now updated. >&g

Re: Servlet 3.1, Tomcat 8 etc.

2011-08-01 Thread Christopher Schultz
Mark, On 7/26/2011 1:30 PM, Mark Thomas wrote: > The Servlet EG is starting to discuss changes to the Servlet API for > 3.1. It would be useful if the option existed to implement some of these > changes in Tomcat trunk. The benefits of this are: > - we can see how feasible the API changes are to i

Re: Servlet 3.1, Tomcat 8 etc.

2011-08-01 Thread Christopher Schultz
Mark, On 8/1/2011 12:05 PM, Mark Thomas wrote: > On 01/08/2011 16:45, Christopher Schultz wrote: >> Mark, >> >> On 7/26/2011 1:30 PM, Mark Thomas wrote: >>> The Servlet EG is starting to discuss changes to the Servlet API >>> for 3.1. It would be useful

Re: Servlet 3.1, Tomcat 8 etc.

2011-08-01 Thread Christopher Schultz
Mark, On 8/1/2011 2:58 PM, Mark Thomas wrote: > On 01/08/2011 19:32, Christopher Schultz wrote: >> Mark, >> >> On 8/1/2011 12:05 PM, Mark Thomas wrote: >>> On 01/08/2011 16:45, Christopher Schultz wrote: >>>> Mark, >>>> >>>>

Re: tagging tc-native 1.1.21

2011-08-08 Thread Christopher Schultz
Rainer and Mladen, On 8/1/2011 4:52 PM, Mladen Turk wrote: > On 08/01/2011 09:23 PM, Rainer Jung wrote: >> On 01.08.2011 16:50, Christopher Schultz wrote: >>> >>> Oh, I didn't realize that the trunk wasn't the tip of the 1.1 >>> branch. >>>

Re: ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-08-10 Thread Christopher Schultz
Mark, On 8/9/2011 4:35 PM, Mark Thomas wrote: > Addressing this would mean either: > a) moving the error handling to the context (inside the calls to the > ServletRequestListener) or +1 This just feels like the right state management level to me. Certainly the default error handler can be called

Re: svn commit: r1157151 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractInputBuffer.java InternalInputBuffer.java

2011-08-12 Thread Christopher Schultz
Mark, On 8/12/2011 11:17 AM, ma...@apache.org wrote: > +@Override > +public void recycle() { > +super.recycle(); > +inputStream = null; > +} If inputStream != null, should it be close()d? Or is this a shared reference for which that kind of thing isn't appropriate? Or

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-19 Thread Christopher Schultz
Konstantin, On 8/19/2011 12:34 PM, Konstantin Kolinko wrote: > 2011/8/19 : >> +private boolean awtThreadProtection = false; >> +public boolean isAWTThreadProtection() { return awtThreadProtection; } >> +public void setAWTThreadProtection(boolean awtThreadProtection) { >> + this.a

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-20 Thread Christopher Schultz
Konstantin, On 8/19/2011 3:11 PM, Konstantin Kolinko wrote: > Mark cleared the changelog file after creating the branch. > > The idea is that > * work is done on trunk > * it is merged to tc7.0.x > * items merged to tc7.0.x go into TC7's changelog file and those that > won't be merged go into TC

Re: / on end of context paths breaking existing apps

2011-08-22 Thread Christopher Schultz
Tim, On 8/21/2011 5:49 PM, Tim Whittington wrote: > The change in [1] has broken existing behaviour in some applications. To echo some of Mark's comments: > Consider the following situation: > - An application is context path /application > - The application has a servlet mapped to /* So, the o

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-23 Thread Christopher Schultz
Mark, On 8/23/2011 3:53 PM, Mark Thomas wrote: > On 21/08/2011 01:44, Christopher Schultz wrote: >> Konstantin, >> >> On 8/19/2011 3:11 PM, Konstantin Kolinko wrote: >>> Mark cleared the changelog file after creating the branch. >>> >>> The idea i

Re: DO NOT REPLY [Bug 51580] Severe error deploying WAR application (ExpandWar error)

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 10:08 AM, Konstantin Kolinko wrote: > 1. You have a typo in LC_CTYPE command above, s/8851/8859/ Thanks, I'll check that. > 2. It might be that it reads the characters correctly, but fails to print > them. > > If it were reading UTF-8 characters as ISO-8859-1, wouldn't

Re: svn commit: r1161566 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 10:14 AM, Konstantin Kolinko wrote: > Documentation part of this commit is wrong. You added attribute to a > wrong listener. > (rmiServerPortPlatform ...) Ugh. Thanks for the catch. Fixed. -chris signature.asc Description: OpenPGP digital signature

Re: svn commit: r1161601 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 11:18 AM, kkoli...@apache.org wrote: > Add changelog record for r1161566 Thanks for cleaning-up after me. I spent a bunch of time this morning trying to forward-port my fix before I realized that it had already been done. Patch isn't smart enough to say "duh, that change

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Christopher Schultz
Mark and Mick, On 8/26/2011 11:45 AM, Mark Thomas wrote: > The fix is to address the root cause which appears to be a poorly > configured system clock. I am loath to add a work-around at any point in > the Tomcat source code to handle time apparently going backwards rather > than forwards. +1 Th

Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
All, https://issues.apache.org/bugzilla/show_bug.cgi?id=51698 Mark's official report to the users' list indicates that setting a "secret" for the AJP connection does the trick. (I tried this myself before digging-up his message and can confirm that the sample code fails when a "secret" is set). S

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
Mark, On 9/8/2011 11:47 AM, Mark Thomas wrote: > On 08/09/2011 16:13, Christopher Schultz wrote: >> All, https://issues.apache.org/bugzilla/show_bug.cgi?id=51698 >> >> Mark's official report to the users' list indicates that setting a >> "secret"

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
Mark, On 9/8/2011 11:47 AM, Mark Thomas wrote: > On 08/09/2011 16:13, Christopher Schultz wrote: >> Should we mention this on the Security page directly for those who >> didn't read the announcement on the users' list? > > No reason why not. Go for it. Also, s

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-09 Thread Christopher Schultz
JF, On 9/9/2011 7:02 AM, jean-frederic clere wrote: > Yep. We need a directive to set the secret in httpd, I will discuss that > in httpd dev list. Thanks for the confirmation. -chris signature.asc Description: OpenPGP digital signature

Re: [VOTE] Release Apache Tomcat 7.0.22

2011-09-28 Thread Christopher Schultz
Mark, On 9/27/2011 5:36 PM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.22 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/ > >

Re: [VOTE] Release Apache Tomcat 7.0.22

2011-09-29 Thread Christopher Schultz
Mark, On 9/29/2011 8:09 AM, Mark Thomas wrote: > On 28/09/2011 14:43, Christopher Schultz wrote: >> Mark, > >> On 9/27/2011 5:36 PM, Mark Thomas wrote: >>> The proposed Apache Tomcat 7.0.22 release is now available for >>> voting. >>> >>>

<    11   12   13   14   15   16   17   18   19   20   >