Mark, On 11/18/12 6:34 PM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.33 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.33/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-043/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ > > The proposed 7.0.33 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 7.0.33 Stable
Not sure if my vote is binding (probably not), but I might recommend -1 Broken -- see the very end for unit test failures in AccessLogValve. Environment: Debian Linux Squeeze OpenSSL 0.9.8o (Debian Packaged) APR 1.4.2 (Debian Packaged) Sun/Oracle Java 1.6.0_26 64-bit (Debian Packaged) Apache ant 1.8.2 + md5(apache-tomcat-7.0.33.zip): Matches + GPG verify (apache-tomcat-7.0.33.zip): Matches + md5(apache-tomcat-7.0.33.tar.gz): Matches + GPG verify (apache-tomcat-7.0.33.tar.gz): Matches + md5(apache-tomcat-7.0.33.exe): Matches + GPG verify (apache-tomcat-7.0.33.exe): Matches + Binary Zip and tarball:Same + md5(apache-tomcat-7.0.33-src.zip): Matches + GPG verify (apache-tomcat-7.0.33-src.zip): Matches + md5(apache-tomcat-7.0.33-src.tar.gz): Matches + GPG verify (apache-tomcat-7.0.33-src.tar.gz): Matches + Source Zip and tarball:Same + Deps download and compile cleanly (DBCP has some ant warnings) + tcnative builds cleanly (a few minor warnings using GCC 4.4.5 glibc 2.11.3) + Tomcat Source builds cleanly (some deprecation warnings) / Tribes unit tests fail (this is expected, right?) - Other unit test failures: TEST-org.apache.catalina.valves.TestAccessLogValve.APR.txt:Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.078 sec Testcase: testBug54044 took 0.065 sec FAILED arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> junit.framework.AssertionFailedError: arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> at org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogValve.java:52) --------- TEST-org.apache.catalina.valves.TestAccessLogValve.BIO.txt:Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.048 sec Testcase: testBug54044 took 0.034 sec FAILED arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> junit.framework.AssertionFailedError: arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> at org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogValve.java:52) --------- TEST-org.apache.catalina.valves.TestAccessLogValve.NIO.txt:Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.082 sec Testcase: testBug54044 took 0.059 sec FAILED arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> junit.framework.AssertionFailedError: arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]> at org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogValve.java:52) Looks like the time zone is either not being calculated properly or not being printed to the output stream properly. -chris
signature.asc
Description: OpenPGP digital signature