Konstantin, On 8/13/12 9:06 AM, kkoli...@apache.org wrote: > Author: kkolinko > @@ -178,12 +161,14 @@ PATCHES PROPOSED TO BACKPORT: > Patch from 7.0.x should apply relatively cleanly, as it is very small: > http://svn.apache.org/viewvc?view=revision&revision=1041892 > +1: schultz > - -1: kkolinko: r1041892 is not enough. It has bad formatting, a HashMap > + 0: kkolinko: r1041892 is not enough. It has bad formatting, a HashMap > protected field (should be 'Map'), etc. See the current code of Tomcat 7. > schultz: current trunk and TC7 code has HashSet<String>. Am I > misunderstanding? > I will also add > http://svn.apache.org/viewvc?view=revision&revision=1043983 > and > http://svn.apache.org/viewvc?view=revision&revision=1049264 > to fix the formatting issues. > + kkolinko: If we missed it, then it has to be fixed in trunk. I think > + a patch for 6.0 is needed to properly review the change here.
Can I ask why the use of HashSet<String> rather than Set<String> is a problem? I intentionally used the implementation class instead of an interface for a (small) performance improvement. I'm happy to patch trunk/7.0.x/6.0.x to fix this if you feel that it is important. Thanks, -chris
signature.asc
Description: OpenPGP digital signature
